You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2021/02/22 01:45:01 UTC
[GitHub] [guacamole-manual] necouchman opened a new pull request #160: GUACAMOLE-747: Add verbiage to point users to example branding code.
necouchman opened a new pull request #160:
URL: https://github.com/apache/guacamole-manual/pull/160
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-manual] mike-jumper commented on a change in pull request #160: GUACAMOLE-747: Add verbiage to point users to example branding code.
Posted by GitBox <gi...@apache.org>.
mike-jumper commented on a change in pull request #160:
URL: https://github.com/apache/guacamole-manual/pull/160#discussion_r579949202
##########
File path: src/chapters/guacamole-ext.xml
##########
@@ -308,6 +308,10 @@
its contents will automatically be inserted directly below the login dialog (the
only element that would match <code>.login-ui .login-dialog</code>) as if they were
part of Guacamole's HTML in the first place.</para>
+ <para>An example of an extension that modifies style and HTML components for the purpose
+ of providing custom "branding" of the Guacamole Client interface can be found in the
Review comment:
I think this should be "Guacamole interface" rather than "Guacamole Client interface".
##########
File path: src/chapters/guacamole-ext.xml
##########
@@ -308,6 +308,10 @@
its contents will automatically be inserted directly below the login dialog (the
only element that would match <code>.login-ui .login-dialog</code>) as if they were
part of Guacamole's HTML in the first place.</para>
+ <para>An example of an extension that modifies style and HTML components for the purpose
+ of providing custom "branding" of the Guacamole Client interface can be found in the
+ <filename>doc/guacamole-branding-example</filename> directory of the Guacamole
+ Client source code.</para>
Review comment:
For clarity, I think this should be "the guacamole-client source code". Might also be helpful to link to: https://github.com/apache/guacamole-client/tree/master/doc/guacamole-branding-example
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-manual] necouchman commented on a change in pull request #160: GUACAMOLE-747: Add verbiage to point users to example branding code.
Posted by GitBox <gi...@apache.org>.
necouchman commented on a change in pull request #160:
URL: https://github.com/apache/guacamole-manual/pull/160#discussion_r579962097
##########
File path: src/chapters/guacamole-ext.xml
##########
@@ -308,6 +308,10 @@
its contents will automatically be inserted directly below the login dialog (the
only element that would match <code>.login-ui .login-dialog</code>) as if they were
part of Guacamole's HTML in the first place.</para>
+ <para>An example of an extension that modifies style and HTML components for the purpose
+ of providing custom "branding" of the Guacamole Client interface can be found in the
+ <filename>doc/guacamole-branding-example</filename> directory of the Guacamole
+ Client source code.</para>
Review comment:
Hopefully the way I did it makes sense - let me know if the wording is too awkward.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-manual] mike-jumper merged pull request #160: GUACAMOLE-747: Add verbiage to point users to example branding code.
Posted by GitBox <gi...@apache.org>.
mike-jumper merged pull request #160:
URL: https://github.com/apache/guacamole-manual/pull/160
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org