You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ah...@apache.org on 2019/02/13 15:44:48 UTC
[commons-rng] branch master updated (10db700 -> 8ab77a6)
This is an automated email from the ASF dual-hosted git repository.
aherbert pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/commons-rng.git.
from 10db700 [ci skip] Moved Alex Herbert from contributors to developers section
new e26fb8a Test MersenneTwister with empty seed
new 318f871 Removed duplication of managed version of maven-surefire-plugin
new d670529 Removed unused imports
new 971f862 Use n and k variables in PermutationSamplerTest
new 4eb5e74 Javadoc fix for parametric test classes
new 11bcef4 Removed Javadoc references to absent invGamma1pm1 and logGamma1p methods
new 8ab77a6 Javadoc fix
The 7 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
commons-rng-core/pom.xml | 1 -
.../org/apache/commons/rng/core/RandomAssert.java | 1 -
.../rng/core/source32/MersenneTwisterTest.java | 10 ++++++++++
commons-rng-sampling/pom.xml | 1 -
.../rng/sampling/distribution/InternalGamma.java | 23 +---------------------
.../rng/sampling/distribution/InternalUtils.java | 4 ++--
.../commons/rng/sampling/ListSamplerTest.java | 1 -
.../rng/sampling/PermutationSamplerTest.java | 2 +-
.../ContinuousSamplerParametricTest.java | 4 ++--
.../distribution/ContinuousSamplersList.java | 1 -
.../DiscreteSamplerParametricTest.java | 5 ++---
.../distribution/SmallMeanPoissonSamplerTest.java | 2 --
.../ZigguratNormalizedGaussianSamplerTest.java | 2 --
.../rng/simple/ProvidersCommonParametricTest.java | 4 ++--
14 files changed, 20 insertions(+), 41 deletions(-)
[commons-rng] 04/07: Use n and k variables in PermutationSamplerTest
Posted by ah...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-rng.git
commit 971f86266ab7c07c5f947489fdd3b3eb27c68a56
Author: aherbert <ah...@apache.org>
AuthorDate: Wed Feb 13 15:21:29 2019 +0000
Use n and k variables in PermutationSamplerTest
---
.../java/org/apache/commons/rng/sampling/PermutationSamplerTest.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/commons-rng-sampling/src/test/java/org/apache/commons/rng/sampling/PermutationSamplerTest.java b/commons-rng-sampling/src/test/java/org/apache/commons/rng/sampling/PermutationSamplerTest.java
index c887147..b82022f 100644
--- a/commons-rng-sampling/src/test/java/org/apache/commons/rng/sampling/PermutationSamplerTest.java
+++ b/commons-rng-sampling/src/test/java/org/apache/commons/rng/sampling/PermutationSamplerTest.java
@@ -38,7 +38,7 @@ public class PermutationSamplerTest {
final int n = 6;
final int k = 3;
final PermutationSampler sampler = new PermutationSampler(RandomSource.create(RandomSource.KISS),
- 6, 3);
+ n, k);
final int[] random = sampler.sample();
SAMPLE: for (int s : random) {
for (int i = 0; i < n; i++) {
[commons-rng] 05/07: Javadoc fix for parametric test classes
Posted by ah...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-rng.git
commit 4eb5e7400a6f42b3377c8b4cd414c35aaa391015
Author: aherbert <ah...@apache.org>
AuthorDate: Wed Feb 13 15:26:20 2019 +0000
Javadoc fix for parametric test classes
---
.../rng/sampling/distribution/ContinuousSamplerParametricTest.java | 4 ++--
.../rng/sampling/distribution/DiscreteSamplerParametricTest.java | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/commons-rng-sampling/src/test/java/org/apache/commons/rng/sampling/distribution/ContinuousSamplerParametricTest.java b/commons-rng-sampling/src/test/java/org/apache/commons/rng/sampling/distribution/ContinuousSamplerParametricTest.java
index 0aa880e..02dd244 100644
--- a/commons-rng-sampling/src/test/java/org/apache/commons/rng/sampling/distribution/ContinuousSamplerParametricTest.java
+++ b/commons-rng-sampling/src/test/java/org/apache/commons/rng/sampling/distribution/ContinuousSamplerParametricTest.java
@@ -35,9 +35,9 @@ public class ContinuousSamplerParametricTest {
private final ContinuousSamplerTestData sampler;
/**
- * Initializes generator instance.
+ * Initializes the test instance.
*
- * @param rng RNG to be tested.
+ * @param data sampler to be tested.
*/
public ContinuousSamplerParametricTest(ContinuousSamplerTestData data) {
sampler = data;
diff --git a/commons-rng-sampling/src/test/java/org/apache/commons/rng/sampling/distribution/DiscreteSamplerParametricTest.java b/commons-rng-sampling/src/test/java/org/apache/commons/rng/sampling/distribution/DiscreteSamplerParametricTest.java
index f22e23b..19f4526 100644
--- a/commons-rng-sampling/src/test/java/org/apache/commons/rng/sampling/distribution/DiscreteSamplerParametricTest.java
+++ b/commons-rng-sampling/src/test/java/org/apache/commons/rng/sampling/distribution/DiscreteSamplerParametricTest.java
@@ -37,9 +37,9 @@ public class DiscreteSamplerParametricTest {
private final DiscreteSamplerTestData sampler;
/**
- * Initializes the test with the test data
+ * Initializes the test instance.
*
- * @param data the test data
+ * @param data sampler to be tested.
*/
public DiscreteSamplerParametricTest(DiscreteSamplerTestData data) {
sampler = data;
[commons-rng] 03/07: Removed unused imports
Posted by ah...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-rng.git
commit d67052977b6ffbcd8431cfe780fb44111b0c130e
Author: aherbert <ah...@apache.org>
AuthorDate: Wed Feb 13 15:20:13 2019 +0000
Removed unused imports
---
.../src/test/java/org/apache/commons/rng/core/RandomAssert.java | 1 -
.../test/java/org/apache/commons/rng/sampling/ListSamplerTest.java | 1 -
.../commons/rng/sampling/distribution/ContinuousSamplersList.java | 1 -
.../rng/sampling/distribution/DiscreteSamplerParametricTest.java | 5 ++---
.../rng/sampling/distribution/SmallMeanPoissonSamplerTest.java | 2 --
.../sampling/distribution/ZigguratNormalizedGaussianSamplerTest.java | 2 --
6 files changed, 2 insertions(+), 10 deletions(-)
diff --git a/commons-rng-core/src/test/java/org/apache/commons/rng/core/RandomAssert.java b/commons-rng-core/src/test/java/org/apache/commons/rng/core/RandomAssert.java
index 0d6e5fd..37ec3bc 100644
--- a/commons-rng-core/src/test/java/org/apache/commons/rng/core/RandomAssert.java
+++ b/commons-rng-core/src/test/java/org/apache/commons/rng/core/RandomAssert.java
@@ -17,7 +17,6 @@
package org.apache.commons.rng.core;
-import java.util.Arrays;
import org.junit.Assert;
import org.apache.commons.rng.UniformRandomProvider;
diff --git a/commons-rng-sampling/src/test/java/org/apache/commons/rng/sampling/ListSamplerTest.java b/commons-rng-sampling/src/test/java/org/apache/commons/rng/sampling/ListSamplerTest.java
index bc1d1d1..daa69ca 100644
--- a/commons-rng-sampling/src/test/java/org/apache/commons/rng/sampling/ListSamplerTest.java
+++ b/commons-rng-sampling/src/test/java/org/apache/commons/rng/sampling/ListSamplerTest.java
@@ -21,7 +21,6 @@ import java.util.HashSet;
import java.util.List;
import java.util.ArrayList;
import java.util.Collection;
-import java.util.Arrays;
import org.junit.Assert;
import org.junit.Test;
diff --git a/commons-rng-sampling/src/test/java/org/apache/commons/rng/sampling/distribution/ContinuousSamplersList.java b/commons-rng-sampling/src/test/java/org/apache/commons/rng/sampling/distribution/ContinuousSamplersList.java
index 527758d..991b408 100644
--- a/commons-rng-sampling/src/test/java/org/apache/commons/rng/sampling/distribution/ContinuousSamplersList.java
+++ b/commons-rng-sampling/src/test/java/org/apache/commons/rng/sampling/distribution/ContinuousSamplersList.java
@@ -16,7 +16,6 @@
*/
package org.apache.commons.rng.sampling.distribution;
-import java.util.Arrays;
import java.util.List;
import java.util.ArrayList;
import java.util.Collections;
diff --git a/commons-rng-sampling/src/test/java/org/apache/commons/rng/sampling/distribution/DiscreteSamplerParametricTest.java b/commons-rng-sampling/src/test/java/org/apache/commons/rng/sampling/distribution/DiscreteSamplerParametricTest.java
index 3cf6455..f22e23b 100644
--- a/commons-rng-sampling/src/test/java/org/apache/commons/rng/sampling/distribution/DiscreteSamplerParametricTest.java
+++ b/commons-rng-sampling/src/test/java/org/apache/commons/rng/sampling/distribution/DiscreteSamplerParametricTest.java
@@ -26,7 +26,6 @@ import org.junit.runner.RunWith;
import org.junit.runners.Parameterized;
import org.junit.runners.Parameterized.Parameters;
-import org.apache.commons.math3.distribution.ChiSquaredDistribution;
import org.apache.commons.math3.stat.inference.ChiSquareTest;
/**
@@ -38,9 +37,9 @@ public class DiscreteSamplerParametricTest {
private final DiscreteSamplerTestData sampler;
/**
- * Initializes generator instance.
+ * Initializes the test with the test data
*
- * @param rng RNG to be tested.
+ * @param data the test data
*/
public DiscreteSamplerParametricTest(DiscreteSamplerTestData data) {
sampler = data;
diff --git a/commons-rng-sampling/src/test/java/org/apache/commons/rng/sampling/distribution/SmallMeanPoissonSamplerTest.java b/commons-rng-sampling/src/test/java/org/apache/commons/rng/sampling/distribution/SmallMeanPoissonSamplerTest.java
index 775f326..0d8d5c7 100644
--- a/commons-rng-sampling/src/test/java/org/apache/commons/rng/sampling/distribution/SmallMeanPoissonSamplerTest.java
+++ b/commons-rng-sampling/src/test/java/org/apache/commons/rng/sampling/distribution/SmallMeanPoissonSamplerTest.java
@@ -16,10 +16,8 @@
*/
package org.apache.commons.rng.sampling.distribution;
-import org.apache.commons.rng.RandomProviderState;
import org.apache.commons.rng.RestorableUniformRandomProvider;
import org.apache.commons.rng.simple.RandomSource;
-import org.junit.Assert;
import org.junit.Test;
/**
diff --git a/commons-rng-sampling/src/test/java/org/apache/commons/rng/sampling/distribution/ZigguratNormalizedGaussianSamplerTest.java b/commons-rng-sampling/src/test/java/org/apache/commons/rng/sampling/distribution/ZigguratNormalizedGaussianSamplerTest.java
index ebeea5b..3718111 100644
--- a/commons-rng-sampling/src/test/java/org/apache/commons/rng/sampling/distribution/ZigguratNormalizedGaussianSamplerTest.java
+++ b/commons-rng-sampling/src/test/java/org/apache/commons/rng/sampling/distribution/ZigguratNormalizedGaussianSamplerTest.java
@@ -16,9 +16,7 @@
*/
package org.apache.commons.rng.sampling.distribution;
-import org.junit.Assert;
import org.junit.Test;
-import org.apache.commons.rng.simple.RandomSource;
import org.apache.commons.rng.UniformRandomProvider;
/**
[commons-rng] 01/07: Test MersenneTwister with empty seed
Posted by ah...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-rng.git
commit e26fb8afcfced8cba214a92501cc93e6b50f55ce
Author: aherbert <ah...@apache.org>
AuthorDate: Wed Feb 13 15:03:37 2019 +0000
Test MersenneTwister with empty seed
---
.../apache/commons/rng/core/source32/MersenneTwisterTest.java | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/commons-rng-core/src/test/java/org/apache/commons/rng/core/source32/MersenneTwisterTest.java b/commons-rng-core/src/test/java/org/apache/commons/rng/core/source32/MersenneTwisterTest.java
index c32b099..a215f05 100644
--- a/commons-rng-core/src/test/java/org/apache/commons/rng/core/source32/MersenneTwisterTest.java
+++ b/commons-rng-core/src/test/java/org/apache/commons/rng/core/source32/MersenneTwisterTest.java
@@ -17,6 +17,7 @@
package org.apache.commons.rng.core.source32;
import org.apache.commons.rng.core.RandomAssert;
+import org.junit.Assert;
import org.junit.Test;
public class MersenneTwisterTest {
@@ -159,4 +160,13 @@ public class MersenneTwisterTest {
RandomAssert.assertEquals(expectedSequence, rng);
}
+
+ @Test
+ public void testConstructorWithEmptySeed() {
+ // An empty seed is allowed
+ final MersenneTwister rng = new MersenneTwister(new int[0]);
+ // It should be functional so check it returns different values.
+ Assert.assertNotEquals("Empty seed creates sequence with same values",
+ rng.nextInt(), rng.nextInt());
+ }
}
[commons-rng] 07/07: Javadoc fix
Posted by ah...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-rng.git
commit 8ab77a64038d1dba0822f8c0afdc629576623abd
Author: aherbert <ah...@apache.org>
AuthorDate: Wed Feb 13 15:39:57 2019 +0000
Javadoc fix
---
.../org/apache/commons/rng/sampling/distribution/InternalUtils.java | 4 ++--
.../org/apache/commons/rng/simple/ProvidersCommonParametricTest.java | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/commons-rng-sampling/src/main/java/org/apache/commons/rng/sampling/distribution/InternalUtils.java b/commons-rng-sampling/src/main/java/org/apache/commons/rng/sampling/distribution/InternalUtils.java
index 11205bd..287cc8f 100644
--- a/commons-rng-sampling/src/main/java/org/apache/commons/rng/sampling/distribution/InternalUtils.java
+++ b/commons-rng-sampling/src/main/java/org/apache/commons/rng/sampling/distribution/InternalUtils.java
@@ -49,8 +49,8 @@ class InternalUtils { // Class is package-private on purpose; do not make it pub
/**
* Class for computing the natural logarithm of the factorial of {@code n}.
* It allows to allocate a cache of precomputed values.
- * In case of cache miss, computation is preformed by a call to
- * {@link Gamma#logGamma(double)}.
+ * In case of cache miss, computation is performed by a call to
+ * {@link InternalGamma#logGamma(double)}.
*/
public static final class FactorialLog {
/**
diff --git a/commons-rng-simple/src/test/java/org/apache/commons/rng/simple/ProvidersCommonParametricTest.java b/commons-rng-simple/src/test/java/org/apache/commons/rng/simple/ProvidersCommonParametricTest.java
index c002392..513ddbf 100644
--- a/commons-rng-simple/src/test/java/org/apache/commons/rng/simple/ProvidersCommonParametricTest.java
+++ b/commons-rng-simple/src/test/java/org/apache/commons/rng/simple/ProvidersCommonParametricTest.java
@@ -54,9 +54,9 @@ public class ProvidersCommonParametricTest {
private final Object[] originalArgs;
/**
- * Initializes generator instance.
+ * Initializes the test instance.
*
- * @param rng RNG to be tested.
+ * @param data Random source (and seed arguments) to be tested.
*/
public ProvidersCommonParametricTest(ProvidersList.Data data) {
originalSource = data.getSource();
[commons-rng] 02/07: Removed duplication of managed version of
maven-surefire-plugin
Posted by ah...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-rng.git
commit 318f8719f37c212327726428dc2987d214460ee7
Author: aherbert <ah...@apache.org>
AuthorDate: Wed Feb 13 15:11:35 2019 +0000
Removed duplication of managed version of maven-surefire-plugin
---
commons-rng-core/pom.xml | 1 -
commons-rng-sampling/pom.xml | 1 -
2 files changed, 2 deletions(-)
diff --git a/commons-rng-core/pom.xml b/commons-rng-core/pom.xml
index 2bdfd67..ceeaf48 100644
--- a/commons-rng-core/pom.xml
+++ b/commons-rng-core/pom.xml
@@ -59,7 +59,6 @@
<plugins>
<plugin>
<artifactId>maven-surefire-plugin</artifactId>
- <version>2.22.0</version>
<configuration>
<rerunFailingTestsCount>2</rerunFailingTestsCount>
</configuration>
diff --git a/commons-rng-sampling/pom.xml b/commons-rng-sampling/pom.xml
index 304417c..c0da2e4 100644
--- a/commons-rng-sampling/pom.xml
+++ b/commons-rng-sampling/pom.xml
@@ -70,7 +70,6 @@
<plugins>
<plugin>
<artifactId>maven-surefire-plugin</artifactId>
- <version>2.22.0</version>
<configuration>
<rerunFailingTestsCount>1</rerunFailingTestsCount>
</configuration>
[commons-rng] 06/07: Removed Javadoc references to absent
invGamma1pm1 and logGamma1p methods
Posted by ah...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-rng.git
commit 11bcef46397cd0d99e61e71b0c526637a131d8b2
Author: aherbert <ah...@apache.org>
AuthorDate: Wed Feb 13 15:36:33 2019 +0000
Removed Javadoc references to absent invGamma1pm1 and logGamma1p methods
---
.../rng/sampling/distribution/InternalGamma.java | 23 +---------------------
1 file changed, 1 insertion(+), 22 deletions(-)
diff --git a/commons-rng-sampling/src/main/java/org/apache/commons/rng/sampling/distribution/InternalGamma.java b/commons-rng-sampling/src/main/java/org/apache/commons/rng/sampling/distribution/InternalGamma.java
index 1421f0a..8317510 100644
--- a/commons-rng-sampling/src/main/java/org/apache/commons/rng/sampling/distribution/InternalGamma.java
+++ b/commons-rng-sampling/src/main/java/org/apache/commons/rng/sampling/distribution/InternalGamma.java
@@ -28,31 +28,10 @@ package org.apache.commons.rng.sampling.distribution;
* This is a utility class that provides computation methods related to the
* Γ (Gamma) family of functions.
* </p>
- * <p>
- * Implementation of {@link #invGamma1pm1(double)} and
- * {@link #logGamma1p(double)} is based on the algorithms described in
- * <ul>
- * <li><a href="http://dx.doi.org/10.1145/22721.23109">Didonato and Morris
- * (1986)</a>, <em>Computation of the Incomplete Gamma Function Ratios and
- * their Inverse</em>, TOMS 12(4), 377-393,</li>
- * <li><a href="http://dx.doi.org/10.1145/131766.131776">Didonato and Morris
- * (1992)</a>, <em>Algorithm 708: Significant Digit Computation of the
- * Incomplete Beta Function Ratios</em>, TOMS 18(3), 360-373,</li>
- * </ul>
- * and implemented in the
- * <a href="http://www.dtic.mil/docs/citations/ADA476840">NSWC Library of Mathematical Functions</a>,
- * available
- * <a href="http://www.ualberta.ca/CNS/RESEARCH/Software/NumericalNSWC/site.html">here</a>.
- * This library is "approved for public release", and the
- * <a href="http://www.dtic.mil/dtic/pdf/announcements/CopyrightGuidance.pdf">Copyright guidance</a>
- * indicates that unless otherwise stated in the code, all FORTRAN functions in
- * this library are license free. Since no such notice appears in the code these
- * functions can safely be ported to Commons-Math.
- * </p>
*/
class InternalGamma { // Class is package-private on purpose; do not make it public.
/**
- * Constant \( g = \frac{607}{128} \) in the {@link #lanczos(double) Lanczos approximation}.
+ * Constant \( g = \frac{607}{128} \) in the Lanczos approximation.
*/
public static final double LANCZOS_G = 607.0 / 128.0;