You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/03/12 13:30:05 UTC
[GitHub] [incubator-doris] kangkaisen opened a new pull request #3096:
Rewrite count distinct to bitmap hll
kangkaisen opened a new pull request #3096: Rewrite count distinct to bitmap hll
URL: https://github.com/apache/incubator-doris/pull/3096
For https://github.com/apache/incubator-doris/issues/3095
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] kangkaisen merged pull request #3096: Rewrite
count distinct to bitmap hll
Posted by GitBox <gi...@apache.org>.
kangkaisen merged pull request #3096: Rewrite count distinct to bitmap hll
URL: https://github.com/apache/incubator-doris/pull/3096
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] imay commented on a change in pull request #3096:
Rewrite count distinct to bitmap hll
Posted by GitBox <gi...@apache.org>.
imay commented on a change in pull request #3096: Rewrite count distinct to bitmap hll
URL: https://github.com/apache/incubator-doris/pull/3096#discussion_r391645608
##########
File path: fe/src/main/java/org/apache/doris/analysis/FunctionCallExpr.java
##########
@@ -249,6 +249,23 @@ public boolean isCountStar() {
return false;
}
+ public boolean needRewriteCountDistinct() {
Review comment:
isCountDistinctSet?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] imay commented on a change in pull request #3096:
Rewrite count distinct to bitmap hll
Posted by GitBox <gi...@apache.org>.
imay commented on a change in pull request #3096: Rewrite count distinct to bitmap hll
URL: https://github.com/apache/incubator-doris/pull/3096#discussion_r391642931
##########
File path: fe/src/main/java/org/apache/doris/qe/SessionVariable.java
##########
@@ -91,6 +91,7 @@
public static final String DEFAULT_ROWSET_TYPE = "default_rowset_type";
public static final String USE_V2_ROLLUP = "use_v2_rollup";
public static final String TEST_MATERIALIZED_VIEW = "test_materialized_view";
+ public static final String REWRITE_COUNT_DISTINCT_TO_BITMAP_HLL = "rewrite_count_distinct_to_bitmap_hll";
Review comment:
Add a document?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org