You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by Michael McCandless <lu...@mikemccandless.com> on 2009/07/14 18:43:46 UTC
2.9 issues remaining
We are down to 20 issues left for 2.9!
For those of you who have 2.9 issues assigned to you, but haven't
started yet or won't be able to get to them soon, can you unassign
yourself, and/or push the issue out?
I'd like to start taking some of them.
I realize a number of issues are held up on LUCENE-1693, so we really
need get that [big] one done soon.
Mike
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
RE: 2.9 issues remaining
Posted by Uwe Schindler <uw...@thetaphi.de>.
Here it is, I hope I did not do the same cleanups in a different way than
you did them. I changed a lot in AttributeSource to make it better fit with
multiple attributes per instance (hashCode, toString() and equals() as well
as captureState/restoreState now work on implementation instances.
captureRestore now also works, when the order of attributes is different.
-----
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: uwe@thetaphi.de
_____
From: Michael Busch [mailto:buschmic@gmail.com]
Sent: Tuesday, July 14, 2009 7:28 PM
To: java-dev@lucene.apache.org
Subject: Re: 2.9 issues remaining
Hi Uwe,
I continued yesterday evening with making some cleanups on 1693. You can
leave it assigned to me, I'm working on it today.
I'll update to your latest patch after you submitted it.
Michael
On 7/14/09 10:18 AM, Uwe Schindler wrote:
Yes I make progress with 1693!!! I think I assign to this, as Michael seems
to have no time to review and work on it.
I am currently repairing the last problems and inconsistencies in the
AttributeSource with captureState and toString and so on, because attributes
can now be implemented by more than one impl and one impl can implement more
than one attribute (best example: Token).
I will post a patch very soon (the last tests are running now). I also added
a lot of new tests :-)
After that 1693 needs only your idea from 1678, to detect if in non-final
classes, any subclass overrides deprecated methods. Problematic core token
streams are:
- ISOLatin1Filter (no-final and deprecated, so maybe it should not implement
incrementToken at all) -> would be fixed then.
- KeywordTokenizer should normally be final, but is not :( -> needs this
special trick
- StandardTokenizer is the same, should be final, but isn't
If these three would not be there, I could finish 1693 now. Contrib
analyzers could have this prob, too, but this must be checked when doing the
transformation there. If the backwards wrapper is available, we could do
this like with the analyzers in 1678.
-----
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: uwe@thetaphi.de
-----Original Message-----
From: Michael McCandless [mailto:lucene@mikemccandless.com]
Sent: Tuesday, July 14, 2009 6:44 PM
To: java-dev@lucene.apache.org
Subject: 2.9 issues remaining
We are down to 20 issues left for 2.9!
For those of you who have 2.9 issues assigned to you, but haven't
started yet or won't be able to get to them soon, can you unassign
yourself, and/or push the issue out?
I'd like to start taking some of them.
I realize a number of issues are held up on LUCENE-1693, so we really
need get that [big] one done soon.
Mike
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
Re: 2.9 issues remaining
Posted by Michael Busch <bu...@gmail.com>.
Hi Uwe,
I continued yesterday evening with making some cleanups on 1693. You can
leave it assigned to me, I'm working on it today.
I'll update to your latest patch after you submitted it.
Michael
On 7/14/09 10:18 AM, Uwe Schindler wrote:
> Yes I make progress with 1693!!! I think I assign to this, as Michael seems
> to have no time to review and work on it.
>
> I am currently repairing the last problems and inconsistencies in the
> AttributeSource with captureState and toString and so on, because attributes
> can now be implemented by more than one impl and one impl can implement more
> than one attribute (best example: Token).
>
> I will post a patch very soon (the last tests are running now). I also added
> a lot of new tests :-)
>
> After that 1693 needs only your idea from 1678, to detect if in non-final
> classes, any subclass overrides deprecated methods. Problematic core token
> streams are:
> - ISOLatin1Filter (no-final and deprecated, so maybe it should not implement
> incrementToken at all) -> would be fixed then.
> - KeywordTokenizer should normally be final, but is not :( -> needs this
> special trick
> - StandardTokenizer is the same, should be final, but isn't
>
> If these three would not be there, I could finish 1693 now. Contrib
> analyzers could have this prob, too, but this must be checked when doing the
> transformation there. If the backwards wrapper is available, we could do
> this like with the analyzers in 1678.
>
> -----
> Uwe Schindler
> H.-H.-Meier-Allee 63, D-28213 Bremen
> http://www.thetaphi.de
> eMail: uwe@thetaphi.de
>
>
>> -----Original Message-----
>> From: Michael McCandless [mailto:lucene@mikemccandless.com]
>> Sent: Tuesday, July 14, 2009 6:44 PM
>> To: java-dev@lucene.apache.org
>> Subject: 2.9 issues remaining
>>
>> We are down to 20 issues left for 2.9!
>>
>> For those of you who have 2.9 issues assigned to you, but haven't
>> started yet or won't be able to get to them soon, can you unassign
>> yourself, and/or push the issue out?
>>
>> I'd like to start taking some of them.
>>
>> I realize a number of issues are held up on LUCENE-1693, so we really
>> need get that [big] one done soon.
>>
>> Mike
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: java-dev-help@lucene.apache.org
>>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: java-dev-help@lucene.apache.org
>
>
>
RE: 2.9 issues remaining
Posted by Uwe Schindler <uw...@thetaphi.de>.
Yes I make progress with 1693!!! I think I assign to this, as Michael seems
to have no time to review and work on it.
I am currently repairing the last problems and inconsistencies in the
AttributeSource with captureState and toString and so on, because attributes
can now be implemented by more than one impl and one impl can implement more
than one attribute (best example: Token).
I will post a patch very soon (the last tests are running now). I also added
a lot of new tests :-)
After that 1693 needs only your idea from 1678, to detect if in non-final
classes, any subclass overrides deprecated methods. Problematic core token
streams are:
- ISOLatin1Filter (no-final and deprecated, so maybe it should not implement
incrementToken at all) -> would be fixed then.
- KeywordTokenizer should normally be final, but is not :( -> needs this
special trick
- StandardTokenizer is the same, should be final, but isn't
If these three would not be there, I could finish 1693 now. Contrib
analyzers could have this prob, too, but this must be checked when doing the
transformation there. If the backwards wrapper is available, we could do
this like with the analyzers in 1678.
-----
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: uwe@thetaphi.de
> -----Original Message-----
> From: Michael McCandless [mailto:lucene@mikemccandless.com]
> Sent: Tuesday, July 14, 2009 6:44 PM
> To: java-dev@lucene.apache.org
> Subject: 2.9 issues remaining
>
> We are down to 20 issues left for 2.9!
>
> For those of you who have 2.9 issues assigned to you, but haven't
> started yet or won't be able to get to them soon, can you unassign
> yourself, and/or push the issue out?
>
> I'd like to start taking some of them.
>
> I realize a number of issues are held up on LUCENE-1693, so we really
> need get that [big] one done soon.
>
> Mike
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: java-dev-help@lucene.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
Re: 2.9 issues remaining
Posted by Mark Miller <ma...@gmail.com>.
>> LUCENE-1628 Persian Analyzer LUCENE-1583 SpanOrQuery skipTo()
>> doesn't always move forwards
>>
>> Fairly straightforward, but I havn't looked too hard yet - feel free to
>> take.
>I'm confused -- it looks like you have dug into both of these (1628 and
1583)?
Sorry - that line should just be 1628 there - I didn't see 1583 snuck in on
that line - I addressed it below:
> LUCENE-1583 SpanOrQuery skipTo() doesn't always move forwards
>
> This one is basically ready to be committed to.
I looked at 1628, but long enough ago now that I remember nothing - Im sure
visiting the JIRA issue would refresh my memory.
- Mark
On Tue, Jul 14, 2009 at 2:24 PM, Michael McCandless <
lucene@mikemccandless.com> wrote:
> On Tue, Jul 14, 2009 at 1:02 PM, Mark Miller<ma...@gmail.com> wrote:
> > For my issues:
> >
> > LUCENE-1695 Update the Highlighter to use the new TokenStream API
> >
> > I've done most of the work, but 1693 changes things and I've been
> waiting...
> >
> > LUCENE-1685 Make the Highlighter use SpanScorer
> >
> > I started a little - but all kinds of conflicts between 1693 and 1695 so
> > been trying to hold off till I can commit 1695...
> >
> > LUCENE-1628 Persian Analyzer LUCENE-1583 SpanOrQuery skipTo()
> > doesn't always move forwards
> >
> > Fairly straightforward, but I havn't looked too hard yet - feel free to
> > take.
>
> I'm confused -- it looks like you have dug into both of these (1628 and
> 1583)?
>
> > LUCENE-1725 Benchmark package uses new TopFieldCollector but also
> still
> > uses AUTO without resolving it - result is, our sort algorithms won't run
> >
> > I can get this - just need a few spare minutes sometime soon.
> >
> > LUCENE-1688 Deprecating StopAnalyzer ENGLISH_STOP_WORDS - General
> > replacement with an immutable Set
> >
> > I think this patch is ready to go, I just havn't committed yet.
> >
> > LUCENE-1583 SpanOrQuery skipTo() doesn't always move forwards
> >
> > This one is basically ready to be committed to.
> >
> > On Tue, Jul 14, 2009 at 12:43 PM, Michael McCandless
> > <lu...@mikemccandless.com> wrote:
> >>
> >> We are down to 20 issues left for 2.9!
> >>
> >> For those of you who have 2.9 issues assigned to you, but haven't
> >> started yet or won't be able to get to them soon, can you unassign
> >> yourself, and/or push the issue out?
> >>
> >> I'd like to start taking some of them.
> >>
> >> I realize a number of issues are held up on LUCENE-1693, so we really
> >> need get that [big] one done soon.
> >>
> >> Mike
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> >> For additional commands, e-mail: java-dev-help@lucene.apache.org
> >>
> >
> >
> >
> > --
> > --
> > - Mark
> >
> > http://www.lucidimagination.com
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: java-dev-help@lucene.apache.org
>
>
--
--
- Mark
http://www.lucidimagination.com
Re: 2.9 issues remaining
Posted by Michael McCandless <lu...@mikemccandless.com>.
On Tue, Jul 14, 2009 at 1:02 PM, Mark Miller<ma...@gmail.com> wrote:
> For my issues:
>
> LUCENE-1695 Update the Highlighter to use the new TokenStream API
>
> I've done most of the work, but 1693 changes things and I've been waiting...
>
> LUCENE-1685 Make the Highlighter use SpanScorer
>
> I started a little - but all kinds of conflicts between 1693 and 1695 so
> been trying to hold off till I can commit 1695...
>
> LUCENE-1628 Persian Analyzer LUCENE-1583 SpanOrQuery skipTo()
> doesn't always move forwards
>
> Fairly straightforward, but I havn't looked too hard yet - feel free to
> take.
I'm confused -- it looks like you have dug into both of these (1628 and 1583)?
> LUCENE-1725 Benchmark package uses new TopFieldCollector but also still
> uses AUTO without resolving it - result is, our sort algorithms won't run
>
> I can get this - just need a few spare minutes sometime soon.
>
> LUCENE-1688 Deprecating StopAnalyzer ENGLISH_STOP_WORDS - General
> replacement with an immutable Set
>
> I think this patch is ready to go, I just havn't committed yet.
>
> LUCENE-1583 SpanOrQuery skipTo() doesn't always move forwards
>
> This one is basically ready to be committed to.
>
> On Tue, Jul 14, 2009 at 12:43 PM, Michael McCandless
> <lu...@mikemccandless.com> wrote:
>>
>> We are down to 20 issues left for 2.9!
>>
>> For those of you who have 2.9 issues assigned to you, but haven't
>> started yet or won't be able to get to them soon, can you unassign
>> yourself, and/or push the issue out?
>>
>> I'd like to start taking some of them.
>>
>> I realize a number of issues are held up on LUCENE-1693, so we really
>> need get that [big] one done soon.
>>
>> Mike
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: java-dev-help@lucene.apache.org
>>
>
>
>
> --
> --
> - Mark
>
> http://www.lucidimagination.com
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
Re: 2.9 issues remaining
Posted by Mark Miller <ma...@gmail.com>.
For my issues:
LUCENE-1695 Update the Highlighter to use the new TokenStream API
I've done most of the work, but 1693 changes things and I've been waiting...
LUCENE-1685 Make the Highlighter use SpanScorer
I started a little - but all kinds of conflicts between 1693 and 1695 so
been trying to hold off till I can commit 1695...
LUCENE-1628 Persian Analyzer LUCENE-1583 SpanOrQuery skipTo()
doesn't always move forwards
Fairly straightforward, but I havn't looked too hard yet - feel free to
take.
LUCENE-1725 Benchmark package uses new TopFieldCollector but also still
uses AUTO without resolving it - result is, our sort algorithms won't run
I can get this - just need a few spare minutes sometime soon.
LUCENE-1688 Deprecating StopAnalyzer ENGLISH_STOP_WORDS - General
replacement with an immutable Set
I think this patch is ready to go, I just havn't committed yet.
LUCENE-1583 SpanOrQuery skipTo() doesn't always move forwards
This one is basically ready to be committed to.
On Tue, Jul 14, 2009 at 12:43 PM, Michael McCandless <
lucene@mikemccandless.com> wrote:
> We are down to 20 issues left for 2.9!
>
> For those of you who have 2.9 issues assigned to you, but haven't
> started yet or won't be able to get to them soon, can you unassign
> yourself, and/or push the issue out?
>
> I'd like to start taking some of them.
>
> I realize a number of issues are held up on LUCENE-1693, so we really
> need get that [big] one done soon.
>
> Mike
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: java-dev-help@lucene.apache.org
>
>
--
--
- Mark
http://www.lucidimagination.com