You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2018/08/28 17:25:09 UTC
Review Request 68543: Added stout helper to parse strings to protobuf
messages.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68543/
-----------------------------------------------------------
Review request for mesos, Joseph Wu and Kevin Klues.
Repository: mesos
Description
-------
Added stout helper to parse strings to protobuf messages.
Diffs
-----
3rdparty/stout/include/stout/protobuf.hpp 1d03e1e3a8dd642f7239d777fb04759caf100a8b
3rdparty/stout/tests/protobuf_tests.cpp 95cdc67cdab0aeef2ce18aa0c99bc2952c2b5dc5
Diff: https://reviews.apache.org/r/68543/diff/1/
Testing
-------
New test passes.
Thanks,
Greg Mann
Re: Review Request 68543: Added stout helper to parse strings to
protobuf messages.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68543/#review208173
-----------------------------------------------------------
Patch looks great!
Reviews applied: [68543]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Aug. 28, 2018, 5:25 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68543/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2018, 5:25 p.m.)
>
>
> Review request for mesos, Joseph Wu and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added stout helper to parse strings to protobuf messages.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/protobuf.hpp 1d03e1e3a8dd642f7239d777fb04759caf100a8b
> 3rdparty/stout/tests/protobuf_tests.cpp 95cdc67cdab0aeef2ce18aa0c99bc2952c2b5dc5
>
>
> Diff: https://reviews.apache.org/r/68543/diff/1/
>
>
> Testing
> -------
>
> New test passes.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 68543: Added stout helper to parse strings to
protobuf messages.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68543/#review208057
-----------------------------------------------------------
PASS: Mesos patch 68543 was successfully built and tested.
Reviews applied: `['68543']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2252/mesos-review-68543
- Mesos Reviewbot Windows
On Aug. 28, 2018, 5:25 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68543/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2018, 5:25 p.m.)
>
>
> Review request for mesos, Joseph Wu and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added stout helper to parse strings to protobuf messages.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/protobuf.hpp 1d03e1e3a8dd642f7239d777fb04759caf100a8b
> 3rdparty/stout/tests/protobuf_tests.cpp 95cdc67cdab0aeef2ce18aa0c99bc2952c2b5dc5
>
>
> Diff: https://reviews.apache.org/r/68543/diff/1/
>
>
> Testing
> -------
>
> New test passes.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 68543: Added stout helper to parse strings to
protobuf messages.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68543/#review208056
-----------------------------------------------------------
3rdparty/stout/include/stout/protobuf.hpp
Lines 778 (patched)
<https://reviews.apache.org/r/68543/#comment291801>
Using `flags::parse` will include some deprecated behavior (if the string starts with `"/"`, we will attempt to read a location on disk). `JSON::parse<JSON::Object>` would be a better choice.
- Joseph Wu
On Aug. 28, 2018, 10:25 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68543/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2018, 10:25 a.m.)
>
>
> Review request for mesos, Joseph Wu and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added stout helper to parse strings to protobuf messages.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/protobuf.hpp 1d03e1e3a8dd642f7239d777fb04759caf100a8b
> 3rdparty/stout/tests/protobuf_tests.cpp 95cdc67cdab0aeef2ce18aa0c99bc2952c2b5dc5
>
>
> Diff: https://reviews.apache.org/r/68543/diff/1/
>
>
> Testing
> -------
>
> New test passes.
>
>
> Thanks,
>
> Greg Mann
>
>