[GitHub] cgivre opened a new pull request #6610: Initial Commit

[GitBox <gi...@apache.org>]

cgivre opened a new pull request #6610: Initial Commit
URL: https://github.com/apache/incubator-superset/pull/6610
 
 
   This is the first attempt at support for Apache Drill in Superset.  This uses John Omernik's SQLAlchemy dialect (https://github.com/JohnOmernik/sqlalchemy-drill).
   
   Drill has a unique aspect in its namespace which proved problematic.  Drill uses the concepts of:
   
   - Storage Plugin
   - Workspace
   - Table (or file)
   
   When connecting to Drill to a non-file based system, the behavior is pretty much as a traditional database.  However, when Drill is querying a file based system, you can have additional `.` in the namespace that are not namespace related.   For example:  
   ```
   dfs.test.`data.json`
   ```
   In this case, the storage plugin is `dfs`, the workspace which is optional is `test`, and the table, which in this case is a file, is `data.json`.  In this case however, the last period is not part of the namespace and was consistently misinterpreted by Superset.  
   
   The solution I found, which seemed like complete hackery, was to replace the last period with `@@@` in the dropdown in SQLlab.  Then I modified `view/core.py` to replace the `@@@` with a period in the various functions that generate tables.   
   
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org