[jira] [Commented] (FLINK-4086) Hide internal Expression methods from Table API

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-4086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15336038#comment-15336038 ] 

ASF GitHub Bot commented on FLINK-4086:
---------------------------------------

GitHub user fhueske opened a pull request:

    https://github.com/apache/flink/pull/2126

    [FLINK-4086] [tableAPI] Hide internal methods of Expressions from Table API.

    Added the `private[flink]` access modifier to all internal methods of `Expressions`

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/fhueske/flink tableInternalExpr

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2126.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2126
    
----
commit d36ea15aedeba8913fc4b289d2fbcecce20a01a7
Author: Fabian Hueske <fh...@apache.org>
Date:   2016-06-17T13:16:42Z

    [FLINK-4086] [tableAPI] Hide internal methods of Expressions from Table API.

----


> Hide internal Expression methods from Table API
> -----------------------------------------------
>
>                 Key: FLINK-4086
>                 URL: https://issues.apache.org/jira/browse/FLINK-4086
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>    Affects Versions: 1.1.0
>            Reporter: Fabian Hueske
>            Assignee: Fabian Hueske
>             Fix For: 1.1.0
>
>
> Internal methods are accessible from the Table API expressions.
> For instance it is possible to call:
> {code}
> val table: Table = ???
> table.select('name.toRexNode(), ('age + 10).validateInput())
> {code}
> We should hide internal methods like {{toRexNode()}} and {{validateInput()}} from the API.
> I propose to restrict access to this methods to objects in the {{org.apache.flink}} name space via a {{private\[flink\]}} access modifier.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)