You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/21 13:27:17 UTC

[GitHub] [flink] lirui-apache opened a new pull request #11175: [FLINK-16197][hive] Failed to query partitioned table when partition …

lirui-apache opened a new pull request #11175: [FLINK-16197][hive] Failed to query partitioned table when partition …
URL: https://github.com/apache/flink/pull/11175
 
 
   …folder is removed
   
   <!--
   *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
   
   *Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
     
     - Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
     Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](https://flink.apache.org/contributing/contribute-code.html#open-a-pull-request).
   
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message (including the JIRA id)
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   ## What is the purpose of the change
   
   To fix the issue of querying a table whose partition folder is removed.
   
   
   ## Brief change log
   
     - When generating input splits, skip a partition if the data folder doesn't exist.
     - Add test
   
   
   ## Verifying this change
   
   Added test case
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? NA
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11175: [FLINK-16197][hive] Failed to query partitioned table when partition …

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11175: [FLINK-16197][hive] Failed to query partitioned table when partition …
URL: https://github.com/apache/flink/pull/11175#issuecomment-589671100
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "53fda3bf9cc936fee8c1925c76730df8d9ee6381",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/150017255",
       "triggerID" : "53fda3bf9cc936fee8c1925c76730df8d9ee6381",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8aedd02e74d1a07be08e367b693ad82d69bfde3b",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "8aedd02e74d1a07be08e367b693ad82d69bfde3b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 53fda3bf9cc936fee8c1925c76730df8d9ee6381 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150017255) 
   * 8aedd02e74d1a07be08e367b693ad82d69bfde3b UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] bowenli86 edited a comment on issue #11175: [FLINK-16197][hive] Failed to query partitioned table when partition …

Posted by GitBox <gi...@apache.org>.
bowenli86 edited a comment on issue #11175: [FLINK-16197][hive] Failed to query partitioned table when partition …
URL: https://github.com/apache/flink/pull/11175#issuecomment-591232361
 
 
   I have a slightly different opinion on this. Though it might mitigate the problem for users, we are indeed trying to hack the way around invalid inputs passed to our APIs. E.g. flink's file source will fail if the target is missing, rather than mitigate for users.
   
   Maybe @KurtYoung or @JingsongLi can give some opinions and help to merge if they think this is a proper fix?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] lirui-apache commented on issue #11175: [FLINK-16197][hive] Failed to query partitioned table when partition …

Posted by GitBox <gi...@apache.org>.
lirui-apache commented on issue #11175: [FLINK-16197][hive] Failed to query partitioned table when partition …
URL: https://github.com/apache/flink/pull/11175#issuecomment-591420120
 
 
   @KurtYoung You're right that Hive treats it as an empty partition. But Hive doesn't fix it. The empty folder/file is created in some scratch dir, not under the table location. I guess it's just meant to give the input format something to work on.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] JingsongLi commented on issue #11175: [FLINK-16197][hive] Failed to query partitioned table when partition …

Posted by GitBox <gi...@apache.org>.
JingsongLi commented on issue #11175: [FLINK-16197][hive] Failed to query partitioned table when partition …
URL: https://github.com/apache/flink/pull/11175#issuecomment-602417961
 
 
   Any progress? @lirui-apache Can you update the PR? If there is no objection, I think we can merge this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] bowenli86 commented on issue #11175: [FLINK-16197][hive] Failed to query partitioned table when partition …

Posted by GitBox <gi...@apache.org>.
bowenli86 commented on issue #11175: [FLINK-16197][hive] Failed to query partitioned table when partition …
URL: https://github.com/apache/flink/pull/11175#issuecomment-591232361
 
 
   I have a slightly different opinion on this. Though it might mitigate the problem for users, we are indeed trying to hack the way around invalid inputs passed to our APIs. E.g. flink's file source will fail if the target is missing, rather than mitigate for users.
   
   I'm generally neutral on this PR. Maybe @KurtYoung or @JingsongLi can give some opinions and help to merge if they think this is a proper fix?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] lirui-apache commented on issue #11175: [FLINK-16197][hive] Failed to query partitioned table when partition …

Posted by GitBox <gi...@apache.org>.
lirui-apache commented on issue #11175: [FLINK-16197][hive] Failed to query partitioned table when partition …
URL: https://github.com/apache/flink/pull/11175#issuecomment-589655266
 
 
   @JingsongLi @bowenli86 Let me know if you think the change makes sense. Thanks,

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11175: [FLINK-16197][hive] Failed to query partitioned table when partition …

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11175: [FLINK-16197][hive] Failed to query partitioned table when partition …
URL: https://github.com/apache/flink/pull/11175#issuecomment-589653458
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 53fda3bf9cc936fee8c1925c76730df8d9ee6381 (Fri Feb 21 13:30:19 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
    * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-16197).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] JingsongLi commented on issue #11175: [FLINK-16197][hive] Failed to query partitioned table when partition …

Posted by GitBox <gi...@apache.org>.
JingsongLi commented on issue #11175: [FLINK-16197][hive] Failed to query partitioned table when partition …
URL: https://github.com/apache/flink/pull/11175#issuecomment-589659448
 
 
   Hi @lirui-apache , can you describe the issue details in pull request too? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11175: [FLINK-16197][hive] Failed to query partitioned table when partition …

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11175: [FLINK-16197][hive] Failed to query partitioned table when partition …
URL: https://github.com/apache/flink/pull/11175#issuecomment-589653458
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 53fda3bf9cc936fee8c1925c76730df8d9ee6381 (Fri Feb 28 21:48:26 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
    * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-16197).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] lirui-apache commented on issue #11175: [FLINK-16197][hive] Failed to query partitioned table when partition …

Posted by GitBox <gi...@apache.org>.
lirui-apache commented on issue #11175: [FLINK-16197][hive] Failed to query partitioned table when partition …
URL: https://github.com/apache/flink/pull/11175#issuecomment-591326794
 
 
   I understand Flink may handle such issues differently for its own file sources.
   But for Hive connector, metadata is retrieved from (and managed by) an external HMS. If Hive, the owner of the metadata, is aware of such discrepancy and decides it should be tolerated, I don't see a good reason why we should be more strict on that matter.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] JingsongLi commented on issue #11175: [FLINK-16197][hive] Failed to query partitioned table when partition …

Posted by GitBox <gi...@apache.org>.
JingsongLi commented on issue #11175: [FLINK-16197][hive] Failed to query partitioned table when partition …
URL: https://github.com/apache/flink/pull/11175#issuecomment-589665975
 
 
   Is this a reasonable issue?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] bowenli86 commented on issue #11175: [FLINK-16197][hive] Failed to query partitioned table when partition …

Posted by GitBox <gi...@apache.org>.
bowenli86 commented on issue #11175: [FLINK-16197][hive] Failed to query partitioned table when partition …
URL: https://github.com/apache/flink/pull/11175#issuecomment-589759434
 
 
   feels like Hive's approach is more graceful, though not perfect, as it still respect HMS as the source of truth.
   
   This fix would make Flink disrespect any discrepancy between metadata in HMS and actual storage. That seems to minimize migration cost, but I'm not sure that's a good longterm strategy

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11175: [FLINK-16197][hive] Failed to query partitioned table when partition …

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11175: [FLINK-16197][hive] Failed to query partitioned table when partition …
URL: https://github.com/apache/flink/pull/11175#issuecomment-589671100
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "53fda3bf9cc936fee8c1925c76730df8d9ee6381",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/150017255",
       "triggerID" : "53fda3bf9cc936fee8c1925c76730df8d9ee6381",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8aedd02e74d1a07be08e367b693ad82d69bfde3b",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/154595008",
       "triggerID" : "8aedd02e74d1a07be08e367b693ad82d69bfde3b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8aedd02e74d1a07be08e367b693ad82d69bfde3b",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6536",
       "triggerID" : "8aedd02e74d1a07be08e367b693ad82d69bfde3b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8aedd02e74d1a07be08e367b693ad82d69bfde3b Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/154595008) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6536) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] lirui-apache commented on issue #11175: [FLINK-16197][hive] Failed to query partitioned table when partition …

Posted by GitBox <gi...@apache.org>.
lirui-apache commented on issue #11175: [FLINK-16197][hive] Failed to query partitioned table when partition …
URL: https://github.com/apache/flink/pull/11175#issuecomment-590155149
 
 
   Hi @bowenli86 , could you elaborate why it's not a good longterm strategy? IMHO, it should be up to each connector to decide how to handle discrepancy between metadata and storage. Because such discrepancies might be treated differently in the external systems. One system may consider the discrepancy as a fatal error, and another system may expect the discrepancy to happen from time to time and choose to tolerate it. Therefore I think each connector should follow the behavior of the external system it connects to.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] lirui-apache commented on issue #11175: [FLINK-16197][hive] Failed to query partitioned table when partition …

Posted by GitBox <gi...@apache.org>.
lirui-apache commented on issue #11175: [FLINK-16197][hive] Failed to query partitioned table when partition …
URL: https://github.com/apache/flink/pull/11175#issuecomment-590716987
 
 
   @bowenli86 I agree we should educate users to avoid the discrepancy in the first place. Hive provides the `MSCK` tool so that users can sync partition info between metadata and storage by running this command.
   But I think it's one thing to tell users the best practice, and another to be robust when something is off. Users migrating to Flink would find it more friendly if they can have the same level of robustness.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11175: [FLINK-16197][hive] Failed to query partitioned table when partition …

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11175: [FLINK-16197][hive] Failed to query partitioned table when partition …
URL: https://github.com/apache/flink/pull/11175#issuecomment-589671100
 
 
   <!--
   Meta data
   Hash:53fda3bf9cc936fee8c1925c76730df8d9ee6381 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/150017255 TriggerType:PUSH TriggerID:53fda3bf9cc936fee8c1925c76730df8d9ee6381
   -->
   ## CI report:
   
   * 53fda3bf9cc936fee8c1925c76730df8d9ee6381 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150017255) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] KurtYoung commented on issue #11175: [FLINK-16197][hive] Failed to query partitioned table when partition …

Posted by GitBox <gi...@apache.org>.
KurtYoung commented on issue #11175: [FLINK-16197][hive] Failed to query partitioned table when partition …
URL: https://github.com/apache/flink/pull/11175#issuecomment-591749447
 
 
   @lirui-apache Then this approach sounds good to me. @bowenli86 do you have any further concerns?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] KurtYoung commented on issue #11175: [FLINK-16197][hive] Failed to query partitioned table when partition …

Posted by GitBox <gi...@apache.org>.
KurtYoung commented on issue #11175: [FLINK-16197][hive] Failed to query partitioned table when partition …
URL: https://github.com/apache/flink/pull/11175#issuecomment-591392522
 
 
   If i understand this correctly, ignore the missing partition doesn't indicate flink disrespect HMS as source of truth. I think it's important to figure out what does it mean for a partition without any directory or files. It looks to me hive treat it as an empty partition, because it not only ignore the error but also helped to fix this partition by creating an empty directory (correct me if i'm wrong). If this is true, then just ignoring it in Flink sounds reasonable to me. Ignoring this inconsistent means flink also treat it as an empty partition, but we don't have the ability to fix it. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zjffdu commented on issue #11175: [FLINK-16197][hive] Failed to query partitioned table when partition …

Posted by GitBox <gi...@apache.org>.
zjffdu commented on issue #11175: [FLINK-16197][hive] Failed to query partitioned table when partition …
URL: https://github.com/apache/flink/pull/11175#issuecomment-589704755
 
 
   @JingsongLi This is a real use case that one user hit when using Flink on Zeppelin. This happens when the data on hdfs is inconsistent with hive metadata.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11175: [FLINK-16197][hive] Failed to query partitioned table when partition …

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11175: [FLINK-16197][hive] Failed to query partitioned table when partition …
URL: https://github.com/apache/flink/pull/11175#issuecomment-589671100
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "53fda3bf9cc936fee8c1925c76730df8d9ee6381",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/150017255",
       "triggerID" : "53fda3bf9cc936fee8c1925c76730df8d9ee6381",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 53fda3bf9cc936fee8c1925c76730df8d9ee6381 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150017255) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] lirui-apache commented on issue #11175: [FLINK-16197][hive] Failed to query partitioned table when partition …

Posted by GitBox <gi...@apache.org>.
lirui-apache commented on issue #11175: [FLINK-16197][hive] Failed to query partitioned table when partition …
URL: https://github.com/apache/flink/pull/11175#issuecomment-589686279
 
 
   > Is this a reasonable issue?
   
   The issue was reported by a user trying to access Hive tables from Flink. Since Hive can handle this situation, I think a migrating user might expect Flink to do the same.
   
   BTW, Hive handles the issue a little differently. Instead of ignoring the missing folder, it creates empty files/folders for such partitions, under a scratch dir in HDFS. Since we don't have such a scratch dir on Flink side (therefore unable to do the clean-up), I think we can't follow Hive's solution.
   
   Also note that this is not trying to deal with concurrency issues. Concurrently accessing the table (e.g. delete the files while another job reads it) can still fail.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] bowenli86 commented on issue #11175: [FLINK-16197][hive] Failed to query partitioned table when partition …

Posted by GitBox <gi...@apache.org>.
bowenli86 commented on issue #11175: [FLINK-16197][hive] Failed to query partitioned table when partition …
URL: https://github.com/apache/flink/pull/11175#issuecomment-590437304
 
 
   there shouldn't be discrepancy in HMS and hdfs in the first place, users need to figure out what led to such broken state and fix it. In this case, shall the right approach be that user just drop the partition whose dir has been removed already?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11175: [FLINK-16197][hive] Failed to query partitioned table when partition …

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11175: [FLINK-16197][hive] Failed to query partitioned table when partition …
URL: https://github.com/apache/flink/pull/11175#issuecomment-589671100
 
 
   <!--
   Meta data
   Hash:53fda3bf9cc936fee8c1925c76730df8d9ee6381 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/150017255 TriggerType:PUSH TriggerID:53fda3bf9cc936fee8c1925c76730df8d9ee6381
   -->
   ## CI report:
   
   * 53fda3bf9cc936fee8c1925c76730df8d9ee6381 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/150017255) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11175: [FLINK-16197][hive] Failed to query partitioned table when partition …

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11175: [FLINK-16197][hive] Failed to query partitioned table when partition …
URL: https://github.com/apache/flink/pull/11175#issuecomment-589671100
 
 
   <!--
   Meta data
   Hash:53fda3bf9cc936fee8c1925c76730df8d9ee6381 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:53fda3bf9cc936fee8c1925c76730df8d9ee6381
   -->
   ## CI report:
   
   * 53fda3bf9cc936fee8c1925c76730df8d9ee6381 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11175: [FLINK-16197][hive] Failed to query partitioned table when partition …

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11175: [FLINK-16197][hive] Failed to query partitioned table when partition …
URL: https://github.com/apache/flink/pull/11175#issuecomment-589671100
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "53fda3bf9cc936fee8c1925c76730df8d9ee6381",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/150017255",
       "triggerID" : "53fda3bf9cc936fee8c1925c76730df8d9ee6381",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8aedd02e74d1a07be08e367b693ad82d69bfde3b",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/154595008",
       "triggerID" : "8aedd02e74d1a07be08e367b693ad82d69bfde3b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8aedd02e74d1a07be08e367b693ad82d69bfde3b",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6536",
       "triggerID" : "8aedd02e74d1a07be08e367b693ad82d69bfde3b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 53fda3bf9cc936fee8c1925c76730df8d9ee6381 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150017255) 
   * 8aedd02e74d1a07be08e367b693ad82d69bfde3b Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/154595008) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6536) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] lirui-apache commented on issue #11175: [FLINK-16197][hive] Failed to query partitioned table when partition …

Posted by GitBox <gi...@apache.org>.
lirui-apache commented on issue #11175: [FLINK-16197][hive] Failed to query partitioned table when partition …
URL: https://github.com/apache/flink/pull/11175#issuecomment-589687487
 
 
   Also cc @zjffdu 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services