You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/25 13:25:48 UTC

[GitHub] [airflow] jameswynn opened a new issue #10549: option to disable "lots of circles" in error page

jameswynn opened a new issue #10549:
URL: https://github.com/apache/airflow/issues/10549


   **Description**
   
   The "lots of circles" error page is very rough via Remote Desktop connections. In the current global pandemic many people are working remotely via already constrained connections. Needless redraws caused by the highly animated circles can cause frustrating slowdowns and sometimes lost connections.
   
   **Use case / motivation**
   
   It should be trivially simple to disable the animated portion of the error page and instead use a standard error page. Ideally this would be something easily achievable via configuration options and exposed in the Helm chart.
   
   **Related Issues**
   
   N/A
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] boring-cyborg[bot] commented on issue #10549: option to disable "lots of circles" in error page

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #10549:
URL: https://github.com/apache/airflow/issues/10549#issuecomment-680023402


   Thanks for opening your first issue here! Be sure to follow the issue template!
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on issue #10549: option to disable "lots of circles" in error page

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #10549:
URL: https://github.com/apache/airflow/issues/10549#issuecomment-680032464


   That's a vaild point I must say.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] baryluk commented on issue #10549: option to disable "lots of circles" in error page

Posted by GitBox <gi...@apache.org>.
baryluk commented on issue #10549:
URL: https://github.com/apache/airflow/issues/10549#issuecomment-900207667


   Thank you again @bbovenzi . Awesome.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] lewis-anderson53 commented on issue #10549: option to disable "lots of circles" in error page

Posted by GitBox <gi...@apache.org>.
lewis-anderson53 commented on issue #10549:
URL: https://github.com/apache/airflow/issues/10549#issuecomment-798969507


   I'm looking to make my first contribution to the project, I've just been looking at how this is rendered and I've got a pretty good idea how we could implement this.
   
   If the `airflow.cfg` file contains something like `circles_dynamic`, we could fetch the value when rendering the circles HTML template [here](https://github.com/apache/airflow/blob/4cde47b339d5ab5e4ebccfb22962ccbfc4c5457e/airflow/www/views.py#L368) where the default fallback value is `True`, meaning this SVG will by default behave as it currently does.
   
   In the [circles.html](https://github.com/apache/airflow/blob/4cde47b339d5ab5e4ebccfb22962ccbfc4c5457e/airflow/www/templates/airflow/circles.html#L37) template, we could use Jinja to determine whether or not to load the default `circles.js` or some new file, called `circles_static.js`, which simply draws the circles once, without redrawing them constantly, which I understand to be the root cause of this issue right @jameswynn ?
   
   Open to suggestions, this is just the first method that came to my mind!
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] baryluk edited a comment on issue #10549: option to disable "lots of circles" in error page

Posted by GitBox <gi...@apache.org>.
baryluk edited a comment on issue #10549:
URL: https://github.com/apache/airflow/issues/10549#issuecomment-894791490


   I also have similar issue as OP. I use VNC a lot, and it causes sever frame rate drop, as well causes serious CPU usage increase on both VNC server and client (to the point that the small client PC spins CPU fan to the max). I wish it was just gone. No need for it to be configurable.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] jpmarques66 commented on issue #10549: option to disable "lots of circles" in error page

Posted by GitBox <gi...@apache.org>.
jpmarques66 commented on issue #10549:
URL: https://github.com/apache/airflow/issues/10549#issuecomment-687226798


   @potiuk Would love to try to solve this one. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kaxil closed issue #10549: option to disable "lots of circles" in error page

Posted by GitBox <gi...@apache.org>.
kaxil closed issue #10549:
URL: https://github.com/apache/airflow/issues/10549


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] mik-laj commented on issue #10549: option to disable "lots of circles" in error page

Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #10549:
URL: https://github.com/apache/airflow/issues/10549#issuecomment-687402016


   @jpmarques66  I assigned you to this ticket 🐈


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] mik-laj commented on issue #10549: option to disable "lots of circles" in error page

Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #10549:
URL: https://github.com/apache/airflow/issues/10549#issuecomment-749606198


   @jpmarques66 I can see that you are not active on this ticket, so I unassigned you from this ticket.  Now another contributor can start working on it. If you want to continue working, let me know and I will assign you again.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on issue #10549: option to disable "lots of circles" in error page

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #10549:
URL: https://github.com/apache/airflow/issues/10549#issuecomment-680033280


   If any would like to pick it up, I am all for making this page static.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] baryluk edited a comment on issue #10549: option to disable "lots of circles" in error page

Posted by GitBox <gi...@apache.org>.
baryluk edited a comment on issue #10549:
URL: https://github.com/apache/airflow/issues/10549#issuecomment-894791490


   I also have similar issue as OP. I use VNC a lot, and it causes sever frame rate drop, as well causes serious CPU usage increase on both VNC server and client (to the point that the small client PC spins CPU fan to the max). I wish it was just gone. No need for it to be configurable. Airflow already has too many configuration options IMHO.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] baryluk commented on issue #10549: option to disable "lots of circles" in error page

Posted by GitBox <gi...@apache.org>.
baryluk commented on issue #10549:
URL: https://github.com/apache/airflow/issues/10549#issuecomment-894791490


   I also have similar issue as OP. I use VNC a lot, and it causes sever frame rate drop, as well causes serious CPU usage increase on both VNC server and client (to the point that the small client PC spins CPU fan to the max). I wish it was just gone. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] bbovenzi commented on issue #10549: option to disable "lots of circles" in error page

Posted by GitBox <gi...@apache.org>.
bbovenzi commented on issue #10549:
URL: https://github.com/apache/airflow/issues/10549#issuecomment-894346087


   Alternatively, instead of adding _another_ config item. We could just get rid of the lots of circles. It doesn't really provide anything useful, as far as I'm aware.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org