You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mp...@apache.org> on 2017/04/24 23:18:40 UTC
Review Request 58687: Made the activation of a client in `Sorter::add`
explicit.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58687/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Neil Conway.
Bugs: MESOS-7323
https://issues.apache.org/jira/browse/MESOS-7323
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/master/allocator/mesos/hierarchical.cpp 051f749dd5921a322ca930a042c31814616d38f9
src/master/allocator/sorter/drf/sorter.cpp ed54680cecb637931fc344fbcf8fd3b14cc24295
src/tests/sorter_tests.cpp 43bd85798aef0c89751b725ebf35308a5e9e997a
Diff: https://reviews.apache.org/r/58687/diff/1/
Testing
-------
`make check`
Thanks,
Michael Park
Re: Review Request 58687: Made the activation of a client in
`Sorter::add` explicit.
Posted by Michael Park <mp...@apache.org>.
> On April 25, 2017, 4:49 p.m., Benjamin Mahler wrote:
> > src/master/allocator/sorter/drf/sorter.cpp
> > Lines 151-155 (original)
> > <https://reviews.apache.org/r/58687/diff/1/?file=1698676#file1698676line151>
> >
> > Do we still want the CHECKs or some variant of the comment?
Kept the `CHECK`s here.
> On April 25, 2017, 4:49 p.m., Benjamin Mahler wrote:
> > src/master/allocator/sorter/drf/sorter.cpp
> > Lines 151-156 (original)
> > <https://reviews.apache.org/r/58687/diff/1/?file=1698676#file1698676line151>
> >
> > Could we document these new semantics in the sorter interface?
Added a comment on the sorter interface.
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58687/#review173005
-----------------------------------------------------------
On April 24, 2017, 4:18 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58687/
> -----------------------------------------------------------
>
> (Updated April 24, 2017, 4:18 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Neil Conway.
>
>
> Bugs: MESOS-7323
> https://issues.apache.org/jira/browse/MESOS-7323
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp 051f749dd5921a322ca930a042c31814616d38f9
> src/master/allocator/sorter/drf/sorter.cpp ed54680cecb637931fc344fbcf8fd3b14cc24295
> src/tests/sorter_tests.cpp 43bd85798aef0c89751b725ebf35308a5e9e997a
>
>
> Diff: https://reviews.apache.org/r/58687/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 58687: Made the activation of a client in
`Sorter::add` explicit.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58687/#review173005
-----------------------------------------------------------
Fix it, then Ship it!
src/master/allocator/sorter/drf/sorter.cpp
Lines 151-155 (original)
<https://reviews.apache.org/r/58687/#comment246067>
Do we still want the CHECKs or some variant of the comment?
src/master/allocator/sorter/drf/sorter.cpp
Lines 151-156 (original)
<https://reviews.apache.org/r/58687/#comment246068>
Could we document these new semantics in the sorter interface?
- Benjamin Mahler
On April 24, 2017, 11:18 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58687/
> -----------------------------------------------------------
>
> (Updated April 24, 2017, 11:18 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Neil Conway.
>
>
> Bugs: MESOS-7323
> https://issues.apache.org/jira/browse/MESOS-7323
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp 051f749dd5921a322ca930a042c31814616d38f9
> src/master/allocator/sorter/drf/sorter.cpp ed54680cecb637931fc344fbcf8fd3b14cc24295
> src/tests/sorter_tests.cpp 43bd85798aef0c89751b725ebf35308a5e9e997a
>
>
> Diff: https://reviews.apache.org/r/58687/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 58687: Made the activation of a client in
`Sorter::add` explicit.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58687/
-----------------------------------------------------------
(Updated April 26, 2017, 3:47 p.m.)
Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Neil Conway.
Changes
-------
Addressed bmahler's comments.
Bugs: MESOS-7323
https://issues.apache.org/jira/browse/MESOS-7323
Repository: mesos
Description (updated)
-------
Made the activation of a client in `Sorter::add` explicit.
Diffs (updated)
-----
src/master/allocator/mesos/hierarchical.cpp 984a0a4e2671ee7bb2a3515849342f49f2c4e3aa
src/master/allocator/sorter/drf/sorter.cpp 73b8e8ccdee9d1a88bf6a1726b8ff67008ef339f
src/master/allocator/sorter/sorter.hpp 0c9f17255e9ed9dea56322bf7633505faf2a1a33
src/tests/sorter_tests.cpp 3d183bf3602ed632cbe8242c90a499d2e7848499
Diff: https://reviews.apache.org/r/58687/diff/2/
Changes: https://reviews.apache.org/r/58687/diff/1-2/
Testing
-------
`make check`
Thanks,
Michael Park