[GitHub] [james-project] Arsnael commented on a diff in pull request #1186: [REFACTORING] Cleanup OidcJwtTokenVerifier

[GitBox <gi...@apache.org>]

Arsnael commented on code in PR #1186:
URL: https://github.com/apache/james-project/pull/1186#discussion_r967962905


##########
server/protocols/jwt/src/main/java/org/apache/james/jwt/OidcJwtTokenVerifier.java:
##########
@@ -40,20 +40,21 @@ public class OidcJwtTokenVerifier {
     public static final IntrospectionClient INTROSPECTION_CLIENT = new DefaultIntrospectionClient();
 
     public static Optional<String> verifySignatureAndExtractClaim(String jwtToken, URL jwksURL, String claimName) {
-        PublicKeyProvider jwksPublicKeyProvider = getClaimWithoutSignatureVerification(jwtToken, "kid", String.class)
+        Optional<String> unverifiedClain = getClaimWithoutSignatureVerification(jwtToken, "kid");

Review Comment:
   ```suggestion
           Optional<String> unverifiedClaim = getClaimWithoutSignatureVerification(jwtToken, "kid");
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org