You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by danobi <gi...@git.apache.org> on 2015/04/13 07:07:32 UTC
[GitHub] trafficserver pull request: TS-1774 Moved gethrtime functions into...
GitHub user danobi opened a pull request:
https://github.com/apache/trafficserver/pull/185
TS-1774 Moved gethrtime functions into Thread class
Moved ink_get_hrtime() and ink_get_based_hrtime() into the Thread.cc class as opposed to them being an extern function in P_Thread.h. Also made them static functions. Fixed the rest of the code base to refer to new functions.
Running 'make test' seemed to work.
Please let me know if anything is wrong, I'd be happy to correct any errors. Also please let me know if this change actually makes sense, because with my limited knowledge this was the only solution I could come up with.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/danobi/trafficserver master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/185.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #185
----
commit 817613a973a28e6aa281098881c56d5fe160257e
Author: Daniel Xu <da...@gmail.com>
Date: 2015-04-13T04:39:51Z
TS-1774 Move gethrtime functions into Thread class
Tested: Debian Jessie Testing
Author: Daniel Xu <dl...@illinois.edu>
Moved ink_get_hrtime() and ink_get_based_hrtime()
into the Thread.cc class and made them static
functions as well to support object free calling.
Also changed all references in code base to these
two functions to refer to Thread::ink_get_...
instead.
commit 4f08f9f760b211f51d64079aa433ea741a5128a7
Author: Daniel Xu <da...@gmail.com>
Date: 2015-04-13T04:59:35Z
TS-1774 Move gethrtime functions into Thread class
Tested: Debian Jessie Testing
Author: Daniel Xu <dl...@illinois.edu>
Moved ink_get_hrtime() and ink_get_based_hrtime()
into the Thread.cc class and made them static
functions as well to support object free calling.
Also changed all references in code base to these
two functions to refer to Thread::ink_get_...
instead. Also fixed my own tab spacing issue.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-1774 Moved gethrtime functions into...
Posted by bryancall <gi...@git.apache.org>.
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/185#issuecomment-112872433
https://issues.apache.org/jira/browse/TS-1774
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-1774 Moved gethrtime functions into...
Posted by SolidWallOfCode <gi...@git.apache.org>.
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/185#issuecomment-110553260
I think the most likely cause is the code base was reformatted and you're being hit by that. You need to reformat you code base to match before trying to rebase. You can find them here - https://bintray.com/apache/trafficserver/clang-format-tools/view
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-1774 Moved gethrtime functions into...
Posted by danobi <gi...@git.apache.org>.
Github user danobi commented on the pull request:
https://github.com/apache/trafficserver/pull/185#issuecomment-110504046
Fixed. However, I am unsure how to handle all the merge conflicts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-1774 Moved gethrtime functions into...
Posted by SolidWallOfCode <gi...@git.apache.org>.
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/185#issuecomment-97224460
Sorry for the delay, I got distracted. I think it's OK except the method name should be just "get_hrtime()", there's no need for the "ink_" prefix if it's a method.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-1774 Moved gethrtime functions into...
Posted by danobi <gi...@git.apache.org>.
Github user danobi commented on the pull request:
https://github.com/apache/trafficserver/pull/185#issuecomment-111233333
Fixed the merge conflicts. Also updated any other uses of ink_get_hrtime() / ink_get_based_hrtime() that occurred during the life of this PR.
There's quite a few commits now, let me know if this should all be squashed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-1774 Moved gethrtime functions into...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/185
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-1774 Moved gethrtime functions into...
Posted by SolidWallOfCode <gi...@git.apache.org>.
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/185#issuecomment-92403352
Isolation and modularity? It seems better to discuss this on the original bug - it's not really a problem with the pull request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-1774 Moved gethrtime functions into...
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/185#issuecomment-92401379
Doe we even need the new Thread APIs? Can we just use Thread::cur_time directly?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---