You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/08/09 18:02:48 UTC

[GitHub] [arrow-datafusion] Dandandan commented on pull request #808: (WIP) Rework GroupByHash to for faster performance and support grouping by nulls

Dandandan commented on pull request #808:
URL: https://github.com/apache/arrow-datafusion/pull/808#issuecomment-895425959


   On the db-benchmark aggregation queries:
   
   PR:
   ```
   q1 took 33 ms
   q2 took 377 ms
   q3 took 986 ms
   q4 took 47 ms
   q5 took 973 ms
   q7 took 932 ms
   q10 took 4040 ms
   ```
   
   Master:
   ```
   q1 took 37 ms
   q2 took 325 ms
   q3 took 1431 ms
   q4 took 56 ms
   q5 took 1287 ms
   q7 took 1304 ms
   q10 took 9380 ms
   ```
   
   It looks like it's a small perf hit on q2,  but I think the other 4 queries do greatly compensate for this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org