You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/03/30 00:49:47 UTC
[GitHub] [incubator-nuttx] walbon opened a new pull request #3239: board/arm/lpc17xx_40xx/mbed: Add userleds driver support
walbon opened a new pull request #3239:
URL: https://github.com/apache/incubator-nuttx/pull/3239
lpc17_40_userleds.c: Adds the support of Userleds driver which
provides a device to manipulate the 4 leds of the board through the
/dev/userleds.
lpc17_40_leds.c: Removes not used definitions, eg. MBED_LED3_ON.
Board LED Status support(CONFIG_ARCH_LED=y) and Device Drivers/Led
Support(CONFIG_ARCH_USERLED=y) can not be enable together.
Signed-off-by: Gustavo L F Walbon <gw...@linux.ibm.com>
## Summary
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3239: board/arm/lpc17xx_40xx/mbed: Add userleds driver support
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #3239:
URL: https://github.com/apache/incubator-nuttx/pull/3239#issuecomment-809948114
@walbon could you fix the following warning:
```
nuttx/boards/arm/lpc17xx_40xx/mbed/src/lpc17_40_appinit.c:37:1: error: Too many blank lines
nuttx/boards/arm/lpc17xx_40xx/mbed/src/lpc17_40_userleds.c:213:1: error: Blank line precedes right brace at line
nuttx/boards/arm/lpc17xx_40xx/mbed/src/mbed.h:51:1: error: Too many blank lines
```
you can check locally by ./tools/checkpatch.sh -g HEAD~...HEAD
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #3239: board/arm/lpc17xx_40xx/mbed: Add userleds driver support
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #3239:
URL: https://github.com/apache/incubator-nuttx/pull/3239
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] walbon commented on pull request #3239: board/arm/lpc17xx_40xx/mbed: Add userleds driver support
Posted by GitBox <gi...@apache.org>.
walbon commented on pull request #3239:
URL: https://github.com/apache/incubator-nuttx/pull/3239#issuecomment-810095325
> @walbon could you fix the following warning:
>
> ```
> nuttx/boards/arm/lpc17xx_40xx/mbed/src/lpc17_40_appinit.c:37:1: error: Too many blank lines
> nuttx/boards/arm/lpc17xx_40xx/mbed/src/lpc17_40_userleds.c:213:1: error: Blank line precedes right brace at line
> nuttx/boards/arm/lpc17xx_40xx/mbed/src/mbed.h:51:1: error: Too many blank lines
> ```
>
> you can check locally by ./tools/checkpatch.sh -g HEAD~...HEAD
Sure @xiaoxiang781216
thank you for the hint.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org