You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/03 21:13:43 UTC
[GitHub] [beam] lukecwik opened a new pull request, #18905: [Fixes #18679] Ensure that usage of metrics on a template job reports an error
lukecwik opened a new pull request, #18905:
URL: https://github.com/apache/beam/pull/18905
Note that the usage of DataflowMetrics with a template job was throwing an NPE due to the direct access of the jobId parameter.
I also ensured that getting transform step names was accessed via a method instead of reaching into the object directly.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Add a link to the appropriate issue in your description, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pranavbhandari24 commented on pull request #18905: [Fixes #18679] Ensure that usage of metrics on a template job reports an error
Posted by GitBox <gi...@apache.org>.
pranavbhandari24 commented on PR #18905:
URL: https://github.com/apache/beam/pull/18905#issuecomment-1147434560
LGTM Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik merged pull request #18905: [Fixes #18679] Ensure that usage of metrics on a template job reports an error
Posted by GitBox <gi...@apache.org>.
lukecwik merged PR #18905:
URL: https://github.com/apache/beam/pull/18905
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik commented on pull request #18905: [Fixes #18679] Ensure that usage of metrics on a template job reports an error
Posted by GitBox <gi...@apache.org>.
lukecwik commented on PR #18905:
URL: https://github.com/apache/beam/pull/18905#issuecomment-1146369431
R: @oleg-semenov @pranavbhandari24
CC: @an2x
This came from a user getting stuck since they were launching a flex template that was creating a classic template which tried to access metrics for a non-existent job and it manifested as an NPE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org