[jira] Commented: (HBASE-417) Factor TableOperation and subclasses into separate files from HMaster

["stack (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12567731#action_12567731 ] 

stack commented on HBASE-417:
-----------------------------

Copyright notices should be 2008, not 2007.

In DeleteColumns, not a blocker, but seems odd passing HMaster inner classes out to these TableOperation classes; should MetaTable be moved out of HMaster too?

These could be made final?

{code}
+  private HColumnDescriptor descriptor;
+  private Text columnName;
{code}

... etc. for all other TableOperation classes.

Otherwise, patch is a big improvement.

> Factor TableOperation and subclasses into separate files from HMaster
> ---------------------------------------------------------------------
>
>                 Key: HBASE-417
>                 URL: https://issues.apache.org/jira/browse/HBASE-417
>             Project: Hadoop HBase
>          Issue Type: Sub-task
>            Reporter: Bryan Duxbury
>            Assignee: Bryan Duxbury
>            Priority: Minor
>         Attachments: 417-v2.patch, 417.patch
>
>
> In HMaster, a lot of the things you do like table creation, deletion, etc, are abstracted into TableOperation subclasses. This is handy and elegant, but inflates the size of the HMaster file by a few hundred lines at least. 
> I think we should move the TableOperation and subclasses out into their own files as opposed to being internal classes. This would make it easier to find them and reduce the size of HMaster. The new classes should be package-private.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.