You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2021/02/23 09:26:18 UTC
[GitHub] [zookeeper] ztzg opened a new pull request #1611: ZOOKEEPER-4219: Quota checks break setData in multi transactions
ztzg opened a new pull request #1611:
URL: https://github.com/apache/zookeeper/pull/1611
Without this patch, a multi() transaction such as the one implemented
in ZooKeeperQuotaTest.testMultiCreateThenSetDataShouldWork fails with
MarshallingError when 'enforceQuota' is enabled.
This happens whenever the node has an associated quota, whether it was
exceeded or not.
This is due to the server encountering null while trying to access a
database node by path--whereas that node only exists as a ChangeRecord
in the server's 'outstandingChanges' list:
java.lang.NullPointerException
at org.apache.zookeeper.server.ZooKeeperServer.checkQuota(ZooKeeperServer.java:2048)
at org.apache.zookeeper.server.PrepRequestProcessor.pRequest2Txn(PrepRequestProcessor.java:397)
The patch adds an additional 'lastData' parameter to the quota
checking function, and passes the data from the ChangeRecord during
'setData' operations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] nkalmar edited a comment on pull request #1611: ZOOKEEPER-4219: Quota checks break setData in multi transactions
Posted by GitBox <gi...@apache.org>.
nkalmar edited a comment on pull request #1611:
URL: https://github.com/apache/zookeeper/pull/1611#issuecomment-787726420
Thanks @ztzg , merged to master and 3.7. It will need to be cherry-picked to 3.7.0 release branch. Ping me Damien if you want me to cherry-pick it to 3.7.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] ztzg commented on pull request #1611: ZOOKEEPER-4219: Quota checks break setData in multi transactions
Posted by GitBox <gi...@apache.org>.
ztzg commented on pull request #1611:
URL: https://github.com/apache/zookeeper/pull/1611#issuecomment-792043565
> > Thanks @ztzg , merged to master and 3.7.
>
> Great; thank you!
>
> > It will need to be cherry-picked to 3.7.0 release branch. Ping me Damien if you want me to cherry-pick it to 3.7.0.
>
> Don't worry about it. Cherry-picking has not been 100% consistent on these branches; I will have to sort it out as I prepare the next RC (in a few days) anyway—and will try and keep the sequences as "parallel" as possible as I do so.
Now also in `branch-3.7.0`. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] maoling commented on pull request #1611: ZOOKEEPER-4219: Quota checks break setData in multi transactions
Posted by GitBox <gi...@apache.org>.
maoling commented on pull request #1611:
URL: https://github.com/apache/zookeeper/pull/1611#issuecomment-785867098
I will take a look at this weekend(02-27 ~02-28) if you can wait for that time:)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] ztzg commented on pull request #1611: ZOOKEEPER-4219: Quota checks break setData in multi transactions
Posted by GitBox <gi...@apache.org>.
ztzg commented on pull request #1611:
URL: https://github.com/apache/zookeeper/pull/1611#issuecomment-784107976
> please include this patch into next 3.7.0 rc
Definitely the plan :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] ztzg commented on pull request #1611: ZOOKEEPER-4219: Quota checks break setData in multi transactions
Posted by GitBox <gi...@apache.org>.
ztzg commented on pull request #1611:
URL: https://github.com/apache/zookeeper/pull/1611#issuecomment-785816649
> I would like to see some more reviewer on this patch.
Me too, hence the noise :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] nkalmar commented on pull request #1611: ZOOKEEPER-4219: Quota checks break setData in multi transactions
Posted by GitBox <gi...@apache.org>.
nkalmar commented on pull request #1611:
URL: https://github.com/apache/zookeeper/pull/1611#issuecomment-787726420
Thanks @ztzg , merged to master. It will need to be cherry-picked to 3.7.0 release branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] ztzg commented on pull request #1611: ZOOKEEPER-4219: Quota checks break setData in multi transactions
Posted by GitBox <gi...@apache.org>.
ztzg commented on pull request #1611:
URL: https://github.com/apache/zookeeper/pull/1611#issuecomment-784032204
Cc: @hanm. (Cannot add you as a reviewer for some reason.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] eolivelli commented on pull request #1611: ZOOKEEPER-4219: Quota checks break setData in multi transactions
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #1611:
URL: https://github.com/apache/zookeeper/pull/1611#issuecomment-785796241
I would like to see some more reviewer on this patch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] maoling commented on pull request #1611: ZOOKEEPER-4219: Quota checks break setData in multi transactions
Posted by GitBox <gi...@apache.org>.
maoling commented on pull request #1611:
URL: https://github.com/apache/zookeeper/pull/1611#issuecomment-787059788
Looking:)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] ztzg commented on pull request #1611: ZOOKEEPER-4219: Quota checks break setData in multi transactions
Posted by GitBox <gi...@apache.org>.
ztzg commented on pull request #1611:
URL: https://github.com/apache/zookeeper/pull/1611#issuecomment-787747977
> Thanks @ztzg , merged to master and 3.7.
Great; thank you!
> It will need to be cherry-picked to 3.7.0 release branch. Ping me Damien if you want me to cherry-pick it to 3.7.0.
Don't worry about it. Cherry-picking has not been 100% consistent on these branches; I will have to sort it out as I prepare the next RC (in a few days) anyway—and will try and keep the sequences as "parallel" as possible as I do so.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] ztzg commented on pull request #1611: ZOOKEEPER-4219: Quota checks break setData in multi transactions
Posted by GitBox <gi...@apache.org>.
ztzg commented on pull request #1611:
URL: https://github.com/apache/zookeeper/pull/1611#issuecomment-786038258
> I will take a look at this weekend(02-27 ~02-28) if you can wait for that time:)
@maoling: No pressure. Some people are surely impatiently waiting for 3.7 to get out, and I would like to push another RC ASAP—but it'll probably take a few more days to have this rigorously vetted unless many committers happen to have a lightly-loaded Friday. I just thought I'd ask :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] ztzg commented on pull request #1611: ZOOKEEPER-4219: Quota checks break setData in multi transactions
Posted by GitBox <gi...@apache.org>.
ztzg commented on pull request #1611:
URL: https://github.com/apache/zookeeper/pull/1611#issuecomment-787061668
> Looking:)
:)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] ztzg commented on pull request #1611: ZOOKEEPER-4219: Quota checks break setData in multi transactions
Posted by GitBox <gi...@apache.org>.
ztzg commented on pull request #1611:
URL: https://github.com/apache/zookeeper/pull/1611#issuecomment-785790837
@symat, @maoling, @hanm, @nkalmar, @anmolnar, @arshadmohammad: Pinging you as you were active on [ZOOKEEPER-3301](https://issues.apache.org/jira/browse/ZOOKEEPER-3301).
I have now marked [ZOOKEEPER-4219](https://issues.apache.org/jira/browse/ZOOKEEPER-4219) as a blocker, as I don't intend to release 3.7 without it.
If nobody sees a flaw in the proposed fix, I would love to have this merged before the weekend, so that I can prepare a new RC. WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] asfgit closed pull request #1611: ZOOKEEPER-4219: Quota checks break setData in multi transactions
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1611:
URL: https://github.com/apache/zookeeper/pull/1611
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org