[GitHub] [tvm] SebastianBoblest commented on pull request #12028: [WIP][Pylint] Making frontend tests pylint compliant

[GitBox <gi...@apache.org>]

SebastianBoblest commented on PR #12028:
URL: https://github.com/apache/tvm/pull/12028#issuecomment-1203964598

   > Got some problem when fixing `dangerous-default-value` in `pytorch/test_forward.py`.
   > 
   > https://github.com/apache/tvm/blob/39ffe0a5ce14c2105b7d48ee420e82e194787d8f/tests/python/frontend/pytorch/test_forward.py#L122-L124
   > 
   > I've tried several ways but none of them fully solve the problem as [64](https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/PR-12028/64/tests) [62](https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/PR-12028/62/pipeline) show. Any idea? @areusch @SebastianBoblest
   
   Hi, this function ''verify_model'' is really complicated and the relation between the arguments is quite complex.
   For example, if model_name is not a string, what should it be then? None or is something else also possible.
   This function alone actually requires extensive testing in my opinion.
   But I think this is a separate issue. 
   Why does 
   input_data = input_data or [] 
   not work in this case? It should be as close as possible to an empty list as default argument.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org