You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by xiaojian zhou <zh...@gmail.com> on 2017/01/03 00:57:40 UTC
Review Request 55124: fix duplicate entries from list lucene index and
search lucene index
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55124/
-----------------------------------------------------------
Review request for geode and Dan Smith.
Bugs: geode-2241
https://issues.apache.org/jira/browse/geode-2241
Repository: geode
Description
-------
list lucene index is at cache level, region might not be ready. But it's a light-weigh command, I just filter out the duplicated entries.
search lucene index currently will be called on all members, which is bad. I pick one of the members with region to execute.
Diffs
-----
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/cli/LuceneIndexCommands.java 0941834
Diff: https://reviews.apache.org/r/55124/diff/
Testing
-------
Thanks,
xiaojian zhou
Re: Review Request 55124: fix duplicate entries from list lucene
index and search lucene index
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55124/#review160449
-----------------------------------------------------------
Fix it, then Ship it!
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/cli/LuceneIndexCommands.java (line 120)
<https://reviews.apache.org/r/55124/#comment231593>
You could probably remove duplicates just by adding these LuceneIndexDetails to a sorted set.
- Dan Smith
On Jan. 3, 2017, 10:45 p.m., xiaojian zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55124/
> -----------------------------------------------------------
>
> (Updated Jan. 3, 2017, 10:45 p.m.)
>
>
> Review request for geode and Dan Smith.
>
>
> Bugs: geode-2241
> https://issues.apache.org/jira/browse/geode-2241
>
>
> Repository: geode
>
>
> Description
> -------
>
> list lucene index is at cache level, region might not be ready. But it's a light-weigh command, I just filter out the duplicated entries.
>
> search lucene index currently will be called on all members, which is bad. I pick one of the members with region to execute.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/management/internal/cli/CliUtil.java 4dcf3e0
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DataCommands.java b3a11fa
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/GemfireDataCommandsDUnitTest.java 66ac8ca
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/cli/LuceneIndexCommands.java 0941834
>
> Diff: https://reviews.apache.org/r/55124/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> xiaojian zhou
>
>
Re: Review Request 55124: fix duplicate entries from list lucene
index and search lucene index
Posted by xiaojian zhou <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55124/
-----------------------------------------------------------
(Updated Jan. 3, 2017, 10:45 p.m.)
Review request for geode and Dan Smith.
Changes
-------
Introduce a parameter returnAll.
Bugs: geode-2241
https://issues.apache.org/jira/browse/geode-2241
Repository: geode
Description
-------
list lucene index is at cache level, region might not be ready. But it's a light-weigh command, I just filter out the duplicated entries.
search lucene index currently will be called on all members, which is bad. I pick one of the members with region to execute.
Diffs (updated)
-----
geode-core/src/main/java/org/apache/geode/management/internal/cli/CliUtil.java 4dcf3e0
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DataCommands.java b3a11fa
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/GemfireDataCommandsDUnitTest.java 66ac8ca
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/cli/LuceneIndexCommands.java 0941834
Diff: https://reviews.apache.org/r/55124/diff/
Testing
-------
Thanks,
xiaojian zhou