You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/02/14 10:05:02 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5490: riscv/k210: Check idle stack before load to cpu[x]

xiaoxiang781216 commented on a change in pull request #5490:
URL: https://github.com/apache/incubator-nuttx/pull/5490#discussion_r805681079



##########
File path: arch/risc-v/src/k210/k210_head.S
##########
@@ -48,15 +48,29 @@ __start:
 
   /* Set stack pointer to the idle thread stack */
 
-  bnez a0, 1f
+  bnez a0, boot_slave_core
   la   sp, K210_IDLESTACK0_TOP
-  j    2f
-1:
+  j    common_startup
+
+boot_slave_core:

Review comment:
       why change 1 to boot_slave_core? you can use 1b at line 72.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org