[jira] [Work logged] (AMQ-7072) ActiveMQ shouldn't import jackson but use JSON-B instead of jackson to support impl switch

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/AMQ-7072?focusedWorklogId=562204&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-562204 ]

ASF GitHub Bot logged work on AMQ-7072:
---------------------------------------

                Author: ASF GitHub Bot
            Created on: 08/Mar/21 08:38
            Start Date: 08/Mar/21 08:38
    Worklog Time Spent: 10m 
      Work Description: lucastetreault commented on pull request #308:
URL: https://github.com/apache/activemq/pull/308#issuecomment-792580247


   Can one of the admins verify this patch?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 562204)
    Remaining Estimate: 0h
            Time Spent: 10m

> ActiveMQ shouldn't import jackson but use JSON-B instead of jackson to support impl switch
> ------------------------------------------------------------------------------------------
>
>                 Key: AMQ-7072
>                 URL: https://issues.apache.org/jira/browse/AMQ-7072
>             Project: ActiveMQ
>          Issue Type: Improvement
>    Affects Versions: 5.16.0
>            Reporter: Romain Manni-Bucau
>            Assignee: Jean-Baptiste Onofré
>            Priority: Major
>             Fix For: 5.17.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The regression we hit at the moment is that activemq enforces TomEE to import jackson whereas it wants to keep johnzon as JSON mapper impl. Since JSON-B spec is out and implemented by both I guess it can be the way to solve that issue.
> The most blocking thing is ./activemq-broker/src/main/java/org/apache/activemq/broker/jmx/DestinationsViewFilter.java - which can already not create a mapper if json is empty ;) - but here is the list of code location which would be neat to fix:
> {code}
> ./activemq-partition/src/main/java/org/apache/activemq/partition/dto/Partitioning.java:import com.fasterxml.jackson.annotation.JsonInclude;
> ./activemq-partition/src/main/java/org/apache/activemq/partition/dto/Partitioning.java:import com.fasterxml.jackson.databind.DeserializationFeature;
> ./activemq-partition/src/main/java/org/apache/activemq/partition/dto/Partitioning.java:import com.fasterxml.jackson.databind.ObjectMapper;
> ./activemq-partition/src/main/java/org/apache/activemq/partition/dto/Partitioning.java:import com.fasterxml.jackson.databind.DeserializationConfig;
> ./activemq-partition/src/main/java/org/apache/activemq/partition/dto/Partitioning.java:import com.fasterxml.jackson.databind.SerializationFeature;
> ./activemq-partition/src/main/java/org/apache/activemq/partition/dto/Partitioning.java:import com.fasterxml.jackson.databind.annotation.JsonDeserialize;
> ./activemq-partition/src/main/java/org/apache/activemq/partition/dto/Partitioning.java:import com.fasterxml.jackson.databind.annotation.JsonSerialize;
> ./activemq-partition/src/main/java/org/apache/activemq/partition/dto/Partitioning.java:import com.fasterxml.jackson.annotation.JsonProperty;
> ./activemq-partition/src/main/java/org/apache/activemq/partition/dto/Target.java:import com.fasterxml.jackson.annotation.JsonProperty;
> ./activemq-broker/src/main/java/org/apache/activemq/broker/jmx/DestinationsViewFilter.java:import com.fasterxml.jackson.databind.ObjectMapper;
> ./activemq-leveldb-store/src/main/java/org/apache/activemq/leveldb/replicated/dto/LogWrite.java:import com.fasterxml.jackson.annotation.JsonIgnoreProperties;
> ./activemq-leveldb-store/src/main/java/org/apache/activemq/leveldb/replicated/dto/WalAck.java:import com.fasterxml.jackson.annotation.JsonIgnoreProperties;
> ./activemq-leveldb-store/src/main/java/org/apache/activemq/leveldb/replicated/dto/LogDelete.java:import com.fasterxml.jackson.annotation.JsonIgnoreProperties;
> ./activemq-leveldb-store/src/main/java/org/apache/activemq/leveldb/replicated/dto/Transfer.java:import com.fasterxml.jackson.annotation.JsonIgnoreProperties;
> ./activemq-leveldb-store/src/main/java/org/apache/activemq/leveldb/replicated/dto/Login.java:import com.fasterxml.jackson.annotation.JsonIgnoreProperties;
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)