You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commons-dev@ws.apache.org by "Rich Scheuerle (JIRA)" <ji...@apache.org> on 2008/03/16 22:57:24 UTC

[jira] Created: (WSCOMMONS-312) Don't call builder.next() if builder is completed

Don't call builder.next() if builder is completed
-------------------------------------------------

                 Key: WSCOMMONS-312
                 URL: https://issues.apache.org/jira/browse/WSCOMMONS-312
             Project: WS-Commons
          Issue Type: Bug
            Reporter: Rich Scheuerle
            Assignee: Rich Scheuerle


Problem:

Builder.next() is invoked with a builder that is completed.  I received the following stack trace from Huiran Wang.

Caused by: org.apache.axiom.om.OMException
       at org.apache.axiom.om.impl.builder.StAXOMBuilder.next(StAXOMBuilder.java:159)
       at org.apache.axiom.om.impl.llom.OMElementImpl.buildNext(OMElementImpl.java:628)
       at org.apache.axiom.om.impl.llom.OMNodeImpl.getNextOMSibling(OMNodeImpl.java:135)
       at org.apache.axiom.om.impl.llom.OMElementImpl.getNextOMSibling(OMElementImpl.java:310)

Analysis:
This could be a side effect of OMSourcedElement usage.  I don't have a representative unit test.

Solution:
However I am going to add some additional trace and a slight accomodation in the code.  There are several places
where it is easy to ask the builder whether it is "complete" prior to calling builder.next.

I will be committing a small change soon.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: commons-dev-help@ws.apache.org


[jira] Commented: (WSCOMMONS-312) Don't call builder.next() if builder is completed

Posted by "Rich Scheuerle (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WSCOMMONS-312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12579268#action_12579268 ] 

Rich Scheuerle commented on WSCOMMONS-312:
------------------------------------------

Committed the change. (637668)

I am going to keep this defect open so that I can investigate getting a unit test.

> Don't call builder.next() if builder is completed
> -------------------------------------------------
>
>                 Key: WSCOMMONS-312
>                 URL: https://issues.apache.org/jira/browse/WSCOMMONS-312
>             Project: WS-Commons
>          Issue Type: Bug
>          Components: AXIOM
>            Reporter: Rich Scheuerle
>            Assignee: Rich Scheuerle
>
> Problem:
> Builder.next() is invoked with a builder that is completed.  I received the following stack trace from Huiran Wang.
> Caused by: org.apache.axiom.om.OMException
>        at org.apache.axiom.om.impl.builder.StAXOMBuilder.next(StAXOMBuilder.java:159)
>        at org.apache.axiom.om.impl.llom.OMElementImpl.buildNext(OMElementImpl.java:628)
>        at org.apache.axiom.om.impl.llom.OMNodeImpl.getNextOMSibling(OMNodeImpl.java:135)
>        at org.apache.axiom.om.impl.llom.OMElementImpl.getNextOMSibling(OMElementImpl.java:310)
> Analysis:
> This could be a side effect of OMSourcedElement usage.  I don't have a representative unit test.
> Solution:
> However I am going to add some additional trace and a slight accomodation in the code.  There are several places
> where it is easy to ask the builder whether it is "complete" prior to calling builder.next.
> I will be committing a small change soon.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: commons-dev-help@ws.apache.org


[jira] Updated: (WSCOMMONS-312) Don't call builder.next() if builder is completed

Posted by "Rich Scheuerle (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WSCOMMONS-312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rich Scheuerle updated WSCOMMONS-312:
-------------------------------------

    Component/s: AXIOM

> Don't call builder.next() if builder is completed
> -------------------------------------------------
>
>                 Key: WSCOMMONS-312
>                 URL: https://issues.apache.org/jira/browse/WSCOMMONS-312
>             Project: WS-Commons
>          Issue Type: Bug
>          Components: AXIOM
>            Reporter: Rich Scheuerle
>            Assignee: Rich Scheuerle
>
> Problem:
> Builder.next() is invoked with a builder that is completed.  I received the following stack trace from Huiran Wang.
> Caused by: org.apache.axiom.om.OMException
>        at org.apache.axiom.om.impl.builder.StAXOMBuilder.next(StAXOMBuilder.java:159)
>        at org.apache.axiom.om.impl.llom.OMElementImpl.buildNext(OMElementImpl.java:628)
>        at org.apache.axiom.om.impl.llom.OMNodeImpl.getNextOMSibling(OMNodeImpl.java:135)
>        at org.apache.axiom.om.impl.llom.OMElementImpl.getNextOMSibling(OMElementImpl.java:310)
> Analysis:
> This could be a side effect of OMSourcedElement usage.  I don't have a representative unit test.
> Solution:
> However I am going to add some additional trace and a slight accomodation in the code.  There are several places
> where it is easy to ask the builder whether it is "complete" prior to calling builder.next.
> I will be committing a small change soon.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: commons-dev-help@ws.apache.org


[jira] Resolved: (WSCOMMONS-312) Don't call builder.next() if builder is completed

Posted by "Rich Scheuerle (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WSCOMMONS-312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rich Scheuerle resolved WSCOMMONS-312.
--------------------------------------

    Resolution: Fixed

> Don't call builder.next() if builder is completed
> -------------------------------------------------
>
>                 Key: WSCOMMONS-312
>                 URL: https://issues.apache.org/jira/browse/WSCOMMONS-312
>             Project: WS-Commons
>          Issue Type: Bug
>          Components: AXIOM
>            Reporter: Rich Scheuerle
>            Assignee: Rich Scheuerle
>
> Problem:
> Builder.next() is invoked with a builder that is completed.  I received the following stack trace from Huiran Wang.
> Caused by: org.apache.axiom.om.OMException
>        at org.apache.axiom.om.impl.builder.StAXOMBuilder.next(StAXOMBuilder.java:159)
>        at org.apache.axiom.om.impl.llom.OMElementImpl.buildNext(OMElementImpl.java:628)
>        at org.apache.axiom.om.impl.llom.OMNodeImpl.getNextOMSibling(OMNodeImpl.java:135)
>        at org.apache.axiom.om.impl.llom.OMElementImpl.getNextOMSibling(OMElementImpl.java:310)
> Analysis:
> This could be a side effect of OMSourcedElement usage.  I don't have a representative unit test.
> Solution:
> However I am going to add some additional trace and a slight accomodation in the code.  There are several places
> where it is easy to ask the builder whether it is "complete" prior to calling builder.next.
> I will be committing a small change soon.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: commons-dev-help@ws.apache.org