You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/08/05 10:00:57 UTC

[GitHub] [cloudstack] ravening edited a comment on pull request #4228: Dont add host back after agent service restart

ravening edited a comment on pull request #4228:
URL: https://github.com/apache/cloudstack/pull/4228#issuecomment-669102037


   > @ravening @rhtyd how about hiding this behaviour behind a global setting `auto-add-hosts`? (default would have to be true for backwards compatibility)
   
   @DaanHoogland is this what you are suggesting?
   
   Lets say, I add a global setting `add.host.on.service.restart` with default value of true
   When we delete the host, if the value is false then we set zone/cluster/pod value to null else retain as it is
   
   Since default value is true, we dont change any value and host will be added back if service is restarted


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org