You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/06/05 19:28:43 UTC

[GitHub] [incubator-superset] john-bodley opened a new pull request #10001: style(mypy): Spit-and-polish pass

john-bodley opened a new pull request #10001:
URL: https://github.com/apache/incubator-superset/pull/10001


   ### SUMMARY
   
   This PR is hopefully the final `mypy` PR for now providing a spit-and-polish pass which attempts to:
   
   1. Warn on any unused `# type: ignore` statements via the `warn_unused_ignores = true` option. This option seems like a valuable way of enforcing periodical hygiene as typing of evolves especially with regards to third-party libraries.
   
   2. Adds more specific typing to previously loosely `Dict`, `dict`, `Callable`, `List`, `Tuple`, etc. types via the `disallow_any_generics = true` option. This ensures we have somewhat consistent (we still allow `Any`) typing throughout. Note for `Callable` often it was non-trivial for me to determine the args and return type so I opted for `Callable[..., Any]`.
   
   3. Applies enforcement to the `superset` module. Previously this was also the case but this was spelt out via enumerating all the existing modules due to the nature of the iterative type enforcement.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TEST PLAN
   
   CI.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   to: @serenajiang @villebro 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10001: style(mypy): Spit-and-polish pass

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10001:
URL: https://github.com/apache/incubator-superset/pull/10001#issuecomment-639747773






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10001: style(mypy): Spit-and-polish pass

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10001:
URL: https://github.com/apache/incubator-superset/pull/10001#issuecomment-639747773


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10001?src=pr&el=h1) Report
   > Merging [#10001](https://codecov.io/gh/apache/incubator-superset/pull/10001?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/63e0188f45134c25267d183f5d7391577f9a6d63&el=desc) will **increase** coverage by `0.01%`.
   > The diff coverage is `86.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10001/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10001?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10001      +/-   ##
   ==========================================
   + Coverage   70.40%   70.42%   +0.01%     
   ==========================================
     Files         585      585              
     Lines       31043    31037       -6     
     Branches     3277     3277              
   ==========================================
     Hits        21857    21857              
   + Misses       9075     9069       -6     
     Partials      111      111              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `53.93% <ø> (+<0.01%)` | :arrow_up: |
   | #javascript | `59.36% <ø> (-0.01%)` | :arrow_down: |
   | #python | `70.00% <86.23%> (+0.01%)` | :arrow_up: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10001?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/models/slice.py](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NsaWNlLnB5) | `85.02% <0.00%> (ø)` | |
   | [superset/tasks/celery\_app.py](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvY2VsZXJ5X2FwcC5weQ==) | `0.00% <0.00%> (ø)` | |
   | [superset/utils/logging\_configurator.py](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvbG9nZ2luZ19jb25maWd1cmF0b3IucHk=) | `81.48% <0.00%> (ø)` | |
   | [superset/views/base\_schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9zY2hlbWFzLnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `73.47% <14.28%> (ø)` | |
   | [superset/utils/screenshots.py](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvc2NyZWVuc2hvdHMucHk=) | `32.33% <25.00%> (ø)` | |
   | [...uperset/utils/dashboard\_filter\_scopes\_converter.py](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2ZpbHRlcl9zY29wZXNfY29udmVydGVyLnB5) | `34.04% <33.33%> (ø)` | |
   | [superset/connectors/connector\_registry.py](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9jb25uZWN0b3JfcmVnaXN0cnkucHk=) | `84.44% <50.00%> (-2.23%)` | :arrow_down: |
   | [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `82.60% <50.00%> (ø)` | |
   | [superset/views/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3Mvc2NoZWR1bGVzLnB5) | `60.86% <66.66%> (ø)` | |
   | ... and [48 more](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10001?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10001?src=pr&el=footer). Last update [63e0188...123d9d8](https://codecov.io/gh/apache/incubator-superset/pull/10001?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10001: style(mypy): Spit-and-polish pass

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10001:
URL: https://github.com/apache/incubator-superset/pull/10001#issuecomment-639747773


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10001?src=pr&el=h1) Report
   > Merging [#10001](https://codecov.io/gh/apache/incubator-superset/pull/10001?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/63e0188f45134c25267d183f5d7391577f9a6d63&el=desc) will **decrease** coverage by `4.95%`.
   > The diff coverage is `86.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10001/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10001?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10001      +/-   ##
   ==========================================
   - Coverage   70.40%   65.45%   -4.96%     
   ==========================================
     Files         585      585              
     Lines       31043    31037       -6     
     Branches     3277     3277              
   ==========================================
   - Hits        21857    20316    -1541     
   - Misses       9075    10540    +1465     
   - Partials      111      181      +70     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `59.36% <ø> (-0.01%)` | :arrow_down: |
   | #python | `69.75% <86.23%> (-0.24%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10001?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/models/slice.py](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NsaWNlLnB5) | `85.02% <0.00%> (ø)` | |
   | [superset/tasks/celery\_app.py](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvY2VsZXJ5X2FwcC5weQ==) | `0.00% <0.00%> (ø)` | |
   | [superset/utils/logging\_configurator.py](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvbG9nZ2luZ19jb25maWd1cmF0b3IucHk=) | `81.48% <0.00%> (ø)` | |
   | [superset/views/base\_schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9zY2hlbWFzLnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `73.47% <14.28%> (ø)` | |
   | [superset/utils/screenshots.py](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvc2NyZWVuc2hvdHMucHk=) | `32.33% <25.00%> (ø)` | |
   | [...uperset/utils/dashboard\_filter\_scopes\_converter.py](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2ZpbHRlcl9zY29wZXNfY29udmVydGVyLnB5) | `34.04% <33.33%> (ø)` | |
   | [superset/connectors/connector\_registry.py](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9jb25uZWN0b3JfcmVnaXN0cnkucHk=) | `84.44% <50.00%> (-2.23%)` | :arrow_down: |
   | [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `82.60% <50.00%> (ø)` | |
   | [superset/views/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3Mvc2NoZWR1bGVzLnB5) | `60.86% <66.66%> (ø)` | |
   | ... and [208 more](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10001?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10001?src=pr&el=footer). Last update [63e0188...123d9d8](https://codecov.io/gh/apache/incubator-superset/pull/10001?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter commented on pull request #10001: style(mypy): Spit-and-polish pass

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10001:
URL: https://github.com/apache/incubator-superset/pull/10001#issuecomment-639747773


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10001?src=pr&el=h1) Report
   > Merging [#10001](https://codecov.io/gh/apache/incubator-superset/pull/10001?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/63e0188f45134c25267d183f5d7391577f9a6d63&el=desc) will **decrease** coverage by `11.03%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10001/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10001?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master   #10001       +/-   ##
   ===========================================
   - Coverage   70.40%   59.37%   -11.04%     
   ===========================================
     Files         585      401      -184     
     Lines       31043    12841    -18202     
     Branches     3277     3277               
   ===========================================
   - Hits        21857     7624    -14233     
   + Misses       9075     5036     -4039     
   - Partials      111      181       +70     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `59.37% <ø> (ø)` | |
   | #python | `?` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10001?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [269 more](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10001?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10001?src=pr&el=footer). Last update [63e0188...b4a6699](https://codecov.io/gh/apache/incubator-superset/pull/10001?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10001: style(mypy): Spit-and-polish pass

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10001:
URL: https://github.com/apache/incubator-superset/pull/10001#issuecomment-639747773


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10001?src=pr&el=h1) Report
   > Merging [#10001](https://codecov.io/gh/apache/incubator-superset/pull/10001?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/63e0188f45134c25267d183f5d7391577f9a6d63&el=desc) will **decrease** coverage by `11.03%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10001/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10001?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master   #10001       +/-   ##
   ===========================================
   - Coverage   70.40%   59.36%   -11.04%     
   ===========================================
     Files         585      401      -184     
     Lines       31043    12840    -18203     
     Branches     3277     3277               
   ===========================================
   - Hits        21857     7623    -14234     
   + Misses       9075     5036     -4039     
   - Partials      111      181       +70     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `59.36% <ø> (-0.01%)` | :arrow_down: |
   | #python | `?` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10001?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [270 more](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10001?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10001?src=pr&el=footer). Last update [63e0188...143dee0](https://codecov.io/gh/apache/incubator-superset/pull/10001?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] john-bodley merged pull request #10001: style(mypy): Spit-and-polish pass

Posted by GitBox <gi...@apache.org>.
john-bodley merged pull request #10001:
URL: https://github.com/apache/incubator-superset/pull/10001


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10001: style(mypy): Spit-and-polish pass

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10001:
URL: https://github.com/apache/incubator-superset/pull/10001#issuecomment-639747773


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10001?src=pr&el=h1) Report
   > Merging [#10001](https://codecov.io/gh/apache/incubator-superset/pull/10001?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/63e0188f45134c25267d183f5d7391577f9a6d63&el=desc) will **decrease** coverage by `0.00%`.
   > The diff coverage is `86.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10001/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10001?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10001      +/-   ##
   ==========================================
   - Coverage   70.40%   70.40%   -0.01%     
   ==========================================
     Files         585      585              
     Lines       31043    31046       +3     
     Branches     3277     3277              
   ==========================================
   + Hits        21857    21859       +2     
   - Misses       9075     9076       +1     
     Partials      111      111              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `53.93% <ø> (+<0.01%)` | :arrow_up: |
   | #javascript | `59.36% <ø> (-0.01%)` | :arrow_down: |
   | #python | `69.98% <86.23%> (-0.01%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10001?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/models/slice.py](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NsaWNlLnB5) | `85.02% <0.00%> (ø)` | |
   | [superset/tasks/celery\_app.py](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvY2VsZXJ5X2FwcC5weQ==) | `0.00% <0.00%> (ø)` | |
   | [superset/utils/logging\_configurator.py](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvbG9nZ2luZ19jb25maWd1cmF0b3IucHk=) | `81.48% <0.00%> (ø)` | |
   | [superset/views/base\_schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9zY2hlbWFzLnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `73.47% <14.28%> (ø)` | |
   | [superset/utils/screenshots.py](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvc2NyZWVuc2hvdHMucHk=) | `32.33% <25.00%> (ø)` | |
   | [...uperset/utils/dashboard\_filter\_scopes\_converter.py](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2ZpbHRlcl9zY29wZXNfY29udmVydGVyLnB5) | `34.04% <33.33%> (ø)` | |
   | [superset/connectors/connector\_registry.py](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9jb25uZWN0b3JfcmVnaXN0cnkucHk=) | `84.44% <50.00%> (-2.23%)` | :arrow_down: |
   | [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `82.60% <50.00%> (ø)` | |
   | [superset/views/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3Mvc2NoZWR1bGVzLnB5) | `60.86% <66.66%> (ø)` | |
   | ... and [45 more](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10001?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10001?src=pr&el=footer). Last update [63e0188...123d9d8](https://codecov.io/gh/apache/incubator-superset/pull/10001?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10001: style(mypy): Spit-and-polish pass

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10001:
URL: https://github.com/apache/incubator-superset/pull/10001#issuecomment-639747773


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10001?src=pr&el=h1) Report
   > Merging [#10001](https://codecov.io/gh/apache/incubator-superset/pull/10001?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/63e0188f45134c25267d183f5d7391577f9a6d63&el=desc) will **decrease** coverage by `0.65%`.
   > The diff coverage is `86.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10001/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10001?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10001      +/-   ##
   ==========================================
   - Coverage   70.40%   69.75%   -0.66%     
   ==========================================
     Files         585      184     -401     
     Lines       31043    18197   -12846     
     Branches     3277        0    -3277     
   ==========================================
   - Hits        21857    12693    -9164     
   + Misses       9075     5504    -3571     
   + Partials      111        0     -111     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `69.75% <86.23%> (-0.24%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10001?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/models/slice.py](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NsaWNlLnB5) | `85.02% <0.00%> (ø)` | |
   | [superset/tasks/celery\_app.py](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvY2VsZXJ5X2FwcC5weQ==) | `0.00% <0.00%> (ø)` | |
   | [superset/utils/logging\_configurator.py](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvbG9nZ2luZ19jb25maWd1cmF0b3IucHk=) | `81.48% <0.00%> (ø)` | |
   | [superset/views/base\_schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9zY2hlbWFzLnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `73.47% <14.28%> (ø)` | |
   | [superset/utils/screenshots.py](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvc2NyZWVuc2hvdHMucHk=) | `32.33% <25.00%> (ø)` | |
   | [...uperset/utils/dashboard\_filter\_scopes\_converter.py](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2ZpbHRlcl9zY29wZXNfY29udmVydGVyLnB5) | `34.04% <33.33%> (ø)` | |
   | [superset/connectors/connector\_registry.py](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9jb25uZWN0b3JfcmVnaXN0cnkucHk=) | `84.44% <50.00%> (-2.23%)` | :arrow_down: |
   | [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `82.60% <50.00%> (ø)` | |
   | [superset/views/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3Mvc2NoZWR1bGVzLnB5) | `60.86% <66.66%> (ø)` | |
   | ... and [460 more](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10001?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10001?src=pr&el=footer). Last update [63e0188...123d9d8](https://codecov.io/gh/apache/incubator-superset/pull/10001?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10001: style(mypy): Spit-and-polish pass

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10001:
URL: https://github.com/apache/incubator-superset/pull/10001#issuecomment-639747773


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10001?src=pr&el=h1) Report
   > Merging [#10001](https://codecov.io/gh/apache/incubator-superset/pull/10001?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/63e0188f45134c25267d183f5d7391577f9a6d63&el=desc) will **decrease** coverage by `11.03%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10001/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10001?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master   #10001       +/-   ##
   ===========================================
   - Coverage   70.40%   59.36%   -11.04%     
   ===========================================
     Files         585      401      -184     
     Lines       31043    12840    -18203     
     Branches     3277     3277               
   ===========================================
   - Hits        21857     7623    -14234     
   + Misses       9075     5036     -4039     
   - Partials      111      181       +70     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `59.36% <ø> (-0.01%)` | :arrow_down: |
   | #python | `?` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10001?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [270 more](https://codecov.io/gh/apache/incubator-superset/pull/10001/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10001?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10001?src=pr&el=footer). Last update [63e0188...e6e2d0c](https://codecov.io/gh/apache/incubator-superset/pull/10001?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] john-bodley commented on a change in pull request #10001: style(mypy): Spit-and-polish pass

Posted by GitBox <gi...@apache.org>.
john-bodley commented on a change in pull request #10001:
URL: https://github.com/apache/incubator-superset/pull/10001#discussion_r436191232



##########
File path: superset/utils/cache.py
##########
@@ -27,8 +27,9 @@ def view_cache_key(*args: Any, **kwargs: Any) -> str:  # pylint: disable=unused-
 
 
 def memoized_func(
-    key: Callable = view_cache_key, attribute_in_key: Optional[str] = None
-) -> Callable:
+    key: Callable[..., str] = view_cache_key,  # pylint: disable=bad-whitespace

Review comment:
       Note I'm unsure why `pylint` is barfing here. Per SIP-46 there's tentative plans to fix all the `pylint` issues (including bumping the version) and I sense for now we should  just accept the `pylint` "regressions".




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org