You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Jean-Baptiste Onofré (JIRA)" <ji...@codehaus.org> on 2011/12/13 15:35:02 UTC
[jira] (MSKINS-19) fluido doesn't render links
Jean-Baptiste Onofré created MSKINS-19:
------------------------------------------
Summary: fluido doesn't render links
Key: MSKINS-19
URL: https://jira.codehaus.org/browse/MSKINS-19
Project: Maven Skins
Issue Type: Bug
Components: Fluido Skin
Affects Versions: fluido-1.0
Environment: Maven 3.0.3
Fluido 1.0
Reporter: Jean-Baptiste Onofré
Attachments: MSKIN.patch
With the following site.xml:
<project name="Test">
<skin>
<groupId>org.apache.maven.skins</groupId>
<artifactId>maven-fluido-skin</artifactId>
<version>1.0</version>
</skin>
<bannerLeft>
<name>Kalumet</name>
<src>images/logo.png</src>
<href>http://incubator.apache.org/kalumet</href>
</bannerLeft>
<publishDate position="none"/>
<version position="none"/>
<body>
<links>
<item name="Home" href=""/>
<item name="Download" href=""/>
<item name="Documentation" href=""/>
<item name="Wiki" href=""/>
<item name="Apache" href="http://www.apache.org"/>
</links>
</body>
</project>
the body.links are not displayed at all (not in the top banner, nor in "External Links" of the left banner).
The attached patch renders the links.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MSKINS-19) fluido doesn't render links
Posted by "Robert Scholte (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MSKINS-19?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Scholte closed MSKINS-19.
--------------------------------
Resolution: Fixed
Fix Version/s: fluido-1.1
> fluido doesn't render links
> ---------------------------
>
> Key: MSKINS-19
> URL: https://jira.codehaus.org/browse/MSKINS-19
> Project: Maven Skins
> Issue Type: Bug
> Components: Fluido Skin
> Affects Versions: fluido-1.0
> Environment: Maven 3.0.3
> Fluido 1.0
> Reporter: Jean-Baptiste Onofré
> Assignee: Simone Tripodi
> Fix For: fluido-1.1
>
> Attachments: MSKIN.patch
>
>
> With the following site.xml:
> <project name="Test">
> <skin>
> <groupId>org.apache.maven.skins</groupId>
> <artifactId>maven-fluido-skin</artifactId>
> <version>1.0</version>
> </skin>
> <bannerLeft>
> <name>Kalumet</name>
> <src>images/logo.png</src>
> <href>http://incubator.apache.org/kalumet</href>
> </bannerLeft>
> <publishDate position="none"/>
> <version position="none"/>
> <body>
> <links>
> <item name="Home" href=""/>
> <item name="Download" href=""/>
> <item name="Documentation" href=""/>
> <item name="Wiki" href=""/>
> <item name="Apache" href="http://www.apache.org"/>
> </links>
> </body>
> </project>
> the body.links are not displayed at all (not in the top banner, nor in "External Links" of the left banner).
> The attached patch renders the links.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MSKINS-19) fluido doesn't render links
Posted by "Jean-Baptiste Onofré (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MSKINS-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=285760#comment-285760 ]
Jean-Baptiste Onofré commented on MSKINS-19:
--------------------------------------------
Hi Simo,
thanks for the update. I didn't see MSKINS-15, sorry for that.
> fluido doesn't render links
> ---------------------------
>
> Key: MSKINS-19
> URL: https://jira.codehaus.org/browse/MSKINS-19
> Project: Maven Skins
> Issue Type: Bug
> Components: Fluido Skin
> Affects Versions: fluido-1.0
> Environment: Maven 3.0.3
> Fluido 1.0
> Reporter: Jean-Baptiste Onofré
> Attachments: MSKIN.patch
>
>
> With the following site.xml:
> <project name="Test">
> <skin>
> <groupId>org.apache.maven.skins</groupId>
> <artifactId>maven-fluido-skin</artifactId>
> <version>1.0</version>
> </skin>
> <bannerLeft>
> <name>Kalumet</name>
> <src>images/logo.png</src>
> <href>http://incubator.apache.org/kalumet</href>
> </bannerLeft>
> <publishDate position="none"/>
> <version position="none"/>
> <body>
> <links>
> <item name="Home" href=""/>
> <item name="Download" href=""/>
> <item name="Documentation" href=""/>
> <item name="Wiki" href=""/>
> <item name="Apache" href="http://www.apache.org"/>
> </links>
> </body>
> </project>
> the body.links are not displayed at all (not in the top banner, nor in "External Links" of the left banner).
> The attached patch renders the links.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MSKINS-19) fluido doesn't render links
Posted by "Mirko Friedenhagen (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MSKINS-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=285795#comment-285795 ]
Mirko Friedenhagen commented on MSKINS-19:
------------------------------------------
Well, I do not mind taking the more Maven like approach as long as it does not throttles the release of version 1.1. :-)
> fluido doesn't render links
> ---------------------------
>
> Key: MSKINS-19
> URL: https://jira.codehaus.org/browse/MSKINS-19
> Project: Maven Skins
> Issue Type: Bug
> Components: Fluido Skin
> Affects Versions: fluido-1.0
> Environment: Maven 3.0.3
> Fluido 1.0
> Reporter: Jean-Baptiste Onofré
> Attachments: MSKIN.patch
>
>
> With the following site.xml:
> <project name="Test">
> <skin>
> <groupId>org.apache.maven.skins</groupId>
> <artifactId>maven-fluido-skin</artifactId>
> <version>1.0</version>
> </skin>
> <bannerLeft>
> <name>Kalumet</name>
> <src>images/logo.png</src>
> <href>http://incubator.apache.org/kalumet</href>
> </bannerLeft>
> <publishDate position="none"/>
> <version position="none"/>
> <body>
> <links>
> <item name="Home" href=""/>
> <item name="Download" href=""/>
> <item name="Documentation" href=""/>
> <item name="Wiki" href=""/>
> <item name="Apache" href="http://www.apache.org"/>
> </links>
> </body>
> </project>
> the body.links are not displayed at all (not in the top banner, nor in "External Links" of the left banner).
> The attached patch renders the links.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MSKINS-19) fluido doesn't render links
Posted by "Simone Tripodi (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MSKINS-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=286493#comment-286493 ]
Simone Tripodi commented on MSKINS-19:
--------------------------------------
Issue has been fixed, see [r1221707|https://svn.apache.org/viewvc?view=revision&revision=1221707].
Thanks Jean-Baptiste for the patch, I had to add few modifications but helped anyway!
> fluido doesn't render links
> ---------------------------
>
> Key: MSKINS-19
> URL: https://jira.codehaus.org/browse/MSKINS-19
> Project: Maven Skins
> Issue Type: Bug
> Components: Fluido Skin
> Affects Versions: fluido-1.0
> Environment: Maven 3.0.3
> Fluido 1.0
> Reporter: Jean-Baptiste Onofré
> Assignee: Robert Scholte
> Attachments: MSKIN.patch
>
>
> With the following site.xml:
> <project name="Test">
> <skin>
> <groupId>org.apache.maven.skins</groupId>
> <artifactId>maven-fluido-skin</artifactId>
> <version>1.0</version>
> </skin>
> <bannerLeft>
> <name>Kalumet</name>
> <src>images/logo.png</src>
> <href>http://incubator.apache.org/kalumet</href>
> </bannerLeft>
> <publishDate position="none"/>
> <version position="none"/>
> <body>
> <links>
> <item name="Home" href=""/>
> <item name="Download" href=""/>
> <item name="Documentation" href=""/>
> <item name="Wiki" href=""/>
> <item name="Apache" href="http://www.apache.org"/>
> </links>
> </body>
> </project>
> the body.links are not displayed at all (not in the top banner, nor in "External Links" of the left banner).
> The attached patch renders the links.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MSKINS-19) fluido doesn't render links
Posted by "Jean-Baptiste Onofré (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MSKINS-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=286495#comment-286495 ]
Jean-Baptiste Onofré commented on MSKINS-19:
--------------------------------------------
No problem, thanks for the fix ;)
> fluido doesn't render links
> ---------------------------
>
> Key: MSKINS-19
> URL: https://jira.codehaus.org/browse/MSKINS-19
> Project: Maven Skins
> Issue Type: Bug
> Components: Fluido Skin
> Affects Versions: fluido-1.0
> Environment: Maven 3.0.3
> Fluido 1.0
> Reporter: Jean-Baptiste Onofré
> Assignee: Robert Scholte
> Attachments: MSKIN.patch
>
>
> With the following site.xml:
> <project name="Test">
> <skin>
> <groupId>org.apache.maven.skins</groupId>
> <artifactId>maven-fluido-skin</artifactId>
> <version>1.0</version>
> </skin>
> <bannerLeft>
> <name>Kalumet</name>
> <src>images/logo.png</src>
> <href>http://incubator.apache.org/kalumet</href>
> </bannerLeft>
> <publishDate position="none"/>
> <version position="none"/>
> <body>
> <links>
> <item name="Home" href=""/>
> <item name="Download" href=""/>
> <item name="Documentation" href=""/>
> <item name="Wiki" href=""/>
> <item name="Apache" href="http://www.apache.org"/>
> </links>
> </body>
> </project>
> the body.links are not displayed at all (not in the top banner, nor in "External Links" of the left banner).
> The attached patch renders the links.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MSKINS-19) fluido doesn't render links
Posted by "Simone Tripodi (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MSKINS-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=285758#comment-285758 ]
Simone Tripodi commented on MSKINS-19:
--------------------------------------
Salut Jean-Baptiste!
this issue should have been already fixed on trunk, using a different approach, see MSKINS-15|https://jira.codehaus.org/browse/MSKINS-15]
IMHO your approach is more canonical, compliant to what Maven users are already used to - I think I have to move the discussion in the ML.
Thanks for contributing!
-Simo
> fluido doesn't render links
> ---------------------------
>
> Key: MSKINS-19
> URL: https://jira.codehaus.org/browse/MSKINS-19
> Project: Maven Skins
> Issue Type: Bug
> Components: Fluido Skin
> Affects Versions: fluido-1.0
> Environment: Maven 3.0.3
> Fluido 1.0
> Reporter: Jean-Baptiste Onofré
> Attachments: MSKIN.patch
>
>
> With the following site.xml:
> <project name="Test">
> <skin>
> <groupId>org.apache.maven.skins</groupId>
> <artifactId>maven-fluido-skin</artifactId>
> <version>1.0</version>
> </skin>
> <bannerLeft>
> <name>Kalumet</name>
> <src>images/logo.png</src>
> <href>http://incubator.apache.org/kalumet</href>
> </bannerLeft>
> <publishDate position="none"/>
> <version position="none"/>
> <body>
> <links>
> <item name="Home" href=""/>
> <item name="Download" href=""/>
> <item name="Documentation" href=""/>
> <item name="Wiki" href=""/>
> <item name="Apache" href="http://www.apache.org"/>
> </links>
> </body>
> </project>
> the body.links are not displayed at all (not in the top banner, nor in "External Links" of the left banner).
> The attached patch renders the links.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira