You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/05/06 12:48:18 UTC
[GitHub] [spark] cloud-fan commented on a change in pull request #24533:
[SPARK-27637] For nettyBlockTransferService,
when exception occurred when fetching data,
check whether relative executor is alive before retry
cloud-fan commented on a change in pull request #24533: [SPARK-27637] For nettyBlockTransferService, when exception occurred when fetching data, check whether relative executor is alive before retry
URL: https://github.com/apache/spark/pull/24533#discussion_r281170121
##########
File path: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RetryingBlockFetcher.java
##########
@@ -178,7 +202,11 @@ private synchronized boolean shouldRetry(Throwable e) {
boolean isIOException = e instanceof IOException
Review comment:
what is the exception type when the executor is dead during shuffle fetch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org