You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2023/01/04 10:16:31 UTC

[GitHub] [maven] gnodet opened a new pull request, #947: [MNG-7642] Restore compatibility with flatten-maven-plugin

gnodet opened a new pull request, #947:
URL: https://github.com/apache/maven/pull/947

   Revert "[MNG-7505] Remove ReportingConverter (#906)"
   This reverts commit adf89ef63ffca07e490f5cc550f9411bad1a7bd6.
   
   Following this checklist to help us incorporate your
   contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed
          for the change (usually before you start working on it).  Trivial changes like typos do not
          require a JIRA issue. Your pull request should address just this issue, without
          pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Format the pull request title like `[MNG-XXX] SUMMARY`,
          where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA issue.
    - [ ] Also format the first line of the commit message like `[MNG-XXX] SUMMARY`.
          Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message.
    - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
          be performed on your pull request automatically.
    - [ ] You have run the [Core IT][core-its] successfully.
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under
   the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
    - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
    - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   [core-its]: https://maven.apache.org/core-its/core-it-suite/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven] gnodet commented on pull request #947: [MNG-7642] Restore compatibility with flatten-maven-plugin

Posted by GitBox <gi...@apache.org>.
gnodet commented on PR #947:
URL: https://github.com/apache/maven/pull/947#issuecomment-1370845771

   > Not sure about _Restore compatibility_. This just restores as no-op methods. If flatten called them - didn't it do it for some purpose? Will flatten behave as expected or just not throw API incompatibility exception and silently do who-knows-what? Perhaps flatten should be updated instead?
   > 
   > I admit - I have not reviewed this PR/[MNG-7642](https://issues.apache.org/jira/browse/MNG-7642) in detail, so it might all be fine. No need to reply to my comment.
   
   Those classes are actually not used.  But the flatten maven plugin needs to be injected with one instance of `ReportingConverter`, see https://github.com/mojohaus/flatten-maven-plugin/blob/master/src/main/java/org/codehaus/mojo/flatten/ModelBuilderThreadSafetyWorkaround.java#L107
   It will simply pass it to the `ModelBuilder` in the loop method.
   
   The flatten plugin should also be adapted to support the removal of those classes, so that we can get rid of those in 4.1 for example.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven] gnodet commented on pull request #947: [MNG-7642] Restore compatibility with flatten-maven-plugin

Posted by GitBox <gi...@apache.org>.
gnodet commented on PR #947:
URL: https://github.com/apache/maven/pull/947#issuecomment-1370889590

   > I think I can see that now.
   > Thanks @gnodet.
   
   Yes, it's really just for binary compatibility with the existing stuff.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven] pzygielo commented on pull request #947: [MNG-7642] Restore compatibility with flatten-maven-plugin

Posted by GitBox <gi...@apache.org>.
pzygielo commented on PR #947:
URL: https://github.com/apache/maven/pull/947#issuecomment-1370861376

   So it will be passed in
   https://github.com/apache/maven/blob/aab448546326da99fd8f2fc5d15ff08dd79bae8e/src/main/java/org/codehaus/mojo/flatten/ModelBuilderThreadSafetyWorkaround.java#L131
   just to be ignored?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven] gnodet merged pull request #947: [MNG-7642] Restore compatibility with flatten-maven-plugin

Posted by GitBox <gi...@apache.org>.
gnodet merged PR #947:
URL: https://github.com/apache/maven/pull/947


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven] pzygielo commented on a diff in pull request #947: [MNG-7642] Restore compatibility with flatten-maven-plugin

Posted by GitBox <gi...@apache.org>.
pzygielo commented on code in PR #947:
URL: https://github.com/apache/maven/pull/947#discussion_r1061375606


##########
maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java:
##########
@@ -625,6 +626,15 @@ public DefaultModelBuilder setProfileActivationFilePathInterpolator(
                 versionProcessor);
     }
 
+    /**
+     * @deprecated since Maven 4
+     * @see DefaultModelBuilderFactory#setReportingConverter(ReportingConverter)

Review Comment:
   There is nothing to be seen there.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven] gnodet commented on a diff in pull request #947: [MNG-7642] Restore compatibility with flatten-maven-plugin

Posted by GitBox <gi...@apache.org>.
gnodet commented on code in PR #947:
URL: https://github.com/apache/maven/pull/947#discussion_r1061415474


##########
maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java:
##########
@@ -625,6 +626,15 @@ public DefaultModelBuilder setProfileActivationFilePathInterpolator(
                 versionProcessor);
     }
 
+    /**
+     * @deprecated since Maven 4
+     * @see DefaultModelBuilderFactory#setReportingConverter(ReportingConverter)

Review Comment:
   All the `setXxx` methods have the same javadoc.  The deprecation is not something new in this case.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven] pzygielo commented on pull request #947: [MNG-7642] Restore compatibility with flatten-maven-plugin

Posted by GitBox <gi...@apache.org>.
pzygielo commented on PR #947:
URL: https://github.com/apache/maven/pull/947#issuecomment-1370872944

   I think I can see that now.
   Thanks @gnodet.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven] michael-o commented on a diff in pull request #947: [MNG-7642] Restore compatibility with flatten-maven-plugin

Posted by GitBox <gi...@apache.org>.
michael-o commented on code in PR #947:
URL: https://github.com/apache/maven/pull/947#discussion_r1062712956


##########
maven-model-builder/src/main/java/org/apache/maven/model/plugin/DefaultReportingConverter.java:
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.model.plugin;
+
+import javax.inject.Named;
+import javax.inject.Singleton;
+
+import org.apache.maven.model.Model;
+import org.apache.maven.model.building.ModelBuildingRequest;
+import org.apache.maven.model.building.ModelProblemCollector;
+
+/**
+ * Handles conversion of the <code>&lt;reporting&gt;</code> section into the configuration of Maven Site Plugin 3.x,
+ * i.e. <code>reportPlugins</code> and <code>outputDirectory</code> parameters.
+ *
+ * @author Benjamin Bentmann
+ * @deprecated since maven 4.0, this class is not used anymore and is only here for compatibility

Review Comment:
   Don't should say that this is a no-op



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven] pzygielo commented on pull request #947: [MNG-7642] Restore compatibility with flatten-maven-plugin

Posted by GitBox <gi...@apache.org>.
pzygielo commented on PR #947:
URL: https://github.com/apache/maven/pull/947#issuecomment-1370802637

   Not sure about _Restore compatibility_.
   This just restores as no-op methods. If flatten called them - didn't it do it for some purpose?
   Will flatten behave as expected or just not throw API incompatibility exception and silently do who-knows-what? Perhaps flatten should be updated instead?
   
   I admit - I have not reviewed this PR/MNG-7642 in detail, so it might all be fine. No need to reply to my comment.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org