[GitHub] [tvm] gromero commented on a diff in pull request #12209: [microTVM][Zephyr][projectAPI] Minimize project build commands

[GitBox <gi...@apache.org>]

gromero commented on code in PR #12209:
URL: https://github.com/apache/tvm/pull/12209#discussion_r932596942


##########
gallery/how_to/work_with_microtvm/micro_tvmc.sh:
##########
@@ -121,7 +121,9 @@ tvmc compile magic_wand.tflite \
 #
 # To generate a Zephyr project we use TVM Micro subcommand ``create``. We pass the MLF format and the path
 # for the project to ``create`` subcommand along with project options. Project options for each
-# platform (Zephyr/Arduino) are defined in their Project API server file. To generate Zephyr project, run:
+# platform (Zephyr/Arduino) are defined in their Project API server file. To build
+# Zephyr project for a different Zephyr board, change ``zephyr_board`` project option. 

Review Comment:
   Please remove the trailing space in this line.



##########
apps/microtvm/zephyr/template_project/microtvm_api_server.py:
##########
@@ -419,7 +419,7 @@ def _create_prj_conf(self, project_dir, options):
             f.write("\n")
 
     API_SERVER_CRT_LIBS_TOKEN = "<API_SERVER_CRT_LIBS>"
-    ENABLE_CMSIS_TOKEN = "<ENABLE_CMSIS>"
+    CMAKE_ARGS = "<CMAKE_ARGS>"

Review Comment:
   I'd like to use  `CMAKE_ARGS_TOKEN` as the var name here , with `_TOKEN` at the end, like it was before for the `ENABLE_CMSIS_TOKEN` var. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org