[GitHub] [pulsar] BewareMyPower edited a comment on issue #12087: PIP 96: Payload processor for Pulsar client

[GitBox <gi...@apache.org>]

BewareMyPower edited a comment on issue #12087:
URL: https://github.com/apache/pulsar/issues/12087#issuecomment-930708942


   > so maybe BatchContext is more reasonable here? 
   
   I think not. Because the Entry might just be a single message, not the batch. You can also see related docs in `EntryContext`:
   
   ```java
       /**
        * Check whether the entry is a batch.
        *
        * @return true if the entry is a batch.
        */
       boolean isBatch();
   ```
   
   I've used `MessageContext` before, but it might be misunderstood as the context of a `Message<T>`.
   
   Your concern is right. `Entry` is a concept from BookKeeper. For Pulsar client users, it might look a little unfamiliar. ~~I think we can rename it `PayloadContext`? Since it's a context of a payload.~~ (Reject this thought because it will cause confusion when `getNumMessages()` doesn't return the actual number of messages because it's stored in payload)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org