You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Aleksandr Kovalenko <ak...@hortonworks.com> on 2014/10/17 15:25:03 UTC

Review Request 26874: UI - prevent user from deleting host with not "DECOMMISSIONED" datanode/nodemanager.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26874/
-----------------------------------------------------------

Review request for Ambari and Andriy Babiichuk.


Bugs: ABMARI-7815
    https://issues.apache.org/jira/browse/ABMARI-7815


Repository: ambari


Description
-------

UI -> Hosts -> any host to delete -> Host action ->  Delete Host
Check if datanode/nodemanager in "DECOMMISSIONED" admin state.
If yes - delete the host, if no - write a warning.


Diffs
-----

  ambari-web/app/controllers/global/update_controller.js 8fb056e 
  ambari-web/app/controllers/main/host/details.js 0398be5 
  ambari-web/app/mappers/component_config_mapper.js 83a6d68 
  ambari-web/app/mappers/hosts_mapper.js 241ea88 
  ambari-web/app/mappers/service_metrics_mapper.js 1172381 
  ambari-web/app/messages.js e549629 
  ambari-web/app/models/host_component.js 73fc852 
  ambari-web/app/templates/main/host/details/raiseDeleteComponentErrorPopup.hbs 46129aa 
  ambari-web/test/controllers/main/host/details_test.js 1dd212a 

Diff: https://reviews.apache.org/r/26874/diff/


Testing
-------

4638 tests complete (7 seconds)
60 tests pending

2 tests added


Thanks,

Aleksandr Kovalenko


Re: Review Request 26874: UI - prevent user from deleting host with not "DECOMMISSIONED" datanode/nodemanager.

Posted by Andriy Babiichuk <ab...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26874/#review57132
-----------------------------------------------------------

Ship it!


Ship It!

- Andriy Babiichuk


On Окт. 17, 2014, 1:25 п.п., Aleksandr Kovalenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26874/
> -----------------------------------------------------------
> 
> (Updated Окт. 17, 2014, 1:25 п.п.)
> 
> 
> Review request for Ambari and Andriy Babiichuk.
> 
> 
> Bugs: ABMARI-7815
>     https://issues.apache.org/jira/browse/ABMARI-7815
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> UI -> Hosts -> any host to delete -> Host action ->  Delete Host
> Check if datanode/nodemanager in "DECOMMISSIONED" admin state.
> If yes - delete the host, if no - write a warning.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/global/update_controller.js 8fb056e 
>   ambari-web/app/controllers/main/host/details.js 0398be5 
>   ambari-web/app/mappers/component_config_mapper.js 83a6d68 
>   ambari-web/app/mappers/hosts_mapper.js 241ea88 
>   ambari-web/app/mappers/service_metrics_mapper.js 1172381 
>   ambari-web/app/messages.js e549629 
>   ambari-web/app/models/host_component.js 73fc852 
>   ambari-web/app/templates/main/host/details/raiseDeleteComponentErrorPopup.hbs 46129aa 
>   ambari-web/test/controllers/main/host/details_test.js 1dd212a 
> 
> Diff: https://reviews.apache.org/r/26874/diff/
> 
> 
> Testing
> -------
> 
> 4638 tests complete (7 seconds)
> 60 tests pending
> 
> 2 tests added
> 
> 
> Thanks,
> 
> Aleksandr Kovalenko
> 
>