[GitHub] [beam] kennknowles commented on a diff in pull request #26770: Include "(GPN:Beam)" in user-agent of GCS HTTP request header for Java.

["kennknowles (via GitHub)" <gi...@apache.org>]

kennknowles commented on code in PR #26770:
URL: https://github.com/apache/beam/pull/26770#discussion_r1198356087


##########
sdks/java/extensions/google-cloud-platform-core/src/main/java/org/apache/beam/sdk/extensions/gcp/util/Transport.java:
##########
@@ -101,7 +102,7 @@ public static Storage.Builder newStorageClient(GcsOptions options) {
                     // logging it by default clutters the output during file staging.
                     new RetryHttpRequestInitializer(
                         ImmutableList.of(404), new UploadIdResponseInterceptor())))
-            .setApplicationName(options.getAppName())
+            .setApplicationName(applicationNamePrefix + options.getAppName())

Review Comment:
   This would actually make an invalid user agent if it came first. Is there a spec for where the application name goes in the user-agent field?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org