You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/03/26 16:54:07 UTC
[GitHub] [kafka] wcarlson5 opened a new pull request #10416: KAFKA-8784: remove default close for RocksDBConfigSetter
wcarlson5 opened a new pull request #10416:
URL: https://github.com/apache/kafka/pull/10416
remove default
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on pull request #10416: KAFKA-8784: remove default close for RocksDBConfigSetter
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #10416:
URL: https://github.com/apache/kafka/pull/10416#issuecomment-809598359
Hey @wcarlson5 I'm having trouble viewing the test failures, the only one I can actually see is `connect.mirror.integration.MirrorConnectorsIntegrationTest.testReplication()` but all three builds are showing failures (JDK15 timed out but that seems to be a known unrelated issue). The only other thing is ` [Checks API] No suitable checks publisher found.` which seems like it's probably environmental.
I assume these are all unrelated but can you just run the tests locally for me to make sure before I merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman merged pull request #10416: KAFKA-8784: remove default close for RocksDBConfigSetter
Posted by GitBox <gi...@apache.org>.
ableegoldman merged pull request #10416:
URL: https://github.com/apache/kafka/pull/10416
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on a change in pull request #10416: KAFKA-8784: remove default close for RocksDBConfigSetter
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on a change in pull request #10416:
URL: https://github.com/apache/kafka/pull/10416#discussion_r602495343
##########
File path: streams/src/test/java/org/apache/kafka/test/MockRocksDbConfigSetter.java
##########
@@ -32,4 +32,9 @@ public void setConfig(final String storeName, final Options options, final Map<S
configMap.putAll(configs);
}
+
+ @Override
+ public void close(String storeName, Options options) {
+ LOG.warn("The default close was removed in 3.0.0 -- you should overwrite it if you have implemented RocksDBConfigSetter");
Review comment:
I think this mock is probably only used internally by Streams tests, so we don't need to log anything for users here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] wcarlson5 edited a comment on pull request #10416: KAFKA-8784: remove default close for RocksDBConfigSetter
Posted by GitBox <gi...@apache.org>.
wcarlson5 edited a comment on pull request #10416:
URL: https://github.com/apache/kafka/pull/10416#issuecomment-808370533
@ableegoldman for review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] wcarlson5 commented on pull request #10416: KAFKA-8784: remove default close for RocksDBConfigSetter
Posted by GitBox <gi...@apache.org>.
wcarlson5 commented on pull request #10416:
URL: https://github.com/apache/kafka/pull/10416#issuecomment-808370533
@ableegoldman
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] wcarlson5 commented on pull request #10416: KAFKA-8784: remove default close for RocksDBConfigSetter
Posted by GitBox <gi...@apache.org>.
wcarlson5 commented on pull request #10416:
URL: https://github.com/apache/kafka/pull/10416#issuecomment-809722475
@ableegoldman the tests all passed locally
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org