[GitHub] [ozone] fapifta commented on pull request #5001: HDDS-8593. Add RootCARotationPoller to CertClient

["fapifta (via GitHub)" <gi...@apache.org>]

fapifta commented on PR #5001:
URL: https://github.com/apache/ozone/pull/5001#issuecomment-1613454858

   Thank you @Galsza for sharing this one early on.
   
   I have checked the changes, and I have one note:
   The SCMCertificateClient should not start a poller, as SCM's will be notified about the new rootCA via Ratis, and they will act and update their state based on the transactions posted by the leader to the raft ring.
   
   Other than that, the changes looks good.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org