You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "kwin (via GitHub)" <gi...@apache.org> on 2024/11/13 09:07:22 UTC
[PR] [DOXIA-760] Clarify table justification semantics and introduce new [maven-doxia]
kwin opened a new pull request, #248:
URL: https://github.com/apache/maven-doxia/pull/248
"JUSTIFY_DEFAULT" alignment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DOXIA-760] Clarify table justification semantics and introduce new [maven-doxia]
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on code in PR #248:
URL: https://github.com/apache/maven-doxia/pull/248#discussion_r1845558823
##########
doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/Xhtml5BaseSink.java:
##########
@@ -1112,6 +1109,24 @@ && getCellJustif() != null) {
}
}
+ private static String getStyleForTableJustification(int justification) {
Review Comment:
The constant defining the justification are only referring to tables according to their comments. Also nowhere else there is a Sink API taking into for justification…
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DOXIA-760] Clarify table justification semantics and introduce new [maven-doxia]
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on code in PR #248:
URL: https://github.com/apache/maven-doxia/pull/248#discussion_r1845566227
##########
doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/Xhtml5BaseSink.java:
##########
@@ -1112,6 +1109,24 @@ && getCellJustif() != null) {
}
}
+ private static String getStyleForTableJustification(int justification) {
Review Comment:
Right
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DOXIA-760] Clarify table justification semantics and introduce new [maven-doxia]
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on code in PR #248:
URL: https://github.com/apache/maven-doxia/pull/248#discussion_r1845556521
##########
doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/Xhtml5BaseSink.java:
##########
@@ -1112,6 +1109,24 @@ && getCellJustif() != null) {
}
}
+ private static String getStyleForTableJustification(int justification) {
Review Comment:
The actual code isn't just necessarify for tables only, it could apply everywhere logically, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DOXIA-760] Clarify table justification semantics and introduce new [maven-doxia]
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin merged PR #248:
URL: https://github.com/apache/maven-doxia/pull/248
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DOXIA-760] Clarify table justification semantics and introduce new [maven-doxia]
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on code in PR #248:
URL: https://github.com/apache/maven-doxia/pull/248#discussion_r1845558823
##########
doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/Xhtml5BaseSink.java:
##########
@@ -1112,6 +1109,24 @@ && getCellJustif() != null) {
}
}
+ private static String getStyleForTableJustification(int justification) {
Review Comment:
The constant defining the justification are only referring to tables according to their comments. Also nowhere else there is a Sink API taking integers for justification…
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org