You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/09/08 10:11:27 UTC
[GitHub] [spark] maropu opened a new pull request #29680: [SPARK-32638][SQL][3.0] Corrects references when adding aliases in WidenSetOperationTypes
maropu opened a new pull request #29680:
URL: https://github.com/apache/spark/pull/29680
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR intends to fix a bug where references can be missing when adding aliases to widen data types in `WidenSetOperationTypes`. For example,
```
CREATE OR REPLACE TEMPORARY VIEW t3 AS VALUES (decimal(1)) tbl(v);
SELECT t.v FROM (
SELECT v FROM t3
UNION ALL
SELECT v + v AS v FROM t3
) t;
org.apache.spark.sql.AnalysisException: Resolved attribute(s) v#1 missing from v#3 in operator !Project [v#1]. Attribute(s) with the same name appear in the operation: v. Please check if the right attribute(s) are used.;;
!Project [v#1] <------ the reference got missing
+- SubqueryAlias t
+- Union
:- Project [cast(v#1 as decimal(11,0)) AS v#3]
: +- Project [v#1]
: +- SubqueryAlias t3
: +- SubqueryAlias tbl
: +- LocalRelation [v#1]
+- Project [v#2]
+- Project [CheckOverflow((promote_precision(cast(v#1 as decimal(11,0))) + promote_precision(cast(v#1 as decimal(11,0)))), DecimalType(11,0), true) AS v#2]
+- SubqueryAlias t3
+- SubqueryAlias tbl
+- LocalRelation [v#1]
```
In the case, `WidenSetOperationTypes` added the alias `cast(v#1 as decimal(11,0)) AS v#3`, then the reference in the top `Project` got missing. This PR correct the reference (`exprId` and widen `dataType`) after adding aliases in the rule.
This backport for 3.0 comes from https://github.com/apache/spark/pull/29485.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
bugfixes
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Added unit tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29680: [SPARK-32638][SQL][3.0] Corrects references when adding aliases in WidenSetOperationTypes
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29680:
URL: https://github.com/apache/spark/pull/29680#issuecomment-688814443
**[Test build #128404 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128404/testReport)** for PR 29680 at commit [`f87c198`](https://github.com/apache/spark/commit/f87c198b92c36a007ef5383527c4a25f7bca71a9).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #29680: [SPARK-32638][SQL][3.0] Corrects references when adding aliases in WidenSetOperationTypes
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #29680:
URL: https://github.com/apache/spark/pull/29680#issuecomment-688811417
shall we include the followup https://github.com/apache/spark/pull/29643 in this PR as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29680: [SPARK-32638][SQL][3.0] Corrects references when adding aliases in WidenSetOperationTypes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29680:
URL: https://github.com/apache/spark/pull/29680#issuecomment-689037971
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/128404/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29680: [SPARK-32638][SQL][3.0] Corrects references when adding aliases in WidenSetOperationTypes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29680:
URL: https://github.com/apache/spark/pull/29680#issuecomment-689037961
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29680: [SPARK-32638][SQL][3.0] Corrects references when adding aliases in WidenSetOperationTypes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29680:
URL: https://github.com/apache/spark/pull/29680#issuecomment-688770337
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29680: [SPARK-32638][SQL][3.0] Corrects references when adding aliases in WidenSetOperationTypes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29680:
URL: https://github.com/apache/spark/pull/29680#issuecomment-689026823
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29680: [SPARK-32638][SQL][3.0] Corrects references when adding aliases in WidenSetOperationTypes
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29680:
URL: https://github.com/apache/spark/pull/29680#issuecomment-689025202
**[Test build #128400 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128400/testReport)** for PR 29680 at commit [`ec03233`](https://github.com/apache/spark/commit/ec0323304220e65c82661d946f7554503d502965).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29680: [SPARK-32638][SQL][3.0] Corrects references when adding aliases in WidenSetOperationTypes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29680:
URL: https://github.com/apache/spark/pull/29680#issuecomment-689026823
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu edited a comment on pull request #29680: [SPARK-32638][SQL][3.0] Corrects references when adding aliases in WidenSetOperationTypes
Posted by GitBox <gi...@apache.org>.
maropu edited a comment on pull request #29680:
URL: https://github.com/apache/spark/pull/29680#issuecomment-688770109
~After this merged, https://github.com/apache/spark/pull/29643 should be backported, too, for fixing implicit bugs in `Analyzer`rewritePlan`.~
This PR includes the fix of #29643, too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #29680: [SPARK-32638][SQL][3.0] Corrects references when adding aliases in WidenSetOperationTypes
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #29680:
URL: https://github.com/apache/spark/pull/29680#issuecomment-688811753
okay.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29680: [SPARK-32638][SQL][3.0] Corrects references when adding aliases in WidenSetOperationTypes
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29680:
URL: https://github.com/apache/spark/pull/29680#issuecomment-688814443
**[Test build #128404 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128404/testReport)** for PR 29680 at commit [`f87c198`](https://github.com/apache/spark/commit/f87c198b92c36a007ef5383527c4a25f7bca71a9).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29680: [SPARK-32638][SQL][3.0] Corrects references when adding aliases in WidenSetOperationTypes
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29680:
URL: https://github.com/apache/spark/pull/29680#issuecomment-689036859
**[Test build #128404 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128404/testReport)** for PR 29680 at commit [`f87c198`](https://github.com/apache/spark/commit/f87c198b92c36a007ef5383527c4a25f7bca71a9).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29680: [SPARK-32638][SQL][3.0] Corrects references when adding aliases in WidenSetOperationTypes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29680:
URL: https://github.com/apache/spark/pull/29680#issuecomment-689037961
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29680: [SPARK-32638][SQL][3.0] Corrects references when adding aliases in WidenSetOperationTypes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29680:
URL: https://github.com/apache/spark/pull/29680#issuecomment-688814829
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #29680: [SPARK-32638][SQL][3.0] Corrects references when adding aliases in WidenSetOperationTypes
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #29680:
URL: https://github.com/apache/spark/pull/29680#issuecomment-688770109
After this merged, https://github.com/apache/spark/pull/29643 should be backported, too, for fixing implicit bugs in `Analyzer`rewritePlan`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29680: [SPARK-32638][SQL][3.0] Corrects references when adding aliases in WidenSetOperationTypes
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29680:
URL: https://github.com/apache/spark/pull/29680#issuecomment-688769626
**[Test build #128400 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128400/testReport)** for PR 29680 at commit [`ec03233`](https://github.com/apache/spark/commit/ec0323304220e65c82661d946f7554503d502965).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #29680: [SPARK-32638][SQL][3.0] Corrects references when adding aliases in WidenSetOperationTypes
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #29680:
URL: https://github.com/apache/spark/pull/29680#issuecomment-689186970
GA passed and the last test failure is not related to this PR, so merged to branch-3.0. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29680: [SPARK-32638][SQL][3.0] Corrects references when adding aliases in WidenSetOperationTypes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29680:
URL: https://github.com/apache/spark/pull/29680#issuecomment-688770337
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29680: [SPARK-32638][SQL][3.0] Corrects references when adding aliases in WidenSetOperationTypes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29680:
URL: https://github.com/apache/spark/pull/29680#issuecomment-688814829
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu closed pull request #29680: [SPARK-32638][SQL][3.0] Corrects references when adding aliases in WidenSetOperationTypes
Posted by GitBox <gi...@apache.org>.
maropu closed pull request #29680:
URL: https://github.com/apache/spark/pull/29680
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29680: [SPARK-32638][SQL][3.0] Corrects references when adding aliases in WidenSetOperationTypes
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29680:
URL: https://github.com/apache/spark/pull/29680#issuecomment-688769626
**[Test build #128400 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128400/testReport)** for PR 29680 at commit [`ec03233`](https://github.com/apache/spark/commit/ec0323304220e65c82661d946f7554503d502965).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org