You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Wang Xixu (Code Review)" <ge...@cloudera.org> on 2023/02/09 11:16:06 UTC

[kudu-CR] [Client] Add query id to trace the whole query process

Hello Mahesh Reddy, Tidy Bot, Jian Zhang, Yuqi Du, Alexey Serbin, Yingchun Lai, Yifan Zhang, Kudu Jenkins, Abhishek Chennaka, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18846

to look at the new patch set (#29).

Change subject: [Client] Add query id to trace the whole query process
......................................................................

[Client] Add query id to trace the whole query process

In Impala, a sql will be translated into a query plan. The
query plan contains multiple execution units and will be
executed distributly in different hosts of a cluster. There
exists an unique query id to trace the execution process of
every execution unit. It is useful to analyze which step get
stucked or failed, when a slow or failed query happened.
Query id can associate all log records in different hosts,
which belongs to one query.

Kudu is the scan node of a query plan, when defines Kudu table
as external table in Impala. And a scanning on a table will be
splited into multiple scanning on different tablets. The scanner
id is used to trace a scanning on a tablet.

But there is a gap between Impala and Kudu. We can't trace the
whole scanning process in Kudu of a query from Impala. There is
not unique id to associate the execution of all scanners in Kudu.

Therefore, this patch post query id from Impala to Kudu, and
binding with scanner id. Then we can trace a query from Impala
to Kudu for troubleshooting and debugging.

Change-Id: I9dbae801596726fec1c85ee547128da3179345d9
---
M src/kudu/client/client-test.cc
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/client.proto
M src/kudu/client/scan_token-internal.cc
M src/kudu/client/scan_token-internal.h
M src/kudu/client/scan_token-test.cc
M src/kudu/client/scanner-internal.cc
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/tserver.proto
11 files changed, 207 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/46/18846/29
-- 
To view, visit http://gerrit.cloudera.org:8080/18846
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9dbae801596726fec1c85ee547128da3179345d9
Gerrit-Change-Number: 18846
Gerrit-PatchSet: 29
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Jian Zhang <zj...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>