You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by se...@apache.org on 2010/05/05 12:59:58 UTC

svn commit: r941242 - in /commons/proper/compress/trunk: RELEASE-NOTES.txt src/changes/changes.xml

Author: sebb
Date: Wed May  5 10:59:58 2010
New Revision: 941242

URL: http://svn.apache.org/viewvc?rev=941242&view=rev
Log:
Recent changes

Modified:
    commons/proper/compress/trunk/RELEASE-NOTES.txt
    commons/proper/compress/trunk/src/changes/changes.xml

Modified: commons/proper/compress/trunk/RELEASE-NOTES.txt
URL: http://svn.apache.org/viewvc/commons/proper/compress/trunk/RELEASE-NOTES.txt?rev=941242&r1=941241&r2=941242&view=diff
==============================================================================
--- commons/proper/compress/trunk/RELEASE-NOTES.txt (original)
+++ commons/proper/compress/trunk/RELEASE-NOTES.txt Wed May  5 10:59:58 2010
@@ -73,6 +73,12 @@ o The ar and cpio streams now properly r
 o COMPRESS-81:  TarOutputStream can leave garbage at the end of the archive 
 
 Changes:
+o COMPRESS-106:  Remove unnecessary method 
+       ZipFile.OFFSET_COMPARATOR.new Comparator() {...}.equals(Object o) 
+o COMPRESS-105:  Document that the name of an ZipArchiveEntry determines whether
+       an entry is considered a directory or not. 
+       If you don't use the constructor with the File argument the entry's
+        name must end in a "/" in order for the entry to be known as a directory. 
 o COMPRESS-79:  Move DOS/Java time conversions into Zip utility class. 
 
  

Modified: commons/proper/compress/trunk/src/changes/changes.xml
URL: http://svn.apache.org/viewvc/commons/proper/compress/trunk/src/changes/changes.xml?rev=941242&r1=941241&r2=941242&view=diff
==============================================================================
--- commons/proper/compress/trunk/src/changes/changes.xml (original)
+++ commons/proper/compress/trunk/src/changes/changes.xml Wed May  5 10:59:58 2010
@@ -46,6 +46,16 @@ The <action> type attribute can be add,u
   </properties>
   <body>
     <release version="1.1" date="as in SVN" description="Release 1.1">
+      <action type="update" date="2010-04-22" issue="COMPRESS-106">
+       Remove unnecessary method 
+       ZipFile.OFFSET_COMPARATOR.new Comparator() {...}.equals(Object o) 
+      </action>
+      <action type="update" date="2010-04-19" issue="COMPRESS-105">
+       Document that the name of an ZipArchiveEntry determines whether
+       an entry is considered a directory or not. 
+       If you don't use the constructor with the File argument the entry's
+        name must end in a "/" in order for the entry to be known as a directory.
+      </action>
       <action type="add" date="2010-03-19" issue="COMPRESS-103">
         ZipArchiveInputStream can optionally extract data that used
         the STORED compression method and a data descriptor.



Re: svn commit: r941242 - in /commons/proper/compress/trunk: RELEASE-NOTES.txt src/changes/changes.xml

Posted by Stefan Bodewig <bo...@apache.org>.
On 2010-05-05, sebb <se...@gmail.com> wrote:

> That part of the change has been reverted.

Thank you

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: svn commit: r941242 - in /commons/proper/compress/trunk: RELEASE-NOTES.txt src/changes/changes.xml

Posted by sebb <se...@gmail.com>.
On 05/05/2010, Christian Grobmeier <gr...@gmail.com> wrote:
> >>> o COMPRESS-106:  Remove unnecessary method
>  >>>       ZipFile.OFFSET_COMPARATOR.new Comparator() {...}.equals(Object o)
>  >
>  > That method never existed in 1.0, it was added and later removed between
>  > 1.0 and now.  I may have a different idea about what constitutes
>  > RELEASE-NOTES but is it really worth mentioning?  Aren't we even
>  > confusing our users more than helping them this way?

Sorry, did not realised it was a new method - I just reconciled the
1.1 Fix JIRAs with changes.xml, and did not check when it was added.

That part of the change has been reverted.

>
> I think like you
>
>
>  Christian
>
>
>  ---------------------------------------------------------------------
>  To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>  For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: svn commit: r941242 - in /commons/proper/compress/trunk: RELEASE-NOTES.txt src/changes/changes.xml

Posted by Christian Grobmeier <gr...@gmail.com>.
>>> o COMPRESS-106:  Remove unnecessary method
>>>       ZipFile.OFFSET_COMPARATOR.new Comparator() {...}.equals(Object o)
>
> That method never existed in 1.0, it was added and later removed between
> 1.0 and now.  I may have a different idea about what constitutes
> RELEASE-NOTES but is it really worth mentioning?  Aren't we even
> confusing our users more than helping them this way?

I think like you

Christian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: svn commit: r941242 - in /commons/proper/compress/trunk: RELEASE-NOTES.txt src/changes/changes.xml

Posted by Stefan Bodewig <bo...@apache.org>.
On 2010-05-05, <se...@apache.org> wrote:

>  Changes:
>> o COMPRESS-106:  Remove unnecessary method
>>       ZipFile.OFFSET_COMPARATOR.new Comparator() {...}.equals(Object o)

That method never existed in 1.0, it was added and later removed between
1.0 and now.  I may have a different idea about what constitutes
RELEASE-NOTES but is it really worth mentioning?  Aren't we even
confusing our users more than helping them this way?

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org