You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org> on 2022/06/01 16:11:57 UTC

[Impala-ASF-CR] IMPALA-11302, IMPALA-11303: Fix error handling of external Iceberg tables

Hello Tamas Mate, Gergely Fürnstáhl, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18563

to look at the new patch set (#3).

Change subject: IMPALA-11302, IMPALA-11303: Fix error handling of external Iceberg tables
......................................................................

IMPALA-11302, IMPALA-11303: Fix error handling of external Iceberg tables

IMPALA-11302: Improve error message for CREATE EXTERNAL TABLE iceberg
command

The error message complained about failed table loading. The new
error message is more precise, and also notifies the user to use
plain 'CREATE TABLE' for creating new Iceberg tables.

IMPALA-11303: Exception is not raised for Iceberg DDL that misses
LOCATION clause

We returned the error in the result summary. Instead of that now
we raise an error, and also notify  the user about how to create
new Iceberg tables.

Testing:
 * e2e tests

Change-Id: I659115cc97a1a00e1ddf3fbb7dbe1f286bf1edcf
---
M fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-create.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test
3 files changed, 44 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/63/18563/3
-- 
To view, visit http://gerrit.cloudera.org:8080/18563
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I659115cc97a1a00e1ddf3fbb7dbe1f286bf1edcf
Gerrit-Change-Number: 18563
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>