[GitHub] nickva opened a new pull request #828: Fix replication ID parsing in URL paths

[gi...@git.apache.org]

nickva opened a new pull request #828: Fix replication ID parsing in URL paths
URL: https://github.com/apache/couchdb/pull/828
 
 
   Previously users had to URL encode replication IDs when using
   `_scheduler/jobs/<job_id>` endpoint because Mochiweb incorrectly decoded the
   `+` character from URL path. So users were forced to encode so that the
   replicator would correctly receive a `+` after Mochiweb parsing.
   
   `+` is decoded as ` ` (space) probably because in query strings that's a valid
   application/x-www-form-urlencoded encoding, but that decoding is not meant for
   decoding URL paths, only query strings.
   
   Notice RFC 3986 https://tools.ietf.org/html/rfc3986#section-2.2
   
   `+` is a `sub-delim` (term from RFC)  and in the path component it can be used
   unquoted as a delimiter.
   
   https://tools.ietf.org/html/rfc3986#section-3.3
   
   Indeed, the replication ID is a compound ID and `+` is a valid delimiter
   which separates the base part from the extensions.
   
   For more details see also:
   
   https://github.com/perwendel/spark/issues/490
   
   https://www.w3.org/TR/html401/interact/forms.html#h-17.13.4.1
   
   Fixes #825
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services