You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2019/11/19 19:32:39 UTC
[GitHub] [hbase] joshelser commented on a change in pull request #834:
HBASE-23237 Negative sign in requestsPerSecond
joshelser commented on a change in pull request #834: HBASE-23237 Negative sign in requestsPerSecond
URL: https://github.com/apache/hbase/pull/834#discussion_r348122519
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapperImpl.java
##########
@@ -709,13 +710,50 @@ synchronized public void run() {
long tempMobScanCellsSize = 0;
long tempBlockedRequestsCount = 0;
int regionCount = 0;
+
+ long tempReadRequestsCount = 0;
+ long tempWriteRequestsCount = 0;
+ long currentReadRequestsCount = 0;
+ long currentWriteRequestsCount = 0;
+ long lastReadRequestsCount = 0;
+ long lastWriteRequestsCount = 0;
+ long readRequestsDelta = 0;
+ long writeRequestsDelta = 0;
+ long totalReadRequestsDelta = 0;
+ long totalWriteRequestsDelta = 0;
+ String encodedRegionName;
+ ArrayList<String> hregions = new ArrayList<String>();
Review comment:
Should be a HashSet to avoid paying a linear cost on `List.contains(Object)` down below.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services