[GitHub] [beam] nancyxu123 commented on a diff in pull request #23997: Add GetSize implementation for DetectNewPartitions SDF

[GitBox <gi...@apache.org>]

nancyxu123 commented on code in PR #23997:
URL: https://github.com/apache/beam/pull/23997#discussion_r1019760093


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/model/PartitionMetadata.java:
##########
@@ -188,6 +217,20 @@ public Timestamp getCreatedAt() {
     return finishedAt;
   }
 
+  /**
+   * Estimates the size in bytes of a partition when encoded using Avro.
+   *
+   * @return the number of bytes of the encoded object
+   */
+  public long bytesSize() {

Review Comment:
   Does this mean we have to encode the Data change record everytime we call this function? Would that be expensive?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org