You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Abhay Kulkarni <ak...@hortonworks.com> on 2019/08/22 17:06:58 UTC
Review Request 71352: RANGER-2547: Good coding practices: minimize
use of static/unnecessary class members
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71352/
-----------------------------------------------------------
Review request for ranger and Madhan Neethiraj.
Bugs: RANGER-2547
https://issues.apache.org/jira/browse/RANGER-2547
Repository: ranger
Description
-------
Some of the core Ranger and Authorizer classes contain static or unnecessary class members. Good coding practices recommend minimizing use of such members.
Diffs
-----
agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java fbf0360d7
agents-common/src/main/java/org/apache/ranger/plugin/service/RangerAuthContext.java 02f343196
agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java 8d89a187c
hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java bb015c595
Diff: https://reviews.apache.org/r/71352/diff/1/
Testing
-------
Built clean and verified that all unit tests pass.
Thanks,
Abhay Kulkarni
Re: Review Request 71352: RANGER-2547: Good coding practices:
minimize use of static/unnecessary class members
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71352/#review217633
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Aug. 24, 2019, 12:35 a.m., Abhay Kulkarni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71352/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2019, 12:35 a.m.)
>
>
> Review request for ranger and Madhan Neethiraj.
>
>
> Bugs: RANGER-2547
> https://issues.apache.org/jira/browse/RANGER-2547
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Some of the core Ranger and Authorizer classes contain static or unnecessary class members. Good coding practices recommend minimizing use of such members.
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerAbstractContextEnricher.java 0712bfcf7
> agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java fbf0360d7
> agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPluginContext.java e596b2af4
> agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java daa62f408
> agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyRepository.java 3a954f341
> agents-common/src/main/java/org/apache/ranger/plugin/service/RangerAuthContext.java 02f343196
> agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java 8d89a187c
> agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestRangerAuthContext.java 49dba884c
> hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java bb015c595
>
>
> Diff: https://reviews.apache.org/r/71352/diff/4/
>
>
> Testing
> -------
>
> Built clean and verified that all unit tests pass.
>
>
> Thanks,
>
> Abhay Kulkarni
>
>
Re: Review Request 71352: RANGER-2547: Good coding practices:
minimize use of static/unnecessary class members
Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71352/
-----------------------------------------------------------
(Updated Aug. 24, 2019, 12:35 a.m.)
Review request for ranger and Madhan Neethiraj.
Changes
-------
Updated AbstractContextEnricher class to accept RangerAuthContext
Bugs: RANGER-2547
https://issues.apache.org/jira/browse/RANGER-2547
Repository: ranger
Description
-------
Some of the core Ranger and Authorizer classes contain static or unnecessary class members. Good coding practices recommend minimizing use of such members.
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerAbstractContextEnricher.java 0712bfcf7
agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java fbf0360d7
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPluginContext.java e596b2af4
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java daa62f408
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyRepository.java 3a954f341
agents-common/src/main/java/org/apache/ranger/plugin/service/RangerAuthContext.java 02f343196
agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java 8d89a187c
agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestRangerAuthContext.java 49dba884c
hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java bb015c595
Diff: https://reviews.apache.org/r/71352/diff/4/
Changes: https://reviews.apache.org/r/71352/diff/3-4/
Testing
-------
Built clean and verified that all unit tests pass.
Thanks,
Abhay Kulkarni
Re: Review Request 71352: RANGER-2547: Good coding practices:
minimize use of static/unnecessary class members
Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71352/
-----------------------------------------------------------
(Updated Aug. 23, 2019, 4:55 p.m.)
Review request for ranger and Madhan Neethiraj.
Bugs: RANGER-2547
https://issues.apache.org/jira/browse/RANGER-2547
Repository: ranger
Description
-------
Some of the core Ranger and Authorizer classes contain static or unnecessary class members. Good coding practices recommend minimizing use of such members.
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java fbf0360d7
agents-common/src/main/java/org/apache/ranger/plugin/service/RangerAuthContext.java 02f343196
agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java 8d89a187c
hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java bb015c595
Diff: https://reviews.apache.org/r/71352/diff/3/
Changes: https://reviews.apache.org/r/71352/diff/2-3/
Testing
-------
Built clean and verified that all unit tests pass.
Thanks,
Abhay Kulkarni
Re: Review Request 71352: RANGER-2547: Good coding practices:
minimize use of static/unnecessary class members
Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71352/
-----------------------------------------------------------
(Updated Aug. 22, 2019, 11:55 p.m.)
Review request for ranger and Madhan Neethiraj.
Bugs: RANGER-2547
https://issues.apache.org/jira/browse/RANGER-2547
Repository: ranger
Description
-------
Some of the core Ranger and Authorizer classes contain static or unnecessary class members. Good coding practices recommend minimizing use of such members.
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java fbf0360d7
agents-common/src/main/java/org/apache/ranger/plugin/service/RangerAuthContext.java 02f343196
agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java 8d89a187c
hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java bb015c595
Diff: https://reviews.apache.org/r/71352/diff/2/
Changes: https://reviews.apache.org/r/71352/diff/1-2/
Testing
-------
Built clean and verified that all unit tests pass.
Thanks,
Abhay Kulkarni