You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/03/22 08:39:01 UTC
[GitHub] [skywalking-java] PepoRobert opened a new pull request #126: [Bug] SkyWalking Java agent okhttp plugin Wrong url used to create span #8695
PepoRobert opened a new pull request #126:
URL: https://github.com/apache/skywalking-java/pull/126
<!--
⚠️ Please make sure to read this template first, pull requests that don't accord with this template
maybe closed without notice.
Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>.
Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
-->
<!-- ==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👇 ====
### Fix <bug description or the bug issue number or bug issue link>
- [ ] Add a unit test to verify that the fix works.
- [ ] Explain briefly why the bug exists and how to fix it.
==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👆 ==== -->
<!-- ==== 🔌 Remove this line WHEN AND ONLY WHEN you're adding a new plugin, follow the checklist 👇 ====
### Add an agent plugin to support <framework name>
- [ ] Add a test case for the new plugin, refer to [the doc](https://github.com/apache/skywalking-java/blob/main/docs/en/setup/service-agent/java-agent/Plugin-test.md)
- [ ] Add a component id in [the component-libraries.yml](https://github.com/apache/skywalking/blob/master/oap-server/server-starter/src/main/resources/component-libraries.yml)
- [ ] Add a logo in [the UI repo](https://github.com/apache/skywalking-rocketbot-ui/tree/master/src/views/components/topology/assets)
==== 🔌 Remove this line WHEN AND ONLY WHEN you're adding a new plugin, follow the checklist 👆 ==== -->
<!-- ==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👇 ====
### Improve the performance of <class or module or ...>
- [ ] Add a benchmark for the improvement, refer to [the existing ones](https://github.com/apache/skywalking-java/blob/main/apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java)
- [ ] The benchmark result.
```text
<Paste the benchmark results here>
```
- [ ] Links/URLs to the theory proof or discussion articles/blogs. <links/URLs here>
==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👆 ==== -->
<!-- ==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👇 ====
### <Feature description>
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [ ] Update the documentation to include this new feature.
- [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
- [ ] If it's UI related, attach the screenshots below.
==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👆 ==== -->
- [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<issue number>.
- [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking-java/blob/main/CHANGES.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #126: [Bug] SkyWalking Java agent okhttp plugin Wrong url used to create span #8695
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #126:
URL: https://github.com/apache/skywalking-java/pull/126#issuecomment-1074973197
Notice, you break the existing `Test / okhttp-scenario (pull_request)` test. Have you read the plugin test doc? It is better you could verify that case locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] PepoRobert commented on pull request #126: [Bug] SkyWalking Java agent okhttp plugin Wrong url used to create span #8695
Posted by GitBox <gi...@apache.org>.
PepoRobert commented on pull request #126:
URL: https://github.com/apache/skywalking-java/pull/126#issuecomment-1074942705
> It is better if you have verified cases in https://github.com/apache/skywalking-java/tree/main/test/plugin/scenarios/okhttp-scenario. And add this unsupported scenario into that cases with new expected spans.
<img width="1121" alt="image" src="https://user-images.githubusercontent.com/27007840/159450275-3e295e7f-6626-4425-bf29-915cafc5a862.png">
This is the sequence diagram of the synchronous call, with the new interceptor in red. You can see that the original interceptor was intercepted twice
这是同步调用的时序图 ,红色部分为这次新增的拦截器 .可以看到原先的是拦截了两次。
Using the chain of responsibility pattern to process requests and allowing the user to customize interceptors allowing the user to rewrite requests interceptors fall into two further categories
okhttp使用责任链模式处理请求。并且允许用户自定义拦截器。允许用户重写重新请求。拦截器又被分为两类。[官方说明](https://square.github.io/okhttp/features/interceptors/)
I think agent interception should be at least after the user can customize the application of interceptors
我认为agent拦截至少应该在用户可以自定义的应用拦截器之后
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] PepoRobert closed pull request #126: [Bug] SkyWalking Java agent okhttp plugin Wrong url used to create span #8695
Posted by GitBox <gi...@apache.org>.
PepoRobert closed pull request #126:
URL: https://github.com/apache/skywalking-java/pull/126
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #126: [Bug] SkyWalking Java agent okhttp plugin Wrong url used to create span #8695
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #126:
URL: https://github.com/apache/skywalking-java/pull/126#issuecomment-1074927978
It is better if you have verified cases in https://github.com/apache/skywalking-java/tree/main/test/plugin/scenarios/okhttp-scenario. And add this unsupported scenario into that cases with new expected spans.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #126: [Bug] SkyWalking Java agent okhttp plugin Wrong url used to create span #8695
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #126:
URL: https://github.com/apache/skywalking-java/pull/126#issuecomment-1074902202
Please fix CI and make sure the plugin tests could verify this case. Also, you should add a full description about what is bug scenario, and why this could fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org