You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@zookeeper.apache.org by "IcySanwitch (Jira)" <ji...@apache.org> on 2021/03/24 02:34:00 UTC

[jira] [Updated] (ZOOKEEPER-4258) Improve stream use in QuorumCnxManager

     [ https://issues.apache.org/jira/browse/ZOOKEEPER-4258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

IcySanwitch updated ZOOKEEPER-4258:
-----------------------------------
    Attachment:     (was: 1.patch)

> Improve stream use in QuorumCnxManager
> --------------------------------------
>
>                 Key: ZOOKEEPER-4258
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4258
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: quorum, server
>    Affects Versions: 3.6.2
>            Reporter: IcySanwitch
>            Priority: Minor
>
> I find three issues about stream object use in QuorumCnxManager. They are not bugs but may belong to bad practices.
> * Mismatch stream creation in RecvWorker and SendWorker.
> DataInputStream in RecvWorker is created by 
> {code:java}
> new DataInputStream(new BufferedInputStream(sock.getInputStream()))
> {code} While DataOutputStream in SendWorker is created by 
> {code:java}
> new DataOutputStream(sock.getOutputStream)
> {code}
> * Stream instances are never closed in RecvWorker and SendWorker.
> * RecvWorker and SendWorker are initialized before removing old ones.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)