You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2022/05/11 14:27:56 UTC
[Bug 66060] New: Registry gives inaccurate log message saying "Creating MBeanServer ... " after already created the MBeanServer
https://bz.apache.org/bugzilla/show_bug.cgi?id=66060
Bug ID: 66060
Summary: Registry gives inaccurate log message saying "Creating
MBeanServer ... " after already created the
MBeanServer
Product: Tomcat 10
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: trivial
Priority: P2
Component: Util
Assignee: dev@tomcat.apache.org
Reporter: dingzishuo@gmail.com
Target Milestone: ------
Hello,
While viewing the https://issues.apache.org/jira/browse/MAPREDUCE-4262, I found
that the logging statements might give inaccurate messages.
I also found that the in the line 469 of the file Registry.java, the log
messages says "Creating MBeanServer". However, the MBean server creation should
already completed in previous code (line 467).
Would it be better if we change the verb "Creating" to "Created" to indicate
the action is completed? Or can we move the logging statement to the line
before 467? Since when there was an exception in line 467, the logging message
would not be printed, which may be not good for debugging.
The detailed url is:
https://github.com/apache/tomcat/blob/0f2e084d1583cfa4c00cec1958ec30113fb4f41e/java/org/apache/tomcat/util/modeler/Registry.java#L469
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 66060] Registry gives inaccurate log message saying "Creating MBeanServer ... " after already created the MBeanServer
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66060
Mark Thomas <ma...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEW |RESOLVED
--- Comment #2 from Mark Thomas <ma...@apache.org> ---
Thanks for the PR.
Fixed in:
- 10.1.x for 10.1.0-M16 onwards
- 10.0.x for 10.0.22 onwards
- 9.0.x for 9.0.64 onwards
- 8.5.x for 8.5.80 onwards
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 66060] Registry gives inaccurate log message saying "Creating MBeanServer ... " after already created the MBeanServer
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66060
--- Comment #1 from Ding Ding <di...@gmail.com> ---
I also found another same issue: the in the line 384 of the file
AbstractProtocol.java, the log messages says "Added processor ...". However,
the exact adding action (source code) is placed after the logging statement,
which means that the add is still not completed.
Would it be better if we change the verb "added" to "adding" to indicate the
action is in progress? Or can we move the logging statement to the end of the
method?
The url of file:
https://github.com/apache/tomcat/blob/0f2e084d1583cfa4c00cec1958ec30113fb4f41e/java/org/apache/coyote/AbstractProtocol.java#L384
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org