You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "robin977 (via GitHub)" <gi...@apache.org> on 2023/03/20 12:42:15 UTC
[GitHub] [dubbo] robin977 opened a new pull request, #11873: fix: dubbo's thread pool is used when the triple protocol is invoked (#11867)
robin977 opened a new pull request, #11873:
URL: https://github.com/apache/dubbo/pull/11873
fix: dubbo's thread pool is used when the triple protocol is invoked (#11867)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] robin977 closed pull request #11873: fix: dubbo's thread pool is used when the triple protocol is invoked (#11867)
Posted by "robin977 (via GitHub)" <gi...@apache.org>.
robin977 closed pull request #11873: fix: dubbo's thread pool is used when the triple protocol is invoked (#11867)
URL: https://github.com/apache/dubbo/pull/11873
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] songxiaosheng commented on a diff in pull request #11873: fix: dubbo's thread pool is used when the triple protocol is invoked (#11867)
Posted by "songxiaosheng (via GitHub)" <gi...@apache.org>.
songxiaosheng commented on code in PR #11873:
URL: https://github.com/apache/dubbo/pull/11873#discussion_r1143260518
##########
dubbo-metrics/dubbo-metrics-prometheus/src/test/java/org/apache/dubbo/metrics/prometheus/PrometheusMetricesThreadPoolTest.java:
##########
@@ -0,0 +1,143 @@
+package org.apache.dubbo.metrics.prometheus;
Review Comment:
please add apache licence
##########
dubbo-metrics/dubbo-metrics-prometheus/src/test/java/org/apache/dubbo/metrics/prometheus/PrometheusMetricesThreadPoolTest.java:
##########
@@ -0,0 +1,143 @@
+package org.apache.dubbo.metrics.prometheus;
+import com.sun.net.httpserver.HttpServer;
+import org.apache.dubbo.config.*;
Review Comment:
please remove *
##########
dubbo-metrics/dubbo-metrics-api/src/main/java/org/apache/dubbo/metrics/model/ThreadPoolRejectMetric.java:
##########
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dubbo.metrics.model;
+
+import org.apache.dubbo.common.utils.ConfigUtils;
+
+import java.util.HashMap;
+import java.util.Map;
+import java.util.Objects;
+import static org.apache.dubbo.common.constants.MetricsConstants.*;
Review Comment:
please remove *
##########
dubbo-metrics/dubbo-metrics-default/src/main/java/org/apache/dubbo/metrics/collector/sample/ThreadRejectMetricsCountSampler.java:
##########
@@ -0,0 +1,65 @@
+package org.apache.dubbo.metrics.collector.sample;
+
+import org.apache.dubbo.common.utils.ConcurrentHashSet;
+import org.apache.dubbo.metrics.collector.DefaultMetricsCollector;
+import org.apache.dubbo.metrics.model.*;
Review Comment:
please remove *
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] songxiaosheng commented on pull request #11873: fix: dubbo's thread pool is used when the triple protocol is invoked (#11867)
Posted by "songxiaosheng (via GitHub)" <gi...@apache.org>.
songxiaosheng commented on PR #11873:
URL: https://github.com/apache/dubbo/pull/11873#issuecomment-1481245170
please add apache licence header
<img width="849" alt="image" src="https://user-images.githubusercontent.com/81170548/227226140-ea7d6935-a47b-45e0-bb93-72d49f44de36.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] CrazyHZM commented on pull request #11873: fix: dubbo's thread pool is used when the triple protocol is invoked (#11867)
Posted by "CrazyHZM (via GitHub)" <gi...@apache.org>.
CrazyHZM commented on PR #11873:
URL: https://github.com/apache/dubbo/pull/11873#issuecomment-1479213435
@robin977
A PR commit with the relevant content of the description, and resubmit a PR commit to complete the observability part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] robin977 closed pull request #11873: fix: dubbo's thread pool is used when the triple protocol is invoked (#11867)
Posted by "robin977 (via GitHub)" <gi...@apache.org>.
robin977 closed pull request #11873: fix: dubbo's thread pool is used when the triple protocol is invoked (#11867)
URL: https://github.com/apache/dubbo/pull/11873
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org