You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "knight42 (via GitHub)" <gi...@apache.org> on 2023/03/28 08:43:37 UTC
[GitHub] [incubator-opendal] knight42 opened a new pull request, #1787: feat(oli): implement `oli cp -r`
knight42 opened a new pull request, #1787:
URL: https://github.com/apache/incubator-opendal/pull/1787
Fix #1731
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on a diff in pull request #1787: feat(oli): implement `oli cp -r`
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #1787:
URL: https://github.com/apache/incubator-opendal/pull/1787#discussion_r1150243039
##########
core/src/types/operator/operator.rs:
##########
@@ -831,7 +831,7 @@ impl Operator {
Ok(Lister::new(pager))
}
- /// List dir in flat way.
+ /// Iterate through all files inside a directory bottom-up.
Review Comment:
This comment is wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] knight42 commented on a diff in pull request #1787: feat(oli): implement `oli cp -r`
Posted by "knight42 (via GitHub)" <gi...@apache.org>.
knight42 commented on code in PR #1787:
URL: https://github.com/apache/incubator-opendal/pull/1787#discussion_r1150279470
##########
core/src/types/operator/operator.rs:
##########
@@ -831,7 +831,7 @@ impl Operator {
Ok(Lister::new(pager))
}
- /// List dir in flat way.
+ /// Iterate through all files inside a directory bottom-up.
Review Comment:
reverted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo merged pull request #1787: feat(oli): implement `oli cp -r`
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #1787:
URL: https://github.com/apache/incubator-opendal/pull/1787
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on a diff in pull request #1787: feat(oli): implement `oli cp -r`
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #1787:
URL: https://github.com/apache/incubator-opendal/pull/1787#discussion_r1150266642
##########
core/src/types/operator/operator.rs:
##########
@@ -831,7 +831,7 @@ impl Operator {
Ok(Lister::new(pager))
}
- /// List dir in flat way.
+ /// Iterate through all files inside a directory bottom-up.
Review Comment:
> What is the accurate description? `flat` seems obscure
I don't have any ideas yet, and this change is not relevant to this PR. Let's undo this modification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] knight42 commented on a diff in pull request #1787: feat(oli): implement `oli cp -r`
Posted by "knight42 (via GitHub)" <gi...@apache.org>.
knight42 commented on code in PR #1787:
URL: https://github.com/apache/incubator-opendal/pull/1787#discussion_r1150247977
##########
core/src/types/operator/operator.rs:
##########
@@ -831,7 +831,7 @@ impl Operator {
Ok(Lister::new(pager))
}
- /// List dir in flat way.
+ /// Iterate through all files inside a directory bottom-up.
Review Comment:
What is the accurate description? `flat` seems obscure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org