You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by oheger <gi...@git.apache.org> on 2015/06/11 21:45:11 UTC

[GitHub] commons-lang pull request: Implementations of the circuit breaker ...

GitHub user oheger opened a pull request:

    https://github.com/apache/commons-lang/pull/95

    Implementations of the circuit breaker pattern related to LANG-1085

    These are the results of Bruno's and my collaboration on a circuit breaker implementation. For further discussions refer to LANG-1085.
    
    commit 1b12db706b457408562a166c21bc6470a8064620
    Merge: edebd97 def7832
    Author: Oliver Heger <ol...@oliver-heger.de>
    Date:   Wed Jun 10 21:27:17 2015 +0200
    
        Merge pull request #1 from kinow/patch1
    
        This commit:
    
    commit def78320c5efcb734572c5b48623a952e3c94c75
    Author: Bruno P. Kinoshita <br...@yahoo.com.br>
    Date:   Wed Jun 10 22:57:33 2015 +1200
    
        This commit:
    
        * fixes JavaDocs warnings in Checkstyle
        * adds license headers
        * renames the MemoryCircuitBreaker to ThresholdCircuitBreaker
        * adds more tests to have a good coverage
    
    commit edebd970582ce2984258352c8482bcb51587f7d2
    Author: oheger <ol...@oliver-heger.de>
    Date:   Tue Jun 9 22:11:11 2015 +0200
    
        Documentation updates for EventCountCircuitBreaker.
    
    commit 3d8a4ff85a78173dd8f5437d9b4d931069128e20
    Author: oheger <ol...@oliver-heger.de>
    Date:   Tue Jun 9 21:55:02 2015 +0200
    
        Renamed TimedCircuitBreaker to EventCountCircuitBreaker.
    
        This name seems to be more appropriate as the main property of this circuit
        breaker implementation is that it counts specific events and changes its state
        when a certain threshold is reached.
    
    commit 0e4ce5a984ef699ddace61bbf430d695b011c6b5
    Author: oheger <ol...@oliver-heger.de>
    Date:   Tue Jun 9 21:51:22 2015 +0200
    
        Added documentation for CircuitBreaker interface.
    
    commit 0e6b22190ef1868655fec9b3814a2345ad206f76
    Author: oheger <ol...@oliver-heger.de>
    Date:   Mon Jun 8 22:27:05 2015 +0200
    
        Initial import of CircuitBreaker classes.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/oheger/commons-lang master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-lang/pull/95.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #95
    
----
commit 52ba83bba8938cbc71529dda22cffd08e45ce96a
Author: oheger <ol...@oliver-heger.de>
Date:   2015-06-11T19:39:40Z

    Squashed commit of the following:
    
    commit 1b12db706b457408562a166c21bc6470a8064620
    Merge: edebd97 def7832
    Author: Oliver Heger <ol...@oliver-heger.de>
    Date:   Wed Jun 10 21:27:17 2015 +0200
    
        Merge pull request #1 from kinow/patch1
    
        This commit:
    
    commit def78320c5efcb734572c5b48623a952e3c94c75
    Author: Bruno P. Kinoshita <br...@yahoo.com.br>
    Date:   Wed Jun 10 22:57:33 2015 +1200
    
        This commit:
    
        * fixes JavaDocs warnings in Checkstyle
        * adds license headers
        * renames the MemoryCircuitBreaker to ThresholdCircuitBreaker
        * adds more tests to have a good coverage
    
    commit edebd970582ce2984258352c8482bcb51587f7d2
    Author: oheger <ol...@oliver-heger.de>
    Date:   Tue Jun 9 22:11:11 2015 +0200
    
        Documentation updates for EventCountCircuitBreaker.
    
    commit 3d8a4ff85a78173dd8f5437d9b4d931069128e20
    Author: oheger <ol...@oliver-heger.de>
    Date:   Tue Jun 9 21:55:02 2015 +0200
    
        Renamed TimedCircuitBreaker to EventCountCircuitBreaker.
    
        This name seems to be more appropriate as the main property of this circuit
        breaker implementation is that it counts specific events and changes its state
        when a certain threshold is reached.
    
    commit 0e4ce5a984ef699ddace61bbf430d695b011c6b5
    Author: oheger <ol...@oliver-heger.de>
    Date:   Tue Jun 9 21:51:22 2015 +0200
    
        Added documentation for CircuitBreaker interface.
    
    commit 0e6b22190ef1868655fec9b3814a2345ad206f76
    Author: oheger <ol...@oliver-heger.de>
    Date:   Mon Jun 8 22:27:05 2015 +0200
    
        Initial import of CircuitBreaker classes.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: Implementations of the circuit breaker ...

Posted by oheger <gi...@git.apache.org>.
Github user oheger commented on the pull request:

    https://github.com/apache/commons-lang/pull/95#issuecomment-221967722
  
    Well, the code is ready and fully unit-tested. When we created this pull request, we asked on the ML whether the lang concurrent package would be the right place for this code, but there was no reaction. So this question is still open.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: Implementations of the circuit breaker ...

Posted by britter <gi...@git.apache.org>.
Github user britter commented on the pull request:

    https://github.com/apache/commons-lang/pull/95#issuecomment-222085429
  
    @oheger @PascalSchumacher: Nobody objected adding it to the concurrent package. So from PoV it can be integrated into LANG.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: Implementations of the circuit breaker ...

Posted by PascalSchumacher <gi...@git.apache.org>.
Github user PascalSchumacher commented on the pull request:

    https://github.com/apache/commons-lang/pull/95#issuecomment-221935689
  
    I guess this is ready to merge?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request #95: Implementations of the circuit breaker patter...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/commons-lang/pull/95


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang issue #95: Implementations of the circuit breaker pattern relat...

Posted by PascalSchumacher <gi...@git.apache.org>.
Github user PascalSchumacher commented on the issue:

    https://github.com/apache/commons-lang/pull/95
  
    Thanks! :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---