You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Alexander Pivovarov <ap...@gmail.com> on 2015/04/28 20:54:43 UTC
Review Request 33637: HIVE-10519 Move TestGenericUDF classes to
udf.generic package
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33637/
-----------------------------------------------------------
Review request for hive and Jason Dere.
Bugs: HIVE-10519
https://issues.apache.org/jira/browse/HIVE-10519
Repository: hive-git
Description
-------
HIVE-10519 Move TestGenericUDF classes to udf.generic package
Diffs
-----
ql/src/test/org/apache/hadoop/hive/ql/udf/TestGenericUDFDate.java 0d40ff7cb3c47ed4c2a8d2e88d9d8c32eb87d09d
ql/src/test/org/apache/hadoop/hive/ql/udf/TestGenericUDFDateAdd.java 0f3ecd18ae04ca9e44f0d55400fbacd3a879f9fc
ql/src/test/org/apache/hadoop/hive/ql/udf/TestGenericUDFDateDiff.java 849e70c17a1e2c839bf857ca22b5b61cda6de9e1
ql/src/test/org/apache/hadoop/hive/ql/udf/TestGenericUDFDateSub.java ae1b3db5568f86c26e281c3cedb42821ebc5b450
ql/src/test/org/apache/hadoop/hive/ql/udf/TestGenericUDFUtils.java 7399a7cd964913a1ae7f18b85cb050bba56acfe6
Diff: https://reviews.apache.org/r/33637/diff/
Testing
-------
Thanks,
Alexander Pivovarov
Re: Review Request 33637: HIVE-10519 Move TestGenericUDF classes to
udf.generic package
Posted by Jason Dere <jd...@hortonworks.com>.
> On April 30, 2015, 8:18 p.m., Jason Dere wrote:
> > ql/src/test/org/apache/hadoop/hive/ql/udf/TestGenericUDFDateAdd.java, line 19
> > <https://reviews.apache.org/r/33637/diff/2/?file=944335#file944335line19>
> >
> > Do all of these moved files need to have their package names changed? I only see that 2 of the files here have such changes
Nevermind, verified the package names were changed by looking at the patch
- Jason
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33637/#review82195
-----------------------------------------------------------
On April 30, 2015, 8:25 p.m., Alexander Pivovarov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33637/
> -----------------------------------------------------------
>
> (Updated April 30, 2015, 8:25 p.m.)
>
>
> Review request for hive and Jason Dere.
>
>
> Bugs: HIVE-10519
> https://issues.apache.org/jira/browse/HIVE-10519
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-10519 Move TestGenericUDF classes to udf.generic package
>
>
> Diffs
> -----
>
> ql/src/test/org/apache/hadoop/hive/ql/udf/TestGenericUDFDate.java 0d40ff7cb3c47ed4c2a8d2e88d9d8c32eb87d09d
> ql/src/test/org/apache/hadoop/hive/ql/udf/TestGenericUDFDateAdd.java 0f3ecd18ae04ca9e44f0d55400fbacd3a879f9fc
> ql/src/test/org/apache/hadoop/hive/ql/udf/TestGenericUDFDateDiff.java 849e70c17a1e2c839bf857ca22b5b61cda6de9e1
> ql/src/test/org/apache/hadoop/hive/ql/udf/TestGenericUDFDateSub.java ae1b3db5568f86c26e281c3cedb42821ebc5b450
> ql/src/test/org/apache/hadoop/hive/ql/udf/TestGenericUDFUtils.java 7399a7cd964913a1ae7f18b85cb050bba56acfe6
>
> Diff: https://reviews.apache.org/r/33637/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Pivovarov
>
>
Re: Review Request 33637: HIVE-10519 Move TestGenericUDF classes to
udf.generic package
Posted by Jason Dere <jd...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33637/#review82195
-----------------------------------------------------------
ql/src/test/org/apache/hadoop/hive/ql/udf/TestGenericUDFDateAdd.java
<https://reviews.apache.org/r/33637/#comment132895>
Do all of these moved files need to have their package names changed? I only see that 2 of the files here have such changes
- Jason Dere
On April 28, 2015, 6:59 p.m., Alexander Pivovarov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33637/
> -----------------------------------------------------------
>
> (Updated April 28, 2015, 6:59 p.m.)
>
>
> Review request for hive and Jason Dere.
>
>
> Bugs: HIVE-10519
> https://issues.apache.org/jira/browse/HIVE-10519
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-10519 Move TestGenericUDF classes to udf.generic package
>
>
> Diffs
> -----
>
> ql/src/test/org/apache/hadoop/hive/ql/udf/TestGenericUDFDate.java 0d40ff7cb3c47ed4c2a8d2e88d9d8c32eb87d09d
> ql/src/test/org/apache/hadoop/hive/ql/udf/TestGenericUDFDateAdd.java 0f3ecd18ae04ca9e44f0d55400fbacd3a879f9fc
> ql/src/test/org/apache/hadoop/hive/ql/udf/TestGenericUDFDateDiff.java 849e70c17a1e2c839bf857ca22b5b61cda6de9e1
> ql/src/test/org/apache/hadoop/hive/ql/udf/TestGenericUDFDateSub.java ae1b3db5568f86c26e281c3cedb42821ebc5b450
> ql/src/test/org/apache/hadoop/hive/ql/udf/TestGenericUDFUtils.java 7399a7cd964913a1ae7f18b85cb050bba56acfe6
>
> Diff: https://reviews.apache.org/r/33637/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Pivovarov
>
>
Re: Review Request 33637: HIVE-10519 Move TestGenericUDF classes to
udf.generic package
Posted by Alexander Pivovarov <ap...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33637/
-----------------------------------------------------------
(Updated April 30, 2015, 8:25 p.m.)
Review request for hive and Jason Dere.
Changes
-------
diff #3. run "rbt post -u -g yes" again. RBT diff #3 matches patch #2 attached to Jira
Bugs: HIVE-10519
https://issues.apache.org/jira/browse/HIVE-10519
Repository: hive-git
Description
-------
HIVE-10519 Move TestGenericUDF classes to udf.generic package
Diffs (updated)
-----
ql/src/test/org/apache/hadoop/hive/ql/udf/TestGenericUDFDate.java 0d40ff7cb3c47ed4c2a8d2e88d9d8c32eb87d09d
ql/src/test/org/apache/hadoop/hive/ql/udf/TestGenericUDFDateAdd.java 0f3ecd18ae04ca9e44f0d55400fbacd3a879f9fc
ql/src/test/org/apache/hadoop/hive/ql/udf/TestGenericUDFDateDiff.java 849e70c17a1e2c839bf857ca22b5b61cda6de9e1
ql/src/test/org/apache/hadoop/hive/ql/udf/TestGenericUDFDateSub.java ae1b3db5568f86c26e281c3cedb42821ebc5b450
ql/src/test/org/apache/hadoop/hive/ql/udf/TestGenericUDFUtils.java 7399a7cd964913a1ae7f18b85cb050bba56acfe6
Diff: https://reviews.apache.org/r/33637/diff/
Testing
-------
Thanks,
Alexander Pivovarov
Re: Review Request 33637: HIVE-10519 Move TestGenericUDF classes to
udf.generic package
Posted by Alexander Pivovarov <ap...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33637/
-----------------------------------------------------------
(Updated April 28, 2015, 6:59 p.m.)
Review request for hive and Jason Dere.
Changes
-------
Organize Imports
Bugs: HIVE-10519
https://issues.apache.org/jira/browse/HIVE-10519
Repository: hive-git
Description
-------
HIVE-10519 Move TestGenericUDF classes to udf.generic package
Diffs (updated)
-----
ql/src/test/org/apache/hadoop/hive/ql/udf/TestGenericUDFDate.java 0d40ff7cb3c47ed4c2a8d2e88d9d8c32eb87d09d
ql/src/test/org/apache/hadoop/hive/ql/udf/TestGenericUDFDateAdd.java 0f3ecd18ae04ca9e44f0d55400fbacd3a879f9fc
ql/src/test/org/apache/hadoop/hive/ql/udf/TestGenericUDFDateDiff.java 849e70c17a1e2c839bf857ca22b5b61cda6de9e1
ql/src/test/org/apache/hadoop/hive/ql/udf/TestGenericUDFDateSub.java ae1b3db5568f86c26e281c3cedb42821ebc5b450
ql/src/test/org/apache/hadoop/hive/ql/udf/TestGenericUDFUtils.java 7399a7cd964913a1ae7f18b85cb050bba56acfe6
Diff: https://reviews.apache.org/r/33637/diff/
Testing
-------
Thanks,
Alexander Pivovarov