You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2012/11/12 02:03:05 UTC

Review Request: SQOOP-692 Move execution specific error codes from CoreError to it's own error codes class

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8015/
-----------------------------------------------------------

Review request for Sqoop.


Description
-------

I've moved execution specific error codes to newly created ErrorCode class.


This addresses bug SQOOP-692.
    https://issues.apache.org/jira/browse/SQOOP-692


Diffs
-----

  core/src/main/java/org/apache/sqoop/core/CoreError.java 08034ed910cbfb288295f1ab32b8d70ec6bea0a4 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/MapreduceExecutionError.java PRE-CREATION 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/etl/HdfsSequenceImportLoader.java 1235d1d90e14c35ac898f9d4dca0f969b561e47e 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/etl/HdfsTextImportLoader.java 36aa11f7f2871e99fbc84d518bfa524d108f3cf4 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/io/Data.java 4ddd13209e4b581d32fc46508826e7e40683b3ee 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopMapper.java dbe832a44eade338676d41ed26aeb3547506de91 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java 96e1533ec1899f618b5a49c7a4fabac1abbb541a 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopSplit.java 7dc9541350a85e4178975b45e97619f99d1aa509 

Diff: https://reviews.apache.org/r/8015/diff/


Testing
-------

Tests are passing.


Thanks,

Jarek Cecho


Re: Review Request: SQOOP-692 Move execution specific error codes from CoreError to it's own error codes class

Posted by Bilung Lee <bl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8015/#review13370
-----------------------------------------------------------

Ship it!


Ship It!

- Bilung Lee


On Nov. 12, 2012, 1:03 a.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8015/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2012, 1:03 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Description
> -------
> 
> I've moved execution specific error codes to newly created ErrorCode class.
> 
> 
> This addresses bug SQOOP-692.
>     https://issues.apache.org/jira/browse/SQOOP-692
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/sqoop/core/CoreError.java 08034ed910cbfb288295f1ab32b8d70ec6bea0a4 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/MapreduceExecutionError.java PRE-CREATION 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/etl/HdfsSequenceImportLoader.java 1235d1d90e14c35ac898f9d4dca0f969b561e47e 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/etl/HdfsTextImportLoader.java 36aa11f7f2871e99fbc84d518bfa524d108f3cf4 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/io/Data.java 4ddd13209e4b581d32fc46508826e7e40683b3ee 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopMapper.java dbe832a44eade338676d41ed26aeb3547506de91 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java 96e1533ec1899f618b5a49c7a4fabac1abbb541a 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopSplit.java 7dc9541350a85e4178975b45e97619f99d1aa509 
> 
> Diff: https://reviews.apache.org/r/8015/diff/
> 
> 
> Testing
> -------
> 
> Tests are passing.
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>